From 5ab6f03264de676a83cb5c5c137d3a2fde278f1f Mon Sep 17 00:00:00 2001
From: Ismo Vuorinen <ismo@ivuorinen.net>
Date: Thu, 20 Nov 2025 11:23:53 +0200
Subject: [PATCH] refactor(go): remove redundant caching from Go actions

Remove redundant common-cache usage in Go actions since setup-go with
cache:true already provides comprehensive caching.

Changes:
- go-build: Removed duplicate common-cache step (setup-go caches
  ~/go/pkg/mod and ~/.cache/go-build automatically)
- go-lint: Removed redundant ~/.cache/go-build from cache paths
  (kept ~/.cache/golangci-lint as it's linter-specific and not
  covered by setup-go)

Performance improvements:
- Eliminates duplicate caching operations
- Reduces action initialization overhead
- setup-go's native caching is more efficient and maintained

setup-go with cache:true caches:
- ~/go/pkg/mod (Go modules)
- ~/.cache/go-build (Go build cache)
---
 go-build/action.yml               | 10 ----------
 go-lint/action.yml                |  4 ++--
 language-version-detect/README.md |  2 +-
 3 files changed, 3 insertions(+), 13 deletions(-)

diff --git a/go-build/action.yml b/go-build/action.yml
index b7d22cb..b4d8fb0 100644
--- a/go-build/action.yml
+++ b/go-build/action.yml
@@ -164,17 +164,7 @@ runs:
         go-version: ${{ steps.detect-go-version.outputs.detected-version }}
         cache: true
 
-    - name: Cache Go Dependencies
-      id: cache-go
-      uses: ivuorinen/actions/common-cache@0fa9a68f07a1260b321f814202658a6089a43d42
-      with:
-        type: 'go'
-        paths: '~/go/pkg/mod'
-        key-files: 'go.mod,go.sum'
-        key-prefix: 'go-build'
-
     - name: Download Dependencies
-      if: steps.cache-go.outputs.cache-hit != 'true'
       uses: step-security/retry@e1d59ce1f574b32f0915e3a8df055cfe9f99be5d # v3
       with:
         timeout_minutes: 10
diff --git a/go-lint/action.yml b/go-lint/action.yml
index c04d00e..76bcb7e 100644
--- a/go-lint/action.yml
+++ b/go-lint/action.yml
@@ -215,13 +215,13 @@ runs:
       with:
         token: ${{ inputs.token || github.token }}
 
-    - name: Set up Cache
+    - name: Cache golangci-lint
       id: cache
       if: inputs.cache == 'true'
       uses: ivuorinen/actions/common-cache@0fa9a68f07a1260b321f814202658a6089a43d42
       with:
         type: 'go'
-        paths: '~/.cache/golangci-lint,~/.cache/go-build'
+        paths: '~/.cache/golangci-lint'
         key-prefix: 'golangci-${{ inputs.golangci-lint-version }}'
         key-files: 'go.sum,${{ inputs.config-file }}'
         restore-keys: '${{ runner.os }}-golangci-${{ inputs.golangci-lint-version }}-'
diff --git a/language-version-detect/README.md b/language-version-detect/README.md
index 0436820..0b5ac2c 100644
--- a/language-version-detect/README.md
+++ b/language-version-detect/README.md
@@ -28,7 +28,7 @@ This action is a `composite` action.
 ### Usage
 
 ```yaml
-- uses: ivuorinen/actions/language-version-detect@v2025
+- uses: ivuorinen/actions/language-version-detect@main
   with:
     language:
     # Language to detect version for (php, python, go, dotnet)