3 Commits

Author	SHA1	Message	Date
Ismo Vuorinen	9aa16a8164	feat: use our own actions in our workflows (#377) ... * feat: use our own actions in our workflows * fix: add missing inputs to validate-inputs, refactor node * chore: cr comment fixes * fix: update-validators formatting * chore: update validators, add tests, conventions * feat: validate severity with severity_enum * feat: add 10 generic validators to improve input validation coverage Add comprehensive validation system improvements across multiple phases: Phase 2A - Quick Wins: - Add multi_value_enum validator for 2-10 value enumerations - Add exit_code_list validator for Unix/Linux exit codes (0-255) - Refactor coverage_driver to use multi_value_enum Phase 2B - High-Value Validators: - Add key_value_list validator with shell injection prevention - Add path_list validator with path traversal and glob support Quick Wins - Additional Enums: - Add network_mode validator for Docker network modes - Add language_enum validator for language detection - Add framework_mode validator for PHP framework modes - Update boolean pattern to include 'push' Phase 2C - Specialized Validators: - Add json_format validator for JSON syntax validation - Add cache_config validator for Docker BuildKit cache configs Improvements: - All validators include comprehensive security checks - Pattern-based validation with clear error messages - 23 new test methods with edge case coverage - Update special case mappings for 20+ inputs - Fix build-args mapping test expectation Coverage impact: 22 actions now at 100% validation (88% → 92%) Test suite: 762 → 785 tests (+23 tests, all passing) * chore: regenerate rules.yml with improved validator coverage Regenerate validation rules for all actions with new validators: - compress-images: 86% → 100% (+1 input: ignore-paths) - docker-build: 63% → 100% (+4 inputs: cache configs, platform-build-args) - docker-publish: 73% → 100% (+1 input: build-args) - language-version-detect: 67% → 100% (+1 input: language) - php-tests: 89% (fixed framework→framework_mode mapping) - prettier-lint: 86% → 100% (+2 inputs: file-pattern, plugins) - security-scan: 86% (maintained coverage) Overall: 23 of 25 actions now at 100% validation coverage (92%) * fix: address PR #377 review comments - Add | None type annotations to 6 optional parameters (PEP 604) - Standardize injection pattern: remove @# from comma_separated_list validator (@ and # are not shell injection vectors, allows npm scoped packages) - Remove dead code: unused value expression in key_value_list validator - Update tests to reflect injection pattern changes	2025-11-25 23:51:03 +02:00
Ismo Vuorinen	ab371bdebf	feat: simplify actions (#353) ... * feat: first pass simplification * refactor: simplify actions repository structure Major simplification reducing actions from 44 to 30: Consolidations: - Merge biome-check + biome-fix → biome-lint (mode: check/fix) - Merge eslint-check + eslint-fix → eslint-lint (mode: check/fix) - Merge prettier-check + prettier-fix → prettier-lint (mode: check/fix) - Merge 5 version-detect actions → language-version-detect (language param) Removals: - common-file-check, common-retry (better served by external tools) - docker-publish-gh, docker-publish-hub (consolidated into docker-publish) - github-release (redundant with existing tooling) - set-git-config (no longer needed) - version-validator (functionality moved to language-version-detect) Fixes: - Rewrite docker-publish to use official Docker actions directly - Update validate-inputs example (eslint-fix → eslint-lint) - Update tests and documentation for new structure Result: ~6,000 lines removed, cleaner action catalog, maintained functionality. * refactor: complete action simplification and cleanup Remove deprecated actions and update remaining actions: Removed: - common-file-check, common-retry: utility actions - docker-publish-gh, docker-publish-hub: replaced by docker-publish wrapper - github-release, version-validator, set-git-config: no longer needed - Various version-detect actions: replaced by language-version-detect Updated: - docker-publish: rewrite as simple wrapper using official Docker actions - validate-inputs: update example (eslint-fix → eslint-lint) - Multiple actions: update configurations and remove deprecated dependencies - Tests: update integration/unit tests for new structure - Documentation: update README, remove test for deleted actions Configuration updates: - Linter configs, ignore files for new structure - Makefile, pyproject.toml updates * fix: enforce POSIX compliance in GitHub workflows Convert all workflow shell scripts to POSIX-compliant sh: Critical fixes: - Replace bash with sh in all shell declarations - Replace [[ with [ for test conditions - Replace == with = for string comparisons - Replace set -euo pipefail with set -eu - Split compound AND conditions into separate [ ] tests Files updated: - .github/workflows/test-actions.yml (7 shell declarations, 10 test operators) - .github/workflows/security-suite.yml (set -eu) - .github/workflows/action-security.yml (2 shell declarations) - .github/workflows/pr-lint.yml (3 shell declarations) - .github/workflows/issue-stats.yml (1 shell declaration) Ensures compatibility with minimal sh implementations and aligns with CLAUDE.md standards requiring POSIX shell compliance across all scripts. All tests pass: 764 pytest tests, 100% coverage. * fix: add missing permissions for private repository support Add critical permissions to pr-lint workflow for private repositories: Workflow-level permissions: + packages: read - Access private npm/PyPI/Composer packages Job-level permissions: + packages: read - Access private packages during dependency installation + checks: write - Create and update check runs Fixes failures when: - Installing private npm packages from GitHub Packages - Installing private Composer dependencies - Installing private Python packages - Creating status checks with github-script Valid permission scopes per actionlint: actions, attestations, checks, contents, deployments, discussions, id-token, issues, models, packages, pages, pull-requests, repository-projects, security-events, statuses Note: "workflows" and "metadata" are NOT valid permission scopes (they are PAT-only scopes or auto-granted respectively). * docs: update readmes * fix: replace bash-specific 'source' with POSIX '.' command Replace all occurrences of 'source' with '.' (dot) for POSIX compliance: Changes in python-lint-fix/action.yml: - Line 165: source .venv/bin/activate → . .venv/bin/activate - Line 179: source .venv/bin/activate → . .venv/bin/activate - Line 211: source .venv/bin/activate → . .venv/bin/activate Also fixed bash-specific test operator: - Line 192: [[ "$FAIL_ON_ERROR" == "true" ]] → [ "$FAIL_ON_ERROR" = "true" ] The 'source' command is bash-specific. POSIX sh uses '.' (dot) to source files. Both commands have identical functionality but '.' is portable across all POSIX-compliant shells. * security: fix code injection vulnerability in docker-publish Fix CodeQL code injection warning (CWE-094, CWE-095, CWE-116): Issue: inputs.context was used directly in GitHub Actions expression without sanitization at line 194, allowing potential code injection by external users. Fix: Use environment variable indirection to prevent expression injection: - Added env.BUILD_CONTEXT to capture inputs.context - Changed context parameter to use ${{ env.BUILD_CONTEXT }} Environment variables are evaluated after expression compilation, preventing malicious code execution during workflow parsing. Security Impact: Medium severity (CVSS 5.0) Identified by: GitHub Advanced Security (CodeQL) Reference: https://github.com/ivuorinen/actions/pull/353#pullrequestreview-3481935924 * security: prevent credential persistence in pr-lint checkout Add persist-credentials: false to checkout step to mitigate untrusted checkout vulnerability. This prevents GITHUB_TOKEN from being accessible to potentially malicious PR code. Fixes: CodeQL finding CWE-829 (untrusted checkout on privileged workflow) * fix: prevent security bot from overwriting unrelated comments Replace broad string matching with unique HTML comment marker for identifying bot-generated comments. Previously, any comment containing 'Security Analysis' or '🔐 GitHub Actions Permissions' would be overwritten, causing data loss. Changes: - Add unique marker: <!-- security-analysis-bot-comment --> - Prepend marker to generated comment body - Update comment identification to use marker only - Add defensive null check for comment.body This fixes critical data loss bug where user comments could be permanently overwritten by the security analysis bot. Follows same proven pattern as test-actions.yml coverage comments. * improve: show concise permissions diff instead of full blocks Replace verbose full-block permissions diff with line-by-line changes. Now shows only added/removed permissions, making output much more readable. Changes: - Parse permissions into individual lines - Compare old vs new to identify actual changes - Show only removed (-) and added (+) lines in diff - Collapse unchanged permissions into details section (≤3 items) - Show count summary for many unchanged permissions (>3 items) Example output: Before: 30+ lines showing entire permissions block After: 3-5 lines showing only what changed This addresses user feedback that permissions changes were too verbose. * security: add input validation and trust model documentation Add comprehensive security validation for docker-publish action to prevent code injection attacks (CWE-094, CWE-116). Changes: - Add validation for context input (reject absolute paths, warn on URLs) - Add validation for dockerfile input (reject absolute/URL paths) - Document security trust model in README - Add best practices for secure usage - Explain validation rules and threat model Prevents malicious actors from: - Building from arbitrary file system locations - Fetching Dockerfiles from untrusted remote sources - Executing code injection through build context manipulation Addresses: CodeRabbit review comments #2541434325, #2541549615 Fixes: GitHub Advanced Security code injection findings * security: replace unmaintained nick-fields/retry with step-security/retry Replace nick-fields/retry with step-security/retry across all 4 actions: - csharp-build/action.yml - php-composer/action.yml - go-build/action.yml - ansible-lint-fix/action.yml The nick-fields/retry action has security vulnerabilities and low maintenance. step-security/retry is a drop-in replacement with full API compatibility. All inputs (timeout_minutes, max_attempts, command, retry_wait_seconds) are compatible. Using SHA-pinned version for security. Addresses CodeRabbit review comment #2541549598 * test: add is_input_required() helper function Add helper function to check if an action input is required, reducing duplication across test suites. The function: - Takes action_file and input_name as parameters - Uses validation_core.py to query the 'required' property - Returns 0 (success) if input is required - Returns 1 (failure) if input is optional This DRY improvement addresses CodeRabbit review comment #2541549572 * feat: add mode validation convention mapping Add "mode" to the validation conventions mapping for lint actions (eslint-lint, biome-lint, prettier-lint). Note: The update-validators script doesn't currently recognize "string" as a validator type, so mode validation coverage remains at 93%. The actions already have inline validation for mode (check|fix), so this is primarily for improving coverage metrics. Addresses part of CodeRabbit review comment #2541549570 (validation coverage improvement) * docs: fix CLAUDE.md action counts and add missing action - Update action count from 31 to 29 (line 42) - Add missing 'action-versioning' to Utilities category (line 74) Addresses CodeRabbit review comments #2541553130 and #2541553110 * docs: add security considerations to docker-publish Add security documentation to both action.yml header and README.md: - Trust model explanation - Input validation details for context and dockerfile - Attack prevention information - Best practices for secure usage The documentation was previously removed when README was autogenerated. Now documented in both places to ensure it persists. * fix: correct step ID reference in docker-build Fix incorrect step ID reference in platforms output: - Changed steps.platforms.outputs.built to steps.detect-platforms.outputs.platforms - The step is actually named 'detect-platforms' not 'platforms' - Ensures output correctly references the detect-platforms step defined at line 188 * fix: ensure docker-build platforms output is always available Make detect-platforms step unconditional to fix broken output contract. The platforms output (line 123) references steps.detect-platforms.outputs.platforms, but the step only ran when auto-detect-platforms was true (default: false). This caused undefined output in most cases. Changes: - Remove 'if' condition from detect-platforms step - Step now always runs and always produces platforms output - When auto-detect is false: outputs configured architectures - When auto-detect is true: outputs detected platforms or falls back to architectures - Add '|| true' to grep to prevent errors when no platforms detected Fixes CodeRabbit review comment #2541824904 * security: remove env var indirection in docker-publish BUILD_CONTEXT Remove BUILD_CONTEXT env var indirection to address GitHub Advanced Security alert. The inputs.context is validated at lines 137-147 (rejects absolute paths, warns on URLs) before being used, so the env var indirection is unnecessary and triggers false positive code injection warnings. Changes: - Remove BUILD_CONTEXT env var (line 254) - Use inputs.context directly (line 256 → 254) - Input validation remains in place (lines 137-147) Fixes GitHub Advanced Security code injection alerts (comments #2541405269, #2541522320) * feat: implement mode_enum validator for lint actions Add mode_enum validator to validate mode inputs in linting actions. Changes to conventions.py: - Add 'mode_enum' to exact_matches mapping (line 215) - Add 'mode_enum' to PHP-specific validators list (line 560) - Implement _validate_mode_enum() method (lines 642-660) - Validates mode values against ['check', 'fix'] - Returns clear error messages for invalid values Updated rules.yml files: - biome-lint: Add mode: mode_enum convention - eslint-lint: Add mode: mode_enum convention - prettier-lint: Add mode: mode_enum convention - All rules.yml: Fix YAML formatting with yamlfmt This addresses PR #353 comment #2541522326 which reported that mode validation was being skipped due to unrecognized 'string' type, reducing coverage to 93%. Tested with biome-lint action - correctly rejects invalid values and accepts valid 'check' and 'fix' values. * docs: update action count from 29 to 30 in CLAUDE.md Update two references to action count in CLAUDE.md: - Line 42: repository_overview memory description - Line 74: Repository Structure section header The repository has 30 actions total (29 listed + validate-inputs). Addresses PR #353 comment #2541549588. * docs: use pinned version ref in language-version-detect README Change usage example from @main to @v2025 for security best practices. Using pinned version refs (instead of @main) ensures: - Predictable behavior across workflow runs - Protection against breaking changes - Better security through immutable references Follows repository convention documented in main README and CLAUDE.md. Addresses PR #353 comment #2541549588. * refactor: remove deprecated add-snippets input from codeql-analysis Remove add-snippets input which has been deprecated by GitHub's CodeQL action and no longer has any effect. Changes: - Remove add-snippets input definition (lines 93-96) - Remove reference in init step (line 129) - Remove reference in analyze step (line 211) - Regenerate README and rules.yml This is a non-breaking change since: - Default was 'false' (minimal usage expected) - GitHub's action already ignores this parameter - Aligns with recent repository simplification efforts * feat: add mode_enum validator and update rules Add mode_enum validator support for lint actions and regenerate all validation rules: Validator Changes: - Add mode_enum to action_overrides for biome-lint, eslint-lint, prettier-lint - Remove deprecated add-snippets from codeql-analysis overrides Rules Updates: - All 29 action rules.yml files regenerated with consistent YAML formatting - biome-lint, eslint-lint, prettier-lint now validate mode input (check/fix) - Improved coverage for lint actions (79% → 83% for biome, 93% for eslint, 79% for prettier) Documentation: - Fix language-version-detect README to use @v2025 (not @main) - Remove outdated docker-publish security docs (now handled by official actions) This completes PR #353 review feedback implementation. * fix: replace bash-specific $'\n' with POSIX-compliant printf Replace non-POSIX $'\n' syntax in tag building loop with printf-based approach that works in any POSIX shell. Changed: - Line 216: tags="${tags}"$'\n'"${image}:${tag}" + Line 216: tags="$(printf '%s\n%s' "$tags" "${image}:${tag}")" This ensures docker-publish/action.yml runs correctly on systems using /bin/sh instead of bash.	2025-11-19 15:42:06 +02:00
Ismo Vuorinen	78fdad69e5	feat: fixes, tweaks, new actions, linting (#186) ... * feat: fixes, tweaks, new actions, linting * fix: improve docker publish loops and dotnet parsing (#193) * fix: harden action scripts and version checks (#191) * refactor: major repository restructuring and security enhancements Add comprehensive development infrastructure: - Add Makefile with automated documentation generation, formatting, and linting tasks - Add TODO.md tracking self-containment progress and repository improvements - Add .nvmrc for consistent Node.js version management - Create python-version-detect-v2 action for enhanced Python detection Enhance all GitHub Actions with standardized patterns: - Add consistent token handling across 27 actions using standardized input patterns - Implement bash error handling (set -euo pipefail) in all shell steps - Add comprehensive input validation for path traversal and command injection protection - Standardize checkout token authentication to prevent rate limiting - Remove relative action dependencies to ensure external usability Rewrite security workflow for PR-focused analysis: - Transform security-suite.yml to PR-only security analysis workflow - Remove scheduled runs, repository issue management, and Slack notifications - Implement smart comment generation showing only sections with content - Add GitHub Actions permission diff analysis and new action detection - Integrate OWASP, Semgrep, and TruffleHog for comprehensive PR security scanning Improve version detection and dependency management: - Simplify version detection actions to use inline logic instead of shared utilities - Fix Makefile version detection fallback to properly return 'main' when version not found - Update all external action references to use SHA-pinned versions - Remove deprecated run.sh in favor of Makefile automation Update documentation and project standards: - Enhance CLAUDE.md with self-containment requirements and linting standards - Update README.md with improved action descriptions and usage examples - Standardize code formatting with updated .editorconfig and .prettierrc.yml - Improve GitHub templates for issues and security reporting This refactoring ensures all 40 actions are fully self-contained and can be used independently when referenced as ivuorinen/actions/action-name@main, addressing the critical requirement for external usability while maintaining comprehensive security analysis and development automation. * feat: add automated action catalog generation system - Create generate_listing.cjs script for comprehensive action catalog - Add package.json with development tooling and npm scripts - Implement automated README.md catalog section with --update flag - Generate markdown reference-style links for all 40 actions - Add categorized tables with features, language support matrices - Replace static reference links with auto-generated dynamic links - Enable complete automation of action documentation maintenance * feat: enhance actions with improved documentation and functionality - Add comprehensive README files for 12 actions with usage examples - Implement new utility actions (go-version-detect, dotnet-version-detect) - Enhance node-setup with extensive configuration options - Improve error handling and validation across all actions - Update package.json scripts for better development workflow - Expand TODO.md with detailed roadmap and improvement plans - Standardize action structure with consistent inputs/outputs * feat: add comprehensive output handling across all actions - Add standardized outputs to 15 actions that previously had none - Implement consistent snake_case naming convention for all outputs - Add build status and test results outputs to build actions - Add files changed and status outputs to lint/fix actions - Add test execution metrics to php-tests action - Add stale/closed counts to stale action - Add release URLs and IDs to github-release action - Update documentation with output specifications - Mark comprehensive output handling task as complete in TODO.md * feat: implement shared cache strategy across all actions - Add caching to 10 actions that previously had none (Node.js, .NET, Python, Go) - Standardize 4 existing actions to use common-cache instead of direct actions/cache - Implement consistent cache-hit optimization to skip installations when cache available - Add language-specific cache configurations with appropriate key files - Create unified caching approach using ivuorinen/actions/common-cache@main - Fix YAML syntax error in php-composer action paths parameter - Update TODO.md to mark shared cache strategy as complete * feat: implement comprehensive retry logic for network operations - Create new common-retry action for standardized retry patterns with configurable strategies - Add retry logic to 9 actions missing network retry capabilities - Implement exponential backoff, custom timeouts, and flexible error handling - Add max-retries input parameter to all network-dependent actions (Node.js, .NET, Python, Go) - Standardize existing retry implementations to use common-retry utility - Update action catalog to include new common-retry action (41 total actions) - Update documentation with retry configuration examples and parameters - Mark retry logic implementation as complete in TODO.md roadmap * feat: enhance Node.js support with Corepack and Bun - Add Corepack support for automatic package manager version management - Add Bun package manager support across all Node.js actions - Improve Yarn Berry/PnP support with .yarnrc.yml detection - Add Node.js feature detection (ESM, TypeScript, frameworks) - Update package manager detection priority and lockfile support - Enhance caching with package-manager-specific keys - Update eslint, prettier, and biome actions for multi-package-manager support * fix: resolve critical runtime issues across multiple actions - Fix token validation by removing ineffective literal string comparisons - Add missing @microsoft/eslint-formatter-sarif dependency for SARIF output - Fix Bash variable syntax errors in username and changelog length checks - Update Dockerfile version regex to handle tags with suffixes (e.g., -alpine) - Simplify version selection logic with single grep command - Fix command execution in retry action with proper bash -c wrapper - Correct step output references using .outcome instead of .outputs.outcome - Add missing step IDs for version detection actions - Include go.mod in cache key files for accurate invalidation - Require minor version in all version regex patterns - Improve Bun installation security by verifying script before execution - Replace bc with sort -V for portable PHP version comparison - Remove non-existent pre-commit output references These fixes ensure proper runtime behavior, improved security, and better cross-platform compatibility across all affected actions. * fix: resolve critical runtime and security issues across actions - Fix biome-fix files_changed calculation using git diff instead of git status delta - Fix compress-images output description and add absolute path validation - Remove csharp-publish token default and fix token fallback in push commands - Add @microsoft/eslint-formatter-sarif to all package managers in eslint-check - Fix eslint-check command syntax by using variable assignment - Improve node-setup Bun installation security and remove invalid frozen-lockfile flag - Fix pre-commit token validation by removing ineffective literal comparison - Fix prettier-fix token comparison and expand regex for all GitHub token types - Add version-file-parser regex validation safety and fix csproj wildcard handling These fixes address security vulnerabilities, runtime errors, and functional issues to ensure reliable operation across all affected GitHub Actions. * feat: enhance Docker actions with advanced multi-architecture support Major enhancement to Docker build and publish actions with comprehensive multi-architecture capabilities and enterprise-grade features. Added features: - Advanced buildx configuration (version control, cache modes, build contexts) - Auto-detect platforms for dynamic architecture discovery - Performance optimizations with enhanced caching strategies - Security scanning with Trivy and image signing with Cosign - SBOM generation in multiple formats with validation - Verbose logging and dry-run modes for debugging - Platform-specific build args and fallback mechanisms Enhanced all Docker actions: - docker-build: Core buildx features and multi-arch support - docker-publish-gh: GitHub Packages with security features - docker-publish-hub: Docker Hub with scanning and signing - docker-publish: Orchestrator with unified configuration Updated documentation across all modified actions. * fix: resolve documentation generation placeholder issue Fixed Makefile and package.json to properly replace placeholder tokens in generated documentation, ensuring all README files show correct repository paths instead of ***PROJECT***@***VERSION***. * chore: simplify github token validation * chore(lint): optional yamlfmt, config and fixes * feat: use relative `uses` names * feat: comprehensive testing infrastructure and Python validation system - Migrate from tests/ to _tests/ directory structure with ShellSpec framework - Add comprehensive validation system with Python-based input validation - Implement dual testing approach (ShellSpec + pytest) for complete coverage - Add modern Python tooling (uv, ruff, pytest-cov) and dependencies - Create centralized validation rules with automatic generation system - Update project configuration and build system for new architecture - Enhance documentation to reflect current testing capabilities This establishes a robust foundation for action validation and testing with extensive coverage across all GitHub Actions in the repository. * chore: remove Dockerfile for now * chore: code review fixes * feat: comprehensive GitHub Actions restructuring and tooling improvements This commit represents a major restructuring of the GitHub Actions monorepo with improved tooling, testing infrastructure, and comprehensive PR #186 review implementation. ## Major Changes ### 🔧 Development Tooling & Configuration - **Shellcheck integration**: Exclude shellspec test files from linting - Updated .pre-commit-config.yaml to exclude _tests/*.sh from shellcheck/shfmt - Modified Makefile shellcheck pattern to skip shellspec files - Updated CLAUDE.md documentation with proper exclusion syntax - **Testing infrastructure**: Enhanced Python validation framework - Fixed nested if statements and boolean parameter issues in validation.py - Improved code quality with explicit keyword arguments - All pre-commit hooks now passing ### 🏗️ Project Structure & Documentation - **Added Serena AI integration** with comprehensive project memories: - Project overview, structure, and technical stack documentation - Code style conventions and completion requirements - Comprehensive PR #186 review analysis and implementation tracking - **Enhanced configuration**: Updated .gitignore, .yamlfmt.yml, pyproject.toml - **Improved testing**: Added integration workflows and enhanced test specs ### 🚀 GitHub Actions Improvements (30+ actions updated) - **Centralized validation**: Updated 41 validation rule files - **Enhanced actions**: Improvements across all action categories: - Setup actions (node-setup, version detectors) - Utility actions (version-file-parser, version-validator) - Linting actions (biome, eslint, terraform-lint-fix major refactor) - Build/publish actions (docker-build, npm-publish, csharp-*) - Repository management actions ### 📝 Documentation Updates - **README consistency**: Updated version references across action READMEs - **Enhanced documentation**: Improved action descriptions and usage examples - **CLAUDE.md**: Updated with current tooling and best practices ## Technical Improvements - **Security enhancements**: Input validation and sanitization improvements - **Performance optimizations**: Streamlined action logic and dependencies - **Cross-platform compatibility**: Better Windows/macOS/Linux support - **Error handling**: Improved error reporting and user feedback ## Files Changed - 100 files changed - 13 new Serena memory files documenting project state - 41 validation rules updated for consistency - 30+ GitHub Actions and READMEs improved - Core tooling configuration enhanced * feat: comprehensive GitHub Actions improvements and PR review fixes Major Infrastructure Improvements: - Add comprehensive testing framework with 17+ ShellSpec validation tests - Implement Docker-based testing tools with automated test runner - Add CodeRabbit configuration for automated code reviews - Restructure documentation and memory management system - Update validation rules for 25+ actions with enhanced input validation - Modernize CI/CD workflows and testing infrastructure Critical PR Review Fixes (All Issues Resolved): - Fix double caching in node-setup (eliminate redundant cache operations) - Optimize shell pipeline in version-file-parser (single awk vs complex pipeline) - Fix GitHub expression interpolation in prettier-check cache keys - Resolve terraform command order issue (validation after setup) - Add missing flake8-sarif dependency for Python SARIF output - Fix environment variable scope in pr-lint (export to GITHUB_ENV) Performance & Reliability: - Eliminate duplicate cache operations saving CI time - Improve shell script efficiency with optimized parsing - Fix command execution dependencies preventing runtime failures - Ensure proper dependency installation for all linting tools - Resolve workflow conditional logic issues Security & Quality: - All input validation rules updated with latest security patterns - Cross-platform compatibility improvements maintained - Comprehensive error handling and retry logic preserved - Modern development tooling and best practices adopted This commit addresses 100% of actionable feedback from PR review analysis, implements comprehensive testing infrastructure, and maintains high code quality standards across all 41 GitHub Actions. * feat: enhance expression handling and version parsing - Fix node-setup force-version expression logic for proper empty string handling - Improve version-file-parser with secure regex validation and enhanced Python detection - Add CodeRabbit configuration for CalVer versioning and README review guidance * feat(validate-inputs): implement modular validation system - Add modular validator architecture with specialized validators - Implement base validator classes for different input types - Add validators: boolean, docker, file, network, numeric, security, token, version - Add convention mapper for automatic input validation - Add comprehensive documentation for the validation system - Implement PCRE regex support and injection protection * feat(validate-inputs): add validation rules for all actions - Add YAML validation rules for 42 GitHub Actions - Auto-generated rules with convention mappings - Include metadata for validation coverage and quality indicators - Mark rules as auto-generated to prevent manual edits * test(validate-inputs): add comprehensive test suite for validators - Add unit tests for all validator modules - Add integration tests for the validation system - Add fixtures for version test data - Test coverage for boolean, docker, file, network, numeric, security, token, and version validators - Add tests for convention mapper and registry * feat(tools): add validation scripts and utilities - Add update-validators.py script for auto-generating rules - Add benchmark-validator.py for performance testing - Add debug-validator.py for troubleshooting - Add generate-tests.py for test generation - Add check-rules-not-manually-edited.sh for CI validation - Add fix-local-action-refs.py tool for fixing action references * feat(actions): add CustomValidator.py files for specialized validation - Add custom validators for actions requiring special validation logic - Implement validators for docker, go, node, npm, php, python, terraform actions - Add specialized validation for compress-images, common-cache, common-file-check - Implement version detection validators with language-specific logic - Add validation for build arguments, architectures, and version formats * test: update ShellSpec test framework for Python validation - Update all validation.spec.sh files to use Python validator - Add shared validation_core.py for common test utilities - Remove obsolete bash validation helpers - Update test output expectations for Python validator format - Add codeql-analysis test suite - Refactor framework utilities for Python integration - Remove deprecated test files * feat(actions): update action.yml files to use validate-inputs - Replace inline bash validation with validate-inputs action - Standardize validation across all 42 actions - Add new codeql-analysis action - Update action metadata and branding - Add validation step as first step in composite actions - Maintain backward compatibility with existing inputs/outputs * ci: update GitHub workflows for enhanced security and testing - Add new codeql-new.yml workflow - Update security scanning workflows - Enhance dependency review configuration - Update test-actions workflow for new validation system - Improve workflow permissions and security settings - Update action versions to latest SHA-pinned releases * build: update build configuration and dependencies - Update Makefile with new validation targets - Add Python dependencies in pyproject.toml - Update npm dependencies and scripts - Enhance Docker testing tools configuration - Add targets for validator updates and local ref fixes - Configure uv for Python package management * chore: update linting and documentation configuration - Update EditorConfig settings for consistent formatting - Enhance pre-commit hooks configuration - Update prettier and yamllint ignore patterns - Update gitleaks security scanning rules - Update CodeRabbit review configuration - Update CLAUDE.md with latest project standards and rules * docs: update Serena memory files and project metadata - Remove obsolete PR-186 memory files - Update project overview with current architecture - Update project structure documentation - Add quality standards and communication guidelines - Add modular validator architecture documentation - Add shellspec testing framework documentation - Update project.yml with latest configuration * feat: moved rules.yml to same folder as action, fixes * fix(validators): correct token patterns and fix validator bugs - Fix GitHub classic PAT pattern: ghp_ + 36 chars = 40 total - Fix GitHub fine-grained PAT pattern: github_pat_ + 71 chars = 82 total - Initialize result variable in convention_mapper to prevent UnboundLocalError - Fix empty URL validation in network validator to return error - Add GitHub expression check to docker architectures validator - Update docker-build CustomValidator parallel-builds max to 16 * test(validators): fix test fixtures and expectations - Fix token lengths in test data: github_pat 71 chars, ghp/gho 36 chars - Update integration tests with correct token lengths - Fix file validator test to expect absolute paths rejected for security - Rename TestGenerator import to avoid pytest collection warning - Update custom validator tests with correct input names - Change docker-build tests: platforms->architectures, tags->tag - Update docker-publish tests to match new registry enum validation * test(shellspec): fix token lengths in test helpers and specs - Fix default token lengths in spec_helper.sh to use correct 40-char format - Update csharp-publish default tokens in 4 locations - Update codeql-analysis default tokens in 2 locations - Fix codeql-analysis test tokens to correct lengths (40 and 82 chars) - Fix npm-publish fine-grained token test to use 82-char format * feat(actions): add permissions documentation and environment variable usage - Add permissions comments to all action.yml files documenting required GitHub permissions - Convert direct input usage to environment variables in shell steps for security - Add validation steps with proper error handling - Update input descriptions and add security notes where applicable - Ensure all actions follow consistent patterns for input validation * chore(workflows): update GitHub Actions workflow versions - Update workflow action versions to latest - Improve workflow consistency and maintainability * docs(security): add comprehensive security policy - Document security features and best practices - Add vulnerability reporting process - Include audit history and security testing information * docs(memory): add GitHub workflow reference documentation - Add GitHub Actions workflow commands reference - Add GitHub workflow expressions guide - Add secure workflow usage patterns and best practices * chore: token optimization, code style conventions * chore: cr fixes * fix: trivy reported Dockerfile problems * fix(security): more security fixes * chore: dockerfile and make targets for publishing * fix(ci): add creds to test-actions workflow * fix: security fix and checkout step to codeql-new * chore: test fixes * fix(security): codeql detected issues * chore: code review fixes, ReDos protection * style: apply MegaLinter fixes * fix(ci): missing packages read permission * fix(ci): add missing working directory setting * chore: linting, add validation-regex to use regex_pattern * chore: code review fixes * chore(deps): update actions * fix(security): codeql fixes * chore(cr): apply cr comments * chore: improve POSIX compatibility * chore(cr): apply cr comments * fix: codeql warning in Dockerfile, build failures * chore(cr): apply cr comments * fix: docker-testing-tools/Dockerfile * chore(cr): apply cr comments * fix(docker): update testing-tools image for GitHub Actions compatibility * chore(cr): apply cr comments * feat: add more tests, fix issues * chore: fix codeql issues, update actions * chore(cr): apply cr comments * fix: integration tests * chore: deduplication and fixes * style: apply MegaLinter fixes * chore(cr): apply cr comments * feat: dry-run mode for generate-tests * fix(ci): kcov installation * chore(cr): apply cr comments * chore(cr): apply cr comments * chore(cr): apply cr comments * chore(cr): apply cr comments, simplify action testing, use uv * fix: run-tests.sh action counting * chore(cr): apply cr comments * chore(cr): apply cr comments	2025-10-14 13:37:58 +03:00