mirror of
https://github.com/ivuorinen/actions.git
synced 2026-01-26 03:23:59 +00:00
* feat: fixes, tweaks, new actions, linting * fix: improve docker publish loops and dotnet parsing (#193) * fix: harden action scripts and version checks (#191) * refactor: major repository restructuring and security enhancements Add comprehensive development infrastructure: - Add Makefile with automated documentation generation, formatting, and linting tasks - Add TODO.md tracking self-containment progress and repository improvements - Add .nvmrc for consistent Node.js version management - Create python-version-detect-v2 action for enhanced Python detection Enhance all GitHub Actions with standardized patterns: - Add consistent token handling across 27 actions using standardized input patterns - Implement bash error handling (set -euo pipefail) in all shell steps - Add comprehensive input validation for path traversal and command injection protection - Standardize checkout token authentication to prevent rate limiting - Remove relative action dependencies to ensure external usability Rewrite security workflow for PR-focused analysis: - Transform security-suite.yml to PR-only security analysis workflow - Remove scheduled runs, repository issue management, and Slack notifications - Implement smart comment generation showing only sections with content - Add GitHub Actions permission diff analysis and new action detection - Integrate OWASP, Semgrep, and TruffleHog for comprehensive PR security scanning Improve version detection and dependency management: - Simplify version detection actions to use inline logic instead of shared utilities - Fix Makefile version detection fallback to properly return 'main' when version not found - Update all external action references to use SHA-pinned versions - Remove deprecated run.sh in favor of Makefile automation Update documentation and project standards: - Enhance CLAUDE.md with self-containment requirements and linting standards - Update README.md with improved action descriptions and usage examples - Standardize code formatting with updated .editorconfig and .prettierrc.yml - Improve GitHub templates for issues and security reporting This refactoring ensures all 40 actions are fully self-contained and can be used independently when referenced as ivuorinen/actions/action-name@main, addressing the critical requirement for external usability while maintaining comprehensive security analysis and development automation. * feat: add automated action catalog generation system - Create generate_listing.cjs script for comprehensive action catalog - Add package.json with development tooling and npm scripts - Implement automated README.md catalog section with --update flag - Generate markdown reference-style links for all 40 actions - Add categorized tables with features, language support matrices - Replace static reference links with auto-generated dynamic links - Enable complete automation of action documentation maintenance * feat: enhance actions with improved documentation and functionality - Add comprehensive README files for 12 actions with usage examples - Implement new utility actions (go-version-detect, dotnet-version-detect) - Enhance node-setup with extensive configuration options - Improve error handling and validation across all actions - Update package.json scripts for better development workflow - Expand TODO.md with detailed roadmap and improvement plans - Standardize action structure with consistent inputs/outputs * feat: add comprehensive output handling across all actions - Add standardized outputs to 15 actions that previously had none - Implement consistent snake_case naming convention for all outputs - Add build status and test results outputs to build actions - Add files changed and status outputs to lint/fix actions - Add test execution metrics to php-tests action - Add stale/closed counts to stale action - Add release URLs and IDs to github-release action - Update documentation with output specifications - Mark comprehensive output handling task as complete in TODO.md * feat: implement shared cache strategy across all actions - Add caching to 10 actions that previously had none (Node.js, .NET, Python, Go) - Standardize 4 existing actions to use common-cache instead of direct actions/cache - Implement consistent cache-hit optimization to skip installations when cache available - Add language-specific cache configurations with appropriate key files - Create unified caching approach using ivuorinen/actions/common-cache@main - Fix YAML syntax error in php-composer action paths parameter - Update TODO.md to mark shared cache strategy as complete * feat: implement comprehensive retry logic for network operations - Create new common-retry action for standardized retry patterns with configurable strategies - Add retry logic to 9 actions missing network retry capabilities - Implement exponential backoff, custom timeouts, and flexible error handling - Add max-retries input parameter to all network-dependent actions (Node.js, .NET, Python, Go) - Standardize existing retry implementations to use common-retry utility - Update action catalog to include new common-retry action (41 total actions) - Update documentation with retry configuration examples and parameters - Mark retry logic implementation as complete in TODO.md roadmap * feat: enhance Node.js support with Corepack and Bun - Add Corepack support for automatic package manager version management - Add Bun package manager support across all Node.js actions - Improve Yarn Berry/PnP support with .yarnrc.yml detection - Add Node.js feature detection (ESM, TypeScript, frameworks) - Update package manager detection priority and lockfile support - Enhance caching with package-manager-specific keys - Update eslint, prettier, and biome actions for multi-package-manager support * fix: resolve critical runtime issues across multiple actions - Fix token validation by removing ineffective literal string comparisons - Add missing @microsoft/eslint-formatter-sarif dependency for SARIF output - Fix Bash variable syntax errors in username and changelog length checks - Update Dockerfile version regex to handle tags with suffixes (e.g., -alpine) - Simplify version selection logic with single grep command - Fix command execution in retry action with proper bash -c wrapper - Correct step output references using .outcome instead of .outputs.outcome - Add missing step IDs for version detection actions - Include go.mod in cache key files for accurate invalidation - Require minor version in all version regex patterns - Improve Bun installation security by verifying script before execution - Replace bc with sort -V for portable PHP version comparison - Remove non-existent pre-commit output references These fixes ensure proper runtime behavior, improved security, and better cross-platform compatibility across all affected actions. * fix: resolve critical runtime and security issues across actions - Fix biome-fix files_changed calculation using git diff instead of git status delta - Fix compress-images output description and add absolute path validation - Remove csharp-publish token default and fix token fallback in push commands - Add @microsoft/eslint-formatter-sarif to all package managers in eslint-check - Fix eslint-check command syntax by using variable assignment - Improve node-setup Bun installation security and remove invalid frozen-lockfile flag - Fix pre-commit token validation by removing ineffective literal comparison - Fix prettier-fix token comparison and expand regex for all GitHub token types - Add version-file-parser regex validation safety and fix csproj wildcard handling These fixes address security vulnerabilities, runtime errors, and functional issues to ensure reliable operation across all affected GitHub Actions. * feat: enhance Docker actions with advanced multi-architecture support Major enhancement to Docker build and publish actions with comprehensive multi-architecture capabilities and enterprise-grade features. Added features: - Advanced buildx configuration (version control, cache modes, build contexts) - Auto-detect platforms for dynamic architecture discovery - Performance optimizations with enhanced caching strategies - Security scanning with Trivy and image signing with Cosign - SBOM generation in multiple formats with validation - Verbose logging and dry-run modes for debugging - Platform-specific build args and fallback mechanisms Enhanced all Docker actions: - docker-build: Core buildx features and multi-arch support - docker-publish-gh: GitHub Packages with security features - docker-publish-hub: Docker Hub with scanning and signing - docker-publish: Orchestrator with unified configuration Updated documentation across all modified actions. * fix: resolve documentation generation placeholder issue Fixed Makefile and package.json to properly replace placeholder tokens in generated documentation, ensuring all README files show correct repository paths instead of ***PROJECT***@***VERSION***. * chore: simplify github token validation * chore(lint): optional yamlfmt, config and fixes * feat: use relative `uses` names * feat: comprehensive testing infrastructure and Python validation system - Migrate from tests/ to _tests/ directory structure with ShellSpec framework - Add comprehensive validation system with Python-based input validation - Implement dual testing approach (ShellSpec + pytest) for complete coverage - Add modern Python tooling (uv, ruff, pytest-cov) and dependencies - Create centralized validation rules with automatic generation system - Update project configuration and build system for new architecture - Enhance documentation to reflect current testing capabilities This establishes a robust foundation for action validation and testing with extensive coverage across all GitHub Actions in the repository. * chore: remove Dockerfile for now * chore: code review fixes * feat: comprehensive GitHub Actions restructuring and tooling improvements This commit represents a major restructuring of the GitHub Actions monorepo with improved tooling, testing infrastructure, and comprehensive PR #186 review implementation. ## Major Changes ### 🔧 Development Tooling & Configuration - **Shellcheck integration**: Exclude shellspec test files from linting - Updated .pre-commit-config.yaml to exclude _tests/*.sh from shellcheck/shfmt - Modified Makefile shellcheck pattern to skip shellspec files - Updated CLAUDE.md documentation with proper exclusion syntax - **Testing infrastructure**: Enhanced Python validation framework - Fixed nested if statements and boolean parameter issues in validation.py - Improved code quality with explicit keyword arguments - All pre-commit hooks now passing ### 🏗️ Project Structure & Documentation - **Added Serena AI integration** with comprehensive project memories: - Project overview, structure, and technical stack documentation - Code style conventions and completion requirements - Comprehensive PR #186 review analysis and implementation tracking - **Enhanced configuration**: Updated .gitignore, .yamlfmt.yml, pyproject.toml - **Improved testing**: Added integration workflows and enhanced test specs ### 🚀 GitHub Actions Improvements (30+ actions updated) - **Centralized validation**: Updated 41 validation rule files - **Enhanced actions**: Improvements across all action categories: - Setup actions (node-setup, version detectors) - Utility actions (version-file-parser, version-validator) - Linting actions (biome, eslint, terraform-lint-fix major refactor) - Build/publish actions (docker-build, npm-publish, csharp-*) - Repository management actions ### 📝 Documentation Updates - **README consistency**: Updated version references across action READMEs - **Enhanced documentation**: Improved action descriptions and usage examples - **CLAUDE.md**: Updated with current tooling and best practices ## Technical Improvements - **Security enhancements**: Input validation and sanitization improvements - **Performance optimizations**: Streamlined action logic and dependencies - **Cross-platform compatibility**: Better Windows/macOS/Linux support - **Error handling**: Improved error reporting and user feedback ## Files Changed - 100 files changed - 13 new Serena memory files documenting project state - 41 validation rules updated for consistency - 30+ GitHub Actions and READMEs improved - Core tooling configuration enhanced * feat: comprehensive GitHub Actions improvements and PR review fixes Major Infrastructure Improvements: - Add comprehensive testing framework with 17+ ShellSpec validation tests - Implement Docker-based testing tools with automated test runner - Add CodeRabbit configuration for automated code reviews - Restructure documentation and memory management system - Update validation rules for 25+ actions with enhanced input validation - Modernize CI/CD workflows and testing infrastructure Critical PR Review Fixes (All Issues Resolved): - Fix double caching in node-setup (eliminate redundant cache operations) - Optimize shell pipeline in version-file-parser (single awk vs complex pipeline) - Fix GitHub expression interpolation in prettier-check cache keys - Resolve terraform command order issue (validation after setup) - Add missing flake8-sarif dependency for Python SARIF output - Fix environment variable scope in pr-lint (export to GITHUB_ENV) Performance & Reliability: - Eliminate duplicate cache operations saving CI time - Improve shell script efficiency with optimized parsing - Fix command execution dependencies preventing runtime failures - Ensure proper dependency installation for all linting tools - Resolve workflow conditional logic issues Security & Quality: - All input validation rules updated with latest security patterns - Cross-platform compatibility improvements maintained - Comprehensive error handling and retry logic preserved - Modern development tooling and best practices adopted This commit addresses 100% of actionable feedback from PR review analysis, implements comprehensive testing infrastructure, and maintains high code quality standards across all 41 GitHub Actions. * feat: enhance expression handling and version parsing - Fix node-setup force-version expression logic for proper empty string handling - Improve version-file-parser with secure regex validation and enhanced Python detection - Add CodeRabbit configuration for CalVer versioning and README review guidance * feat(validate-inputs): implement modular validation system - Add modular validator architecture with specialized validators - Implement base validator classes for different input types - Add validators: boolean, docker, file, network, numeric, security, token, version - Add convention mapper for automatic input validation - Add comprehensive documentation for the validation system - Implement PCRE regex support and injection protection * feat(validate-inputs): add validation rules for all actions - Add YAML validation rules for 42 GitHub Actions - Auto-generated rules with convention mappings - Include metadata for validation coverage and quality indicators - Mark rules as auto-generated to prevent manual edits * test(validate-inputs): add comprehensive test suite for validators - Add unit tests for all validator modules - Add integration tests for the validation system - Add fixtures for version test data - Test coverage for boolean, docker, file, network, numeric, security, token, and version validators - Add tests for convention mapper and registry * feat(tools): add validation scripts and utilities - Add update-validators.py script for auto-generating rules - Add benchmark-validator.py for performance testing - Add debug-validator.py for troubleshooting - Add generate-tests.py for test generation - Add check-rules-not-manually-edited.sh for CI validation - Add fix-local-action-refs.py tool for fixing action references * feat(actions): add CustomValidator.py files for specialized validation - Add custom validators for actions requiring special validation logic - Implement validators for docker, go, node, npm, php, python, terraform actions - Add specialized validation for compress-images, common-cache, common-file-check - Implement version detection validators with language-specific logic - Add validation for build arguments, architectures, and version formats * test: update ShellSpec test framework for Python validation - Update all validation.spec.sh files to use Python validator - Add shared validation_core.py for common test utilities - Remove obsolete bash validation helpers - Update test output expectations for Python validator format - Add codeql-analysis test suite - Refactor framework utilities for Python integration - Remove deprecated test files * feat(actions): update action.yml files to use validate-inputs - Replace inline bash validation with validate-inputs action - Standardize validation across all 42 actions - Add new codeql-analysis action - Update action metadata and branding - Add validation step as first step in composite actions - Maintain backward compatibility with existing inputs/outputs * ci: update GitHub workflows for enhanced security and testing - Add new codeql-new.yml workflow - Update security scanning workflows - Enhance dependency review configuration - Update test-actions workflow for new validation system - Improve workflow permissions and security settings - Update action versions to latest SHA-pinned releases * build: update build configuration and dependencies - Update Makefile with new validation targets - Add Python dependencies in pyproject.toml - Update npm dependencies and scripts - Enhance Docker testing tools configuration - Add targets for validator updates and local ref fixes - Configure uv for Python package management * chore: update linting and documentation configuration - Update EditorConfig settings for consistent formatting - Enhance pre-commit hooks configuration - Update prettier and yamllint ignore patterns - Update gitleaks security scanning rules - Update CodeRabbit review configuration - Update CLAUDE.md with latest project standards and rules * docs: update Serena memory files and project metadata - Remove obsolete PR-186 memory files - Update project overview with current architecture - Update project structure documentation - Add quality standards and communication guidelines - Add modular validator architecture documentation - Add shellspec testing framework documentation - Update project.yml with latest configuration * feat: moved rules.yml to same folder as action, fixes * fix(validators): correct token patterns and fix validator bugs - Fix GitHub classic PAT pattern: ghp_ + 36 chars = 40 total - Fix GitHub fine-grained PAT pattern: github_pat_ + 71 chars = 82 total - Initialize result variable in convention_mapper to prevent UnboundLocalError - Fix empty URL validation in network validator to return error - Add GitHub expression check to docker architectures validator - Update docker-build CustomValidator parallel-builds max to 16 * test(validators): fix test fixtures and expectations - Fix token lengths in test data: github_pat 71 chars, ghp/gho 36 chars - Update integration tests with correct token lengths - Fix file validator test to expect absolute paths rejected for security - Rename TestGenerator import to avoid pytest collection warning - Update custom validator tests with correct input names - Change docker-build tests: platforms->architectures, tags->tag - Update docker-publish tests to match new registry enum validation * test(shellspec): fix token lengths in test helpers and specs - Fix default token lengths in spec_helper.sh to use correct 40-char format - Update csharp-publish default tokens in 4 locations - Update codeql-analysis default tokens in 2 locations - Fix codeql-analysis test tokens to correct lengths (40 and 82 chars) - Fix npm-publish fine-grained token test to use 82-char format * feat(actions): add permissions documentation and environment variable usage - Add permissions comments to all action.yml files documenting required GitHub permissions - Convert direct input usage to environment variables in shell steps for security - Add validation steps with proper error handling - Update input descriptions and add security notes where applicable - Ensure all actions follow consistent patterns for input validation * chore(workflows): update GitHub Actions workflow versions - Update workflow action versions to latest - Improve workflow consistency and maintainability * docs(security): add comprehensive security policy - Document security features and best practices - Add vulnerability reporting process - Include audit history and security testing information * docs(memory): add GitHub workflow reference documentation - Add GitHub Actions workflow commands reference - Add GitHub workflow expressions guide - Add secure workflow usage patterns and best practices * chore: token optimization, code style conventions * chore: cr fixes * fix: trivy reported Dockerfile problems * fix(security): more security fixes * chore: dockerfile and make targets for publishing * fix(ci): add creds to test-actions workflow * fix: security fix and checkout step to codeql-new * chore: test fixes * fix(security): codeql detected issues * chore: code review fixes, ReDos protection * style: apply MegaLinter fixes * fix(ci): missing packages read permission * fix(ci): add missing working directory setting * chore: linting, add validation-regex to use regex_pattern * chore: code review fixes * chore(deps): update actions * fix(security): codeql fixes * chore(cr): apply cr comments * chore: improve POSIX compatibility * chore(cr): apply cr comments * fix: codeql warning in Dockerfile, build failures * chore(cr): apply cr comments * fix: docker-testing-tools/Dockerfile * chore(cr): apply cr comments * fix(docker): update testing-tools image for GitHub Actions compatibility * chore(cr): apply cr comments * feat: add more tests, fix issues * chore: fix codeql issues, update actions * chore(cr): apply cr comments * fix: integration tests * chore: deduplication and fixes * style: apply MegaLinter fixes * chore(cr): apply cr comments * feat: dry-run mode for generate-tests * fix(ci): kcov installation * chore(cr): apply cr comments * chore(cr): apply cr comments * chore(cr): apply cr comments * chore(cr): apply cr comments, simplify action testing, use uv * fix: run-tests.sh action counting * chore(cr): apply cr comments * chore(cr): apply cr comments
392 lines
13 KiB
Python
392 lines
13 KiB
Python
"""Network-related validators for URLs, emails, and other network inputs."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import re
|
|
|
|
from .base import BaseValidator
|
|
|
|
|
|
class NetworkValidator(BaseValidator):
|
|
"""Validator for network-related inputs like URLs, emails, scopes."""
|
|
|
|
def validate_inputs(self, inputs: dict[str, str]) -> bool:
|
|
"""Validate network-related inputs."""
|
|
valid = True
|
|
|
|
for input_name, value in inputs.items():
|
|
if "email" in input_name:
|
|
valid &= self.validate_email(value, input_name)
|
|
elif "url" in input_name or ("registry" in input_name and "url" in input_name):
|
|
valid &= self.validate_url(value, input_name)
|
|
elif "scope" in input_name:
|
|
valid &= self.validate_scope(value, input_name)
|
|
elif "username" in input_name or "user" in input_name:
|
|
valid &= self.validate_username(value)
|
|
|
|
return valid
|
|
|
|
def get_required_inputs(self) -> list[str]:
|
|
"""Network validators typically don't define required inputs."""
|
|
return []
|
|
|
|
def get_validation_rules(self) -> dict:
|
|
"""Return network validation rules."""
|
|
return {
|
|
"email": "Valid email format",
|
|
"url": "Valid URL starting with http:// or https://",
|
|
"scope": "NPM scope format (@organization)",
|
|
"username": "Valid username without injection patterns",
|
|
}
|
|
|
|
def validate_email(self, email: str, name: str = "email") -> bool:
|
|
"""Validate email format.
|
|
|
|
Args:
|
|
email: The email address to validate
|
|
name: The input name for error messages
|
|
|
|
Returns:
|
|
True if valid, False otherwise
|
|
"""
|
|
if not email or email.strip() == "":
|
|
return True # Email is often optional
|
|
|
|
# Allow GitHub Actions expressions
|
|
if self.is_github_expression(email):
|
|
return True
|
|
|
|
# Check for spaces
|
|
if " " in email:
|
|
self.add_error(f'Invalid {name}: "{email}". Spaces not allowed in email')
|
|
return False
|
|
|
|
# Check @ symbol
|
|
at_count = email.count("@")
|
|
if at_count != 1:
|
|
self.add_error(
|
|
f'Invalid {name}: "{email}". Expected exactly one @ symbol, found {at_count}',
|
|
)
|
|
return False
|
|
|
|
local, domain = email.split("@")
|
|
|
|
# Validate local part
|
|
if not local:
|
|
self.add_error(f'Invalid {name}: "{email}". Missing local part before @')
|
|
return False
|
|
|
|
# Validate domain
|
|
if not domain:
|
|
self.add_error(f'Invalid {name}: "{email}". Missing domain after @')
|
|
return False
|
|
|
|
# Domain must have at least one dot
|
|
if "." not in domain:
|
|
self.add_error(f'Invalid {name}: "{email}". Domain must contain a dot')
|
|
return False
|
|
|
|
# Check for dots at start/end of domain
|
|
if domain.startswith(".") or domain.endswith("."):
|
|
self.add_error(f'Invalid {name}: "{email}". Domain cannot start/end with dot')
|
|
return False
|
|
|
|
# Check for consecutive dots
|
|
if ".." in email:
|
|
self.add_error(f'Invalid {name}: "{email}". Cannot contain consecutive dots')
|
|
return False
|
|
|
|
# Basic character validation
|
|
email_pattern = r"^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}$"
|
|
if not re.match(email_pattern, email):
|
|
self.add_error(f'Invalid {name}: "{email}". Invalid email format')
|
|
return False
|
|
|
|
return True
|
|
|
|
def validate_url(self, value: str, name: str = "url") -> bool:
|
|
"""Validate URL format.
|
|
|
|
Args:
|
|
value: The URL to validate
|
|
name: The input name for error messages
|
|
|
|
Returns:
|
|
True if valid, False otherwise
|
|
"""
|
|
if not value or value.strip() == "":
|
|
self.add_error(f"{name} cannot be empty")
|
|
return False
|
|
|
|
# Allow GitHub Actions expressions
|
|
if self.is_github_expression(value):
|
|
return True
|
|
|
|
# Must start with http:// or https://
|
|
if not (value.startswith(("http://", "https://"))):
|
|
self.add_error(f'Invalid {name}: "{value}". Must start with http:// or https://')
|
|
return False
|
|
|
|
# Check for obvious injection patterns
|
|
injection_patterns = [";", "&", "|", "`", "$(", "${"]
|
|
for pattern in injection_patterns:
|
|
if pattern in value:
|
|
self.add_error(f'Potential security injection in {name}: contains "{pattern}"')
|
|
return False
|
|
|
|
# Basic URL validation (with optional port)
|
|
url_pattern = r"^https?://[\w.-]+(?:\.[a-zA-Z]{2,})?(?::\d{1,5})?(?:[/?#][^\s]*)?$"
|
|
if not re.match(url_pattern, value):
|
|
self.add_error(f'Invalid {name}: "{value}". Invalid URL format')
|
|
return False
|
|
|
|
return True
|
|
|
|
def validate_scope(self, value: str, name: str = "scope") -> bool:
|
|
"""Validate scope format (e.g., NPM scope).
|
|
|
|
Args:
|
|
value: The scope to validate
|
|
name: The input name for error messages
|
|
|
|
Returns:
|
|
True if valid, False otherwise
|
|
"""
|
|
if not value or value.strip() == "":
|
|
return True # Scope is optional
|
|
|
|
# NPM scope should start with @
|
|
if not value.startswith("@"):
|
|
self.add_error(f'Invalid {name}: "{value}". Must start with @')
|
|
return False
|
|
|
|
# Remove @ and validate the rest
|
|
scope_name = value[1:]
|
|
|
|
if not scope_name:
|
|
self.add_error(f'Invalid {name}: "{value}". Scope name cannot be empty')
|
|
return False
|
|
|
|
# Must start with lowercase letter
|
|
if not scope_name[0].islower():
|
|
self.add_error(
|
|
f'Invalid {name}: "{value}". Scope name must start with lowercase letter',
|
|
)
|
|
return False
|
|
|
|
# Check for valid scope characters
|
|
if not re.match(r"^[a-z][a-z0-9._~-]*$", scope_name):
|
|
self.add_error(
|
|
f'Invalid {name}: "{value}". '
|
|
"Scope can only contain lowercase letters, numbers, dots, "
|
|
"underscores, tildes, and hyphens",
|
|
)
|
|
return False
|
|
|
|
# Check for security patterns
|
|
return self.validate_security_patterns(value, name)
|
|
|
|
def validate_username(self, username: str, name: str = "username") -> bool:
|
|
"""Validate username with injection protection.
|
|
|
|
Args:
|
|
username: The username to validate
|
|
name: The input name for error messages
|
|
|
|
Returns:
|
|
True if valid, False otherwise
|
|
"""
|
|
if not username or username.strip() == "":
|
|
return True # Username is often optional
|
|
|
|
# Check for command injection patterns
|
|
injection_patterns = [";", "&&", "||", "|", "`", "$(", "${"]
|
|
for pattern in injection_patterns:
|
|
if pattern in username:
|
|
self.add_error(
|
|
f'Invalid {name}: "{username}". Command injection patterns not allowed',
|
|
)
|
|
return False
|
|
|
|
# Check length (GitHub username limit)
|
|
if len(username) > 39:
|
|
self.add_error(
|
|
f"{name.capitalize()} too long: {len(username)} characters. "
|
|
"GitHub usernames max 39 characters",
|
|
)
|
|
return False
|
|
|
|
# GitHub username validation (also allow underscores)
|
|
if not re.match(r"^[a-zA-Z0-9](?:[a-zA-Z0-9_-]*[a-zA-Z0-9])?$", username):
|
|
self.add_error(
|
|
f'Invalid {name}: "{username}". '
|
|
"Must start and end with alphanumeric, can contain hyphens and underscores",
|
|
)
|
|
return False
|
|
|
|
return True
|
|
|
|
def validate_registry_url(self, value: str, name: str = "registry-url") -> bool:
|
|
"""Validate registry URL format.
|
|
|
|
Args:
|
|
value: The registry URL to validate
|
|
name: The input name for error messages
|
|
|
|
Returns:
|
|
True if valid, False otherwise
|
|
"""
|
|
if not value or value.strip() == "":
|
|
return True # Registry URL is often optional
|
|
|
|
# Common registry URLs
|
|
known_registries = [
|
|
"https://registry.npmjs.org/",
|
|
"https://npm.pkg.github.com/",
|
|
"https://registry.yarnpkg.com/",
|
|
"https://pypi.org/simple/",
|
|
"https://test.pypi.org/simple/",
|
|
"https://rubygems.org/",
|
|
"https://nuget.org/api/v2/",
|
|
]
|
|
|
|
# Check if it's a known registry
|
|
for registry in known_registries:
|
|
if value.startswith(registry):
|
|
return True
|
|
|
|
# Otherwise validate as general URL
|
|
return self.validate_url(value, name)
|
|
|
|
def validate_repository_url(self, value: str, name: str = "repository-url") -> bool:
|
|
"""Validate repository URL format.
|
|
|
|
Args:
|
|
value: The repository URL to validate
|
|
name: The input name for error messages
|
|
|
|
Returns:
|
|
True if valid, False otherwise
|
|
"""
|
|
if not value or value.strip() == "":
|
|
return True # Repository URL is often optional
|
|
|
|
# Common repository URL patterns
|
|
repo_patterns = [
|
|
r"^https://github\.com/[a-zA-Z0-9-]+/[a-zA-Z0-9._-]+(?:\.git)?$",
|
|
r"^https://gitlab\.com/[a-zA-Z0-9-]+/[a-zA-Z0-9._-]+(?:\.git)?$",
|
|
r"^https://bitbucket\.org/[a-zA-Z0-9-]+/[a-zA-Z0-9._-]+(?:\.git)?$",
|
|
]
|
|
|
|
for pattern in repo_patterns:
|
|
if re.match(pattern, value):
|
|
return True
|
|
|
|
# Otherwise validate as general URL
|
|
return self.validate_url(value, name)
|
|
|
|
def validate_hostname(self, hostname: str, name: str = "hostname") -> bool:
|
|
"""Validate hostname format.
|
|
|
|
Args:
|
|
hostname: The hostname to validate
|
|
name: The input name for error messages
|
|
|
|
Returns:
|
|
True if valid, False otherwise
|
|
"""
|
|
if not hostname or hostname.strip() == "":
|
|
return True # Hostname is often optional
|
|
|
|
# Check length (max 253 characters)
|
|
if len(hostname) > 253:
|
|
self.add_error(f'Invalid {name}: "{hostname}". Hostname too long (max 253 characters)')
|
|
return False
|
|
|
|
# Check for valid hostname pattern
|
|
# Each label can be 1-63 chars, alphanumeric and hyphens, not starting/ending with hyphen
|
|
hostname_pattern = r"^(?!-)(?:[a-zA-Z0-9-]{1,63}(?<!-)\.)*[a-zA-Z0-9-]{1,63}(?<!-)$"
|
|
|
|
if re.match(hostname_pattern, hostname):
|
|
return True
|
|
|
|
# Also allow localhost and IPv6 loopback
|
|
if hostname in ["localhost", "::1", "::"]:
|
|
return True
|
|
|
|
# Also check if it's an IP address (which can be a valid hostname)
|
|
if self.validate_ip_address(hostname):
|
|
return True
|
|
|
|
self.add_error(f'Invalid {name}: "{hostname}". Must be a valid hostname')
|
|
return False
|
|
|
|
def validate_ip_address(self, ip: str, name: str = "ip_address") -> bool:
|
|
"""Validate IP address (IPv4 or IPv6).
|
|
|
|
Args:
|
|
ip: The IP address to validate
|
|
name: The input name for error messages
|
|
|
|
Returns:
|
|
True if valid, False otherwise
|
|
"""
|
|
if not ip or ip.strip() == "":
|
|
return True # IP address is often optional
|
|
|
|
# IPv4 pattern
|
|
ipv4_pattern = (
|
|
r"^(?:(?:25[0-5]|2[0-4]\d|[01]?\d\d?)\.){3}"
|
|
r"(?:25[0-5]|2[0-4]\d|[01]?\d\d?)$"
|
|
)
|
|
if re.match(ipv4_pattern, ip):
|
|
return True
|
|
|
|
# Simplified IPv6 pattern (full validation is complex)
|
|
# This covers most common cases: full form, loopback (::1), and unspecified (::)
|
|
ipv6_pattern = r"^(?:(?:[0-9a-fA-F]{1,4}:){7}[0-9a-fA-F]{1,4}|::1|::)$"
|
|
if re.match(ipv6_pattern, ip):
|
|
return True
|
|
|
|
# Allow compressed IPv6
|
|
if "::" in ip:
|
|
# Very basic check for compressed IPv6
|
|
parts = ip.split("::")
|
|
if len(parts) == 2:
|
|
# Check if parts look like hex
|
|
for part in parts:
|
|
if part and not all(c in "0123456789abcdefABCDEF:" for c in part):
|
|
self.add_error(f'Invalid {name}: "{ip}". Not a valid IP address')
|
|
return False
|
|
return True
|
|
|
|
self.add_error(f'Invalid {name}: "{ip}". Must be a valid IPv4 or IPv6 address')
|
|
return False
|
|
|
|
def validate_port(self, port: str, name: str = "port") -> bool:
|
|
"""Validate port number.
|
|
|
|
Args:
|
|
port: The port number to validate (as string)
|
|
name: The input name for error messages
|
|
|
|
Returns:
|
|
True if valid, False otherwise
|
|
"""
|
|
if not port or port.strip() == "":
|
|
return True # Port is often optional
|
|
|
|
# Check if it's a number
|
|
try:
|
|
port_num = int(port)
|
|
except ValueError:
|
|
self.add_error(f'Invalid {name}: "{port}". Port must be a number')
|
|
return False
|
|
|
|
# Check valid range (1-65535)
|
|
if port_num < 1 or port_num > 65535:
|
|
self.add_error(f"Invalid {name}: {port}. Port must be between 1 and 65535")
|
|
return False
|
|
|
|
return True
|