Files
actions/validate-inputs/tests/test_codeql.py
Ismo Vuorinen 78fdad69e5 feat: fixes, tweaks, new actions, linting (#186)
* feat: fixes, tweaks, new actions, linting
* fix: improve docker publish loops and dotnet parsing (#193)
* fix: harden action scripts and version checks (#191)
* refactor: major repository restructuring and security enhancements

Add comprehensive development infrastructure:
- Add Makefile with automated documentation generation, formatting, and linting tasks
- Add TODO.md tracking self-containment progress and repository improvements
- Add .nvmrc for consistent Node.js version management
- Create python-version-detect-v2 action for enhanced Python detection

Enhance all GitHub Actions with standardized patterns:
- Add consistent token handling across 27 actions using standardized input patterns
- Implement bash error handling (set -euo pipefail) in all shell steps
- Add comprehensive input validation for path traversal and command injection protection
- Standardize checkout token authentication to prevent rate limiting
- Remove relative action dependencies to ensure external usability

Rewrite security workflow for PR-focused analysis:
- Transform security-suite.yml to PR-only security analysis workflow
- Remove scheduled runs, repository issue management, and Slack notifications
- Implement smart comment generation showing only sections with content
- Add GitHub Actions permission diff analysis and new action detection
- Integrate OWASP, Semgrep, and TruffleHog for comprehensive PR security scanning

Improve version detection and dependency management:
- Simplify version detection actions to use inline logic instead of shared utilities
- Fix Makefile version detection fallback to properly return 'main' when version not found
- Update all external action references to use SHA-pinned versions
- Remove deprecated run.sh in favor of Makefile automation

Update documentation and project standards:
- Enhance CLAUDE.md with self-containment requirements and linting standards
- Update README.md with improved action descriptions and usage examples
- Standardize code formatting with updated .editorconfig and .prettierrc.yml
- Improve GitHub templates for issues and security reporting

This refactoring ensures all 40 actions are fully self-contained and can be used independently when
referenced as ivuorinen/actions/action-name@main, addressing the critical requirement for external
usability while maintaining comprehensive security analysis and development automation.

* feat: add automated action catalog generation system

- Create generate_listing.cjs script for comprehensive action catalog
- Add package.json with development tooling and npm scripts
- Implement automated README.md catalog section with --update flag
- Generate markdown reference-style links for all 40 actions
- Add categorized tables with features, language support matrices
- Replace static reference links with auto-generated dynamic links
- Enable complete automation of action documentation maintenance

* feat: enhance actions with improved documentation and functionality

- Add comprehensive README files for 12 actions with usage examples
- Implement new utility actions (go-version-detect, dotnet-version-detect)
- Enhance node-setup with extensive configuration options
- Improve error handling and validation across all actions
- Update package.json scripts for better development workflow
- Expand TODO.md with detailed roadmap and improvement plans
- Standardize action structure with consistent inputs/outputs

* feat: add comprehensive output handling across all actions

- Add standardized outputs to 15 actions that previously had none
- Implement consistent snake_case naming convention for all outputs
- Add build status and test results outputs to build actions
- Add files changed and status outputs to lint/fix actions
- Add test execution metrics to php-tests action
- Add stale/closed counts to stale action
- Add release URLs and IDs to github-release action
- Update documentation with output specifications
- Mark comprehensive output handling task as complete in TODO.md

* feat: implement shared cache strategy across all actions

- Add caching to 10 actions that previously had none (Node.js, .NET, Python, Go)
- Standardize 4 existing actions to use common-cache instead of direct actions/cache
- Implement consistent cache-hit optimization to skip installations when cache available
- Add language-specific cache configurations with appropriate key files
- Create unified caching approach using ivuorinen/actions/common-cache@main
- Fix YAML syntax error in php-composer action paths parameter
- Update TODO.md to mark shared cache strategy as complete

* feat: implement comprehensive retry logic for network operations

- Create new common-retry action for standardized retry patterns with configurable strategies
- Add retry logic to 9 actions missing network retry capabilities
- Implement exponential backoff, custom timeouts, and flexible error handling
- Add max-retries input parameter to all network-dependent actions (Node.js, .NET, Python, Go)
- Standardize existing retry implementations to use common-retry utility
- Update action catalog to include new common-retry action (41 total actions)
- Update documentation with retry configuration examples and parameters
- Mark retry logic implementation as complete in TODO.md roadmap

* feat: enhance Node.js support with Corepack and Bun

- Add Corepack support for automatic package manager version management
- Add Bun package manager support across all Node.js actions
- Improve Yarn Berry/PnP support with .yarnrc.yml detection
- Add Node.js feature detection (ESM, TypeScript, frameworks)
- Update package manager detection priority and lockfile support
- Enhance caching with package-manager-specific keys
- Update eslint, prettier, and biome actions for multi-package-manager support

* fix: resolve critical runtime issues across multiple actions

- Fix token validation by removing ineffective literal string comparisons
- Add missing @microsoft/eslint-formatter-sarif dependency for SARIF output
- Fix Bash variable syntax errors in username and changelog length checks
- Update Dockerfile version regex to handle tags with suffixes (e.g., -alpine)
- Simplify version selection logic with single grep command
- Fix command execution in retry action with proper bash -c wrapper
- Correct step output references using .outcome instead of .outputs.outcome
- Add missing step IDs for version detection actions
- Include go.mod in cache key files for accurate invalidation
- Require minor version in all version regex patterns
- Improve Bun installation security by verifying script before execution
- Replace bc with sort -V for portable PHP version comparison
- Remove non-existent pre-commit output references

These fixes ensure proper runtime behavior, improved security, and better
cross-platform compatibility across all affected actions.

* fix: resolve critical runtime and security issues across actions

- Fix biome-fix files_changed calculation using git diff instead of git status delta
- Fix compress-images output description and add absolute path validation
- Remove csharp-publish token default and fix token fallback in push commands
- Add @microsoft/eslint-formatter-sarif to all package managers in eslint-check
- Fix eslint-check command syntax by using variable assignment
- Improve node-setup Bun installation security and remove invalid frozen-lockfile flag
- Fix pre-commit token validation by removing ineffective literal comparison
- Fix prettier-fix token comparison and expand regex for all GitHub token types
- Add version-file-parser regex validation safety and fix csproj wildcard handling

These fixes address security vulnerabilities, runtime errors, and functional issues
to ensure reliable operation across all affected GitHub Actions.

* feat: enhance Docker actions with advanced multi-architecture support

Major enhancement to Docker build and publish actions with comprehensive
multi-architecture capabilities and enterprise-grade features.

Added features:
- Advanced buildx configuration (version control, cache modes, build contexts)
- Auto-detect platforms for dynamic architecture discovery
- Performance optimizations with enhanced caching strategies
- Security scanning with Trivy and image signing with Cosign
- SBOM generation in multiple formats with validation
- Verbose logging and dry-run modes for debugging
- Platform-specific build args and fallback mechanisms

Enhanced all Docker actions:
- docker-build: Core buildx features and multi-arch support
- docker-publish-gh: GitHub Packages with security features
- docker-publish-hub: Docker Hub with scanning and signing
- docker-publish: Orchestrator with unified configuration

Updated documentation across all modified actions.

* fix: resolve documentation generation placeholder issue

Fixed Makefile and package.json to properly replace placeholder tokens in generated documentation, ensuring all README files show correct repository paths instead of ***PROJECT***@***VERSION***.

* chore: simplify github token validation
* chore(lint): optional yamlfmt, config and fixes
* feat: use relative `uses` names

* feat: comprehensive testing infrastructure and Python validation system

- Migrate from tests/ to _tests/ directory structure with ShellSpec framework
- Add comprehensive validation system with Python-based input validation
- Implement dual testing approach (ShellSpec + pytest) for complete coverage
- Add modern Python tooling (uv, ruff, pytest-cov) and dependencies
- Create centralized validation rules with automatic generation system
- Update project configuration and build system for new architecture
- Enhance documentation to reflect current testing capabilities

This establishes a robust foundation for action validation and testing
with extensive coverage across all GitHub Actions in the repository.

* chore: remove Dockerfile for now
* chore: code review fixes

* feat: comprehensive GitHub Actions restructuring and tooling improvements

This commit represents a major restructuring of the GitHub Actions monorepo
with improved tooling, testing infrastructure, and comprehensive PR #186
review implementation.

## Major Changes

### 🔧 Development Tooling & Configuration
- **Shellcheck integration**: Exclude shellspec test files from linting
  - Updated .pre-commit-config.yaml to exclude _tests/*.sh from shellcheck/shfmt
  - Modified Makefile shellcheck pattern to skip shellspec files
  - Updated CLAUDE.md documentation with proper exclusion syntax
- **Testing infrastructure**: Enhanced Python validation framework
  - Fixed nested if statements and boolean parameter issues in validation.py
  - Improved code quality with explicit keyword arguments
  - All pre-commit hooks now passing

### 🏗️ Project Structure & Documentation
- **Added Serena AI integration** with comprehensive project memories:
  - Project overview, structure, and technical stack documentation
  - Code style conventions and completion requirements
  - Comprehensive PR #186 review analysis and implementation tracking
- **Enhanced configuration**: Updated .gitignore, .yamlfmt.yml, pyproject.toml
- **Improved testing**: Added integration workflows and enhanced test specs

### 🚀 GitHub Actions Improvements (30+ actions updated)
- **Centralized validation**: Updated 41 validation rule files
- **Enhanced actions**: Improvements across all action categories:
  - Setup actions (node-setup, version detectors)
  - Utility actions (version-file-parser, version-validator)
  - Linting actions (biome, eslint, terraform-lint-fix major refactor)
  - Build/publish actions (docker-build, npm-publish, csharp-*)
  - Repository management actions

### 📝 Documentation Updates
- **README consistency**: Updated version references across action READMEs
- **Enhanced documentation**: Improved action descriptions and usage examples
- **CLAUDE.md**: Updated with current tooling and best practices

## Technical Improvements
- **Security enhancements**: Input validation and sanitization improvements
- **Performance optimizations**: Streamlined action logic and dependencies
- **Cross-platform compatibility**: Better Windows/macOS/Linux support
- **Error handling**: Improved error reporting and user feedback

## Files Changed
- 100 files changed
- 13 new Serena memory files documenting project state
- 41 validation rules updated for consistency
- 30+ GitHub Actions and READMEs improved
- Core tooling configuration enhanced

* feat: comprehensive GitHub Actions improvements and PR review fixes

Major Infrastructure Improvements:
- Add comprehensive testing framework with 17+ ShellSpec validation tests
- Implement Docker-based testing tools with automated test runner
- Add CodeRabbit configuration for automated code reviews
- Restructure documentation and memory management system
- Update validation rules for 25+ actions with enhanced input validation
- Modernize CI/CD workflows and testing infrastructure

Critical PR Review Fixes (All Issues Resolved):
- Fix double caching in node-setup (eliminate redundant cache operations)
- Optimize shell pipeline in version-file-parser (single awk vs complex pipeline)
- Fix GitHub expression interpolation in prettier-check cache keys
- Resolve terraform command order issue (validation after setup)
- Add missing flake8-sarif dependency for Python SARIF output
- Fix environment variable scope in pr-lint (export to GITHUB_ENV)

Performance & Reliability:
- Eliminate duplicate cache operations saving CI time
- Improve shell script efficiency with optimized parsing
- Fix command execution dependencies preventing runtime failures
- Ensure proper dependency installation for all linting tools
- Resolve workflow conditional logic issues

Security & Quality:
- All input validation rules updated with latest security patterns
- Cross-platform compatibility improvements maintained
- Comprehensive error handling and retry logic preserved
- Modern development tooling and best practices adopted

This commit addresses 100% of actionable feedback from PR review analysis,
implements comprehensive testing infrastructure, and maintains high code
quality standards across all 41 GitHub Actions.

* feat: enhance expression handling and version parsing

- Fix node-setup force-version expression logic for proper empty string handling
- Improve version-file-parser with secure regex validation and enhanced Python detection
- Add CodeRabbit configuration for CalVer versioning and README review guidance

* feat(validate-inputs): implement modular validation system

- Add modular validator architecture with specialized validators
- Implement base validator classes for different input types
- Add validators: boolean, docker, file, network, numeric, security, token, version
- Add convention mapper for automatic input validation
- Add comprehensive documentation for the validation system
- Implement PCRE regex support and injection protection

* feat(validate-inputs): add validation rules for all actions

- Add YAML validation rules for 42 GitHub Actions
- Auto-generated rules with convention mappings
- Include metadata for validation coverage and quality indicators
- Mark rules as auto-generated to prevent manual edits

* test(validate-inputs): add comprehensive test suite for validators

- Add unit tests for all validator modules
- Add integration tests for the validation system
- Add fixtures for version test data
- Test coverage for boolean, docker, file, network, numeric, security, token, and version validators
- Add tests for convention mapper and registry

* feat(tools): add validation scripts and utilities

- Add update-validators.py script for auto-generating rules
- Add benchmark-validator.py for performance testing
- Add debug-validator.py for troubleshooting
- Add generate-tests.py for test generation
- Add check-rules-not-manually-edited.sh for CI validation
- Add fix-local-action-refs.py tool for fixing action references

* feat(actions): add CustomValidator.py files for specialized validation

- Add custom validators for actions requiring special validation logic
- Implement validators for docker, go, node, npm, php, python, terraform actions
- Add specialized validation for compress-images, common-cache, common-file-check
- Implement version detection validators with language-specific logic
- Add validation for build arguments, architectures, and version formats

* test: update ShellSpec test framework for Python validation

- Update all validation.spec.sh files to use Python validator
- Add shared validation_core.py for common test utilities
- Remove obsolete bash validation helpers
- Update test output expectations for Python validator format
- Add codeql-analysis test suite
- Refactor framework utilities for Python integration
- Remove deprecated test files

* feat(actions): update action.yml files to use validate-inputs

- Replace inline bash validation with validate-inputs action
- Standardize validation across all 42 actions
- Add new codeql-analysis action
- Update action metadata and branding
- Add validation step as first step in composite actions
- Maintain backward compatibility with existing inputs/outputs

* ci: update GitHub workflows for enhanced security and testing

- Add new codeql-new.yml workflow
- Update security scanning workflows
- Enhance dependency review configuration
- Update test-actions workflow for new validation system
- Improve workflow permissions and security settings
- Update action versions to latest SHA-pinned releases

* build: update build configuration and dependencies

- Update Makefile with new validation targets
- Add Python dependencies in pyproject.toml
- Update npm dependencies and scripts
- Enhance Docker testing tools configuration
- Add targets for validator updates and local ref fixes
- Configure uv for Python package management

* chore: update linting and documentation configuration

- Update EditorConfig settings for consistent formatting
- Enhance pre-commit hooks configuration
- Update prettier and yamllint ignore patterns
- Update gitleaks security scanning rules
- Update CodeRabbit review configuration
- Update CLAUDE.md with latest project standards and rules

* docs: update Serena memory files and project metadata

- Remove obsolete PR-186 memory files
- Update project overview with current architecture
- Update project structure documentation
- Add quality standards and communication guidelines
- Add modular validator architecture documentation
- Add shellspec testing framework documentation
- Update project.yml with latest configuration

* feat: moved rules.yml to same folder as action, fixes

* fix(validators): correct token patterns and fix validator bugs

- Fix GitHub classic PAT pattern: ghp_ + 36 chars = 40 total
- Fix GitHub fine-grained PAT pattern: github_pat_ + 71 chars = 82 total
- Initialize result variable in convention_mapper to prevent UnboundLocalError
- Fix empty URL validation in network validator to return error
- Add GitHub expression check to docker architectures validator
- Update docker-build CustomValidator parallel-builds max to 16

* test(validators): fix test fixtures and expectations

- Fix token lengths in test data: github_pat 71 chars, ghp/gho 36 chars
- Update integration tests with correct token lengths
- Fix file validator test to expect absolute paths rejected for security
- Rename TestGenerator import to avoid pytest collection warning
- Update custom validator tests with correct input names
- Change docker-build tests: platforms->architectures, tags->tag
- Update docker-publish tests to match new registry enum validation

* test(shellspec): fix token lengths in test helpers and specs

- Fix default token lengths in spec_helper.sh to use correct 40-char format
- Update csharp-publish default tokens in 4 locations
- Update codeql-analysis default tokens in 2 locations
- Fix codeql-analysis test tokens to correct lengths (40 and 82 chars)
- Fix npm-publish fine-grained token test to use 82-char format

* feat(actions): add permissions documentation and environment variable usage

- Add permissions comments to all action.yml files documenting required GitHub permissions
- Convert direct input usage to environment variables in shell steps for security
- Add validation steps with proper error handling
- Update input descriptions and add security notes where applicable
- Ensure all actions follow consistent patterns for input validation

* chore(workflows): update GitHub Actions workflow versions

- Update workflow action versions to latest
- Improve workflow consistency and maintainability

* docs(security): add comprehensive security policy

- Document security features and best practices
- Add vulnerability reporting process
- Include audit history and security testing information

* docs(memory): add GitHub workflow reference documentation

- Add GitHub Actions workflow commands reference
- Add GitHub workflow expressions guide
- Add secure workflow usage patterns and best practices

* chore: token optimization, code style conventions
* chore: cr fixes
* fix: trivy reported Dockerfile problems
* fix(security): more security fixes
* chore: dockerfile and make targets for publishing
* fix(ci): add creds to test-actions workflow
* fix: security fix and checkout step to codeql-new
* chore: test fixes
* fix(security): codeql detected issues
* chore: code review fixes, ReDos protection
* style: apply MegaLinter fixes
* fix(ci): missing packages read permission
* fix(ci): add missing working directory setting
* chore: linting, add validation-regex to use regex_pattern
* chore: code review fixes
* chore(deps): update actions
* fix(security): codeql fixes
* chore(cr): apply cr comments
* chore: improve POSIX compatibility
* chore(cr): apply cr comments
* fix: codeql warning in Dockerfile, build failures
* chore(cr): apply cr comments
* fix: docker-testing-tools/Dockerfile
* chore(cr): apply cr comments
* fix(docker): update testing-tools image for GitHub Actions compatibility
* chore(cr): apply cr comments
* feat: add more tests, fix issues
* chore: fix codeql issues, update actions
* chore(cr): apply cr comments
* fix: integration tests
* chore: deduplication and fixes
* style: apply MegaLinter fixes
* chore(cr): apply cr comments
* feat: dry-run mode for generate-tests
* fix(ci): kcov installation
* chore(cr): apply cr comments
* chore(cr): apply cr comments
* chore(cr): apply cr comments
* chore(cr): apply cr comments, simplify action testing, use uv
* fix: run-tests.sh action counting
* chore(cr): apply cr comments
* chore(cr): apply cr comments
2025-10-14 13:37:58 +03:00

308 lines
13 KiB
Python

"""Tests for codeql validator."""
from validators.codeql import CodeQLValidator
class TestCodeqlValidator:
"""Test cases for CodeqlValidator."""
def setup_method(self):
"""Set up test fixtures."""
self.validator = CodeQLValidator("test-action")
def teardown_method(self):
"""Clean up after tests."""
self.validator.clear_errors()
def test_initialization(self):
"""Test validator initialization."""
assert self.validator.action_type == "test-action"
assert len(self.validator.SUPPORTED_LANGUAGES) > 0
assert len(self.validator.STANDARD_SUITES) > 0
assert len(self.validator.BUILD_MODES) > 0
def test_get_required_inputs(self):
"""Test getting required inputs."""
required = self.validator.get_required_inputs()
assert "language" in required
def test_get_validation_rules(self):
"""Test getting validation rules."""
rules = self.validator.get_validation_rules()
assert "language" in rules
assert "queries" in rules
assert "build_modes" in rules
def test_validate_inputs(self):
"""Test validate_inputs method."""
inputs = {"language": "python"}
result = self.validator.validate_inputs(inputs)
assert result is True
def test_error_handling(self):
"""Test error handling."""
self.validator.add_error("Test error")
assert self.validator.has_errors()
assert len(self.validator.errors) == 1
self.validator.clear_errors()
assert not self.validator.has_errors()
assert len(self.validator.errors) == 0
def test_github_expressions(self):
"""Test GitHub expression handling."""
result = self.validator.is_github_expression("${{ inputs.value }}")
assert result is True
# Language validation tests
def test_validate_codeql_language_valid(self):
"""Test validation of valid CodeQL languages."""
valid_languages = ["python", "javascript", "typescript", "java", "go", "cpp", "csharp"]
for lang in valid_languages:
assert self.validator.validate_codeql_language(lang) is True
self.validator.clear_errors()
def test_validate_codeql_language_case_insensitive(self):
"""Test language validation is case insensitive."""
assert self.validator.validate_codeql_language("Python") is True
assert self.validator.validate_codeql_language("JAVASCRIPT") is True
def test_validate_codeql_language_empty(self):
"""Test validation rejects empty language."""
assert self.validator.validate_codeql_language("") is False
assert self.validator.has_errors()
def test_validate_codeql_language_invalid(self):
"""Test validation rejects invalid language."""
assert self.validator.validate_codeql_language("invalid-lang") is False
assert self.validator.has_errors()
# Queries validation tests
def test_validate_codeql_queries_standard_suite(self):
"""Test validation of standard query suites."""
standard_suites = ["security-extended", "security-and-quality", "code-scanning", "default"]
for suite in standard_suites:
assert self.validator.validate_codeql_queries(suite) is True
self.validator.clear_errors()
def test_validate_codeql_queries_multiple(self):
"""Test validation of multiple query suites."""
assert self.validator.validate_codeql_queries("security-extended,code-scanning") is True
def test_validate_codeql_queries_file_path(self):
"""Test validation of query file paths."""
assert self.validator.validate_codeql_queries("queries/security.ql") is True
assert self.validator.validate_codeql_queries("queries/suite.qls") is True
def test_validate_codeql_queries_custom_path(self):
"""Test validation of custom query paths."""
assert self.validator.validate_codeql_queries("./custom/queries") is True
def test_validate_codeql_queries_github_expression(self):
"""Test queries accept GitHub expressions."""
assert self.validator.validate_codeql_queries("${{ inputs.queries }}") is True
def test_validate_codeql_queries_empty(self):
"""Test validation rejects empty queries."""
assert self.validator.validate_codeql_queries("") is False
assert self.validator.has_errors()
def test_validate_codeql_queries_invalid(self):
"""Test validation rejects invalid queries."""
assert self.validator.validate_codeql_queries("invalid-query") is False
assert self.validator.has_errors()
def test_validate_codeql_queries_path_traversal(self):
"""Test queries reject path traversal."""
result = self.validator.validate_codeql_queries("../../../etc/passwd")
assert result is False
assert self.validator.has_errors()
# Packs validation tests
def test_validate_codeql_packs_valid(self):
"""Test validation of valid pack formats."""
valid_packs = [
"my-pack",
"owner/repo",
"owner/repo@1.0.0",
"org/pack@latest",
]
for pack in valid_packs:
assert self.validator.validate_codeql_packs(pack) is True
self.validator.clear_errors()
def test_validate_codeql_packs_multiple(self):
"""Test validation of multiple packs."""
assert self.validator.validate_codeql_packs("pack1,owner/pack2,org/pack3@1.0") is True
def test_validate_codeql_packs_empty(self):
"""Test empty packs are allowed."""
assert self.validator.validate_codeql_packs("") is True
def test_validate_codeql_packs_invalid_format(self):
"""Test validation rejects invalid pack format."""
assert self.validator.validate_codeql_packs("invalid pack!") is False
assert self.validator.has_errors()
# Build mode validation tests
def test_validate_codeql_build_mode_valid(self):
"""Test validation of valid build modes."""
valid_modes = ["none", "manual", "autobuild"]
for mode in valid_modes:
assert self.validator.validate_codeql_build_mode(mode) is True
self.validator.clear_errors()
def test_validate_codeql_build_mode_case_insensitive(self):
"""Test build mode validation is case insensitive."""
assert self.validator.validate_codeql_build_mode("None") is True
assert self.validator.validate_codeql_build_mode("AUTOBUILD") is True
def test_validate_codeql_build_mode_empty(self):
"""Test empty build mode is allowed."""
assert self.validator.validate_codeql_build_mode("") is True
def test_validate_codeql_build_mode_invalid(self):
"""Test validation rejects invalid build mode."""
assert self.validator.validate_codeql_build_mode("invalid-mode") is False
assert self.validator.has_errors()
# Config validation tests
def test_validate_codeql_config_valid(self):
"""Test validation of valid config."""
valid_config = "name: my-config\nqueries: security-extended"
assert self.validator.validate_codeql_config(valid_config) is True
def test_validate_codeql_config_empty(self):
"""Test empty config is allowed."""
assert self.validator.validate_codeql_config("") is True
def test_validate_codeql_config_dangerous_python(self):
"""Test config rejects dangerous Python patterns."""
assert self.validator.validate_codeql_config("!!python/object/apply") is False
assert self.validator.has_errors()
def test_validate_codeql_config_dangerous_ruby(self):
"""Test config rejects dangerous Ruby patterns."""
assert self.validator.validate_codeql_config("!!ruby/object:Gem::Installer") is False
assert self.validator.has_errors()
def test_validate_codeql_config_dangerous_patterns(self):
"""Test config rejects all dangerous patterns."""
dangerous = ["!!python/", "!!ruby/", "!!perl/", "!!js/"]
for pattern in dangerous:
self.validator.clear_errors()
assert self.validator.validate_codeql_config(f"test: {pattern}code") is False
assert self.validator.has_errors()
# Category validation tests
def test_validate_category_format_valid(self):
"""Test validation of valid category formats."""
valid_categories = [
"/language:python",
"/security",
"/my-category",
"/lang:javascript/security",
]
for category in valid_categories:
assert self.validator.validate_category_format(category) is True
self.validator.clear_errors()
def test_validate_category_format_github_expression(self):
"""Test category accepts GitHub expressions."""
assert self.validator.validate_category_format("${{ inputs.category }}") is True
def test_validate_category_format_empty(self):
"""Test empty category is allowed."""
assert self.validator.validate_category_format("") is True
def test_validate_category_format_no_leading_slash(self):
"""Test category must start with /."""
assert self.validator.validate_category_format("category") is False
assert self.validator.has_errors()
def test_validate_category_format_invalid_chars(self):
"""Test category rejects invalid characters."""
assert self.validator.validate_category_format("/invalid!@#") is False
assert self.validator.has_errors()
# Threads validation tests
def test_validate_threads_valid(self):
"""Test validation of valid thread counts."""
valid_threads = ["1", "4", "8", "16", "32", "64", "128"]
for threads in valid_threads:
assert self.validator.validate_threads(threads) is True
self.validator.clear_errors()
def test_validate_threads_empty(self):
"""Test empty threads is allowed."""
assert self.validator.validate_threads("") is True
def test_validate_threads_invalid_range(self):
"""Test threads rejects out of range values."""
assert self.validator.validate_threads("0") is False
assert self.validator.validate_threads("200") is False
def test_validate_threads_non_numeric(self):
"""Test threads rejects non-numeric values."""
assert self.validator.validate_threads("not-a-number") is False
# RAM validation tests
def test_validate_ram_valid(self):
"""Test validation of valid RAM values."""
valid_ram = ["256", "512", "1024", "2048", "4096", "8192"]
for ram in valid_ram:
assert self.validator.validate_ram(ram) is True
self.validator.clear_errors()
def test_validate_ram_empty(self):
"""Test empty RAM is allowed."""
assert self.validator.validate_ram("") is True
def test_validate_ram_invalid_range(self):
"""Test RAM rejects out of range values."""
assert self.validator.validate_ram("100") is False
assert self.validator.validate_ram("50000") is False
def test_validate_ram_non_numeric(self):
"""Test RAM rejects non-numeric values."""
assert self.validator.validate_ram("not-a-number") is False
# Numeric range validation tests
def test_validate_numeric_range_1_128(self):
"""Test numeric range 1-128 validation."""
assert self.validator.validate_numeric_range_1_128("1", "threads") is True
assert self.validator.validate_numeric_range_1_128("128", "threads") is True
assert self.validator.validate_numeric_range_1_128("0", "threads") is False
assert self.validator.validate_numeric_range_1_128("129", "threads") is False
def test_validate_numeric_range_256_32768(self):
"""Test numeric range 256-32768 validation."""
assert self.validator.validate_numeric_range_256_32768("256", "ram") is True
assert self.validator.validate_numeric_range_256_32768("32768", "ram") is True
assert self.validator.validate_numeric_range_256_32768("255", "ram") is False
assert self.validator.validate_numeric_range_256_32768("40000", "ram") is False
# Integration tests
def test_validate_inputs_multiple_fields(self):
"""Test validation with multiple input fields."""
inputs = {
"language": "python",
"queries": "security-extended",
"build-mode": "none",
"category": "/security",
"threads": "4",
}
result = self.validator.validate_inputs(inputs)
assert result is True
def test_validate_inputs_with_errors(self):
"""Test validation with invalid inputs."""
inputs = {
"language": "invalid-lang",
"threads": "500",
}
result = self.validator.validate_inputs(inputs)
assert result is False
assert self.validator.has_errors()
assert len(self.validator.errors) >= 2