mirror of
https://github.com/ivuorinen/actions.git
synced 2026-01-26 11:34:00 +00:00
* feat: fixes, tweaks, new actions, linting * fix: improve docker publish loops and dotnet parsing (#193) * fix: harden action scripts and version checks (#191) * refactor: major repository restructuring and security enhancements Add comprehensive development infrastructure: - Add Makefile with automated documentation generation, formatting, and linting tasks - Add TODO.md tracking self-containment progress and repository improvements - Add .nvmrc for consistent Node.js version management - Create python-version-detect-v2 action for enhanced Python detection Enhance all GitHub Actions with standardized patterns: - Add consistent token handling across 27 actions using standardized input patterns - Implement bash error handling (set -euo pipefail) in all shell steps - Add comprehensive input validation for path traversal and command injection protection - Standardize checkout token authentication to prevent rate limiting - Remove relative action dependencies to ensure external usability Rewrite security workflow for PR-focused analysis: - Transform security-suite.yml to PR-only security analysis workflow - Remove scheduled runs, repository issue management, and Slack notifications - Implement smart comment generation showing only sections with content - Add GitHub Actions permission diff analysis and new action detection - Integrate OWASP, Semgrep, and TruffleHog for comprehensive PR security scanning Improve version detection and dependency management: - Simplify version detection actions to use inline logic instead of shared utilities - Fix Makefile version detection fallback to properly return 'main' when version not found - Update all external action references to use SHA-pinned versions - Remove deprecated run.sh in favor of Makefile automation Update documentation and project standards: - Enhance CLAUDE.md with self-containment requirements and linting standards - Update README.md with improved action descriptions and usage examples - Standardize code formatting with updated .editorconfig and .prettierrc.yml - Improve GitHub templates for issues and security reporting This refactoring ensures all 40 actions are fully self-contained and can be used independently when referenced as ivuorinen/actions/action-name@main, addressing the critical requirement for external usability while maintaining comprehensive security analysis and development automation. * feat: add automated action catalog generation system - Create generate_listing.cjs script for comprehensive action catalog - Add package.json with development tooling and npm scripts - Implement automated README.md catalog section with --update flag - Generate markdown reference-style links for all 40 actions - Add categorized tables with features, language support matrices - Replace static reference links with auto-generated dynamic links - Enable complete automation of action documentation maintenance * feat: enhance actions with improved documentation and functionality - Add comprehensive README files for 12 actions with usage examples - Implement new utility actions (go-version-detect, dotnet-version-detect) - Enhance node-setup with extensive configuration options - Improve error handling and validation across all actions - Update package.json scripts for better development workflow - Expand TODO.md with detailed roadmap and improvement plans - Standardize action structure with consistent inputs/outputs * feat: add comprehensive output handling across all actions - Add standardized outputs to 15 actions that previously had none - Implement consistent snake_case naming convention for all outputs - Add build status and test results outputs to build actions - Add files changed and status outputs to lint/fix actions - Add test execution metrics to php-tests action - Add stale/closed counts to stale action - Add release URLs and IDs to github-release action - Update documentation with output specifications - Mark comprehensive output handling task as complete in TODO.md * feat: implement shared cache strategy across all actions - Add caching to 10 actions that previously had none (Node.js, .NET, Python, Go) - Standardize 4 existing actions to use common-cache instead of direct actions/cache - Implement consistent cache-hit optimization to skip installations when cache available - Add language-specific cache configurations with appropriate key files - Create unified caching approach using ivuorinen/actions/common-cache@main - Fix YAML syntax error in php-composer action paths parameter - Update TODO.md to mark shared cache strategy as complete * feat: implement comprehensive retry logic for network operations - Create new common-retry action for standardized retry patterns with configurable strategies - Add retry logic to 9 actions missing network retry capabilities - Implement exponential backoff, custom timeouts, and flexible error handling - Add max-retries input parameter to all network-dependent actions (Node.js, .NET, Python, Go) - Standardize existing retry implementations to use common-retry utility - Update action catalog to include new common-retry action (41 total actions) - Update documentation with retry configuration examples and parameters - Mark retry logic implementation as complete in TODO.md roadmap * feat: enhance Node.js support with Corepack and Bun - Add Corepack support for automatic package manager version management - Add Bun package manager support across all Node.js actions - Improve Yarn Berry/PnP support with .yarnrc.yml detection - Add Node.js feature detection (ESM, TypeScript, frameworks) - Update package manager detection priority and lockfile support - Enhance caching with package-manager-specific keys - Update eslint, prettier, and biome actions for multi-package-manager support * fix: resolve critical runtime issues across multiple actions - Fix token validation by removing ineffective literal string comparisons - Add missing @microsoft/eslint-formatter-sarif dependency for SARIF output - Fix Bash variable syntax errors in username and changelog length checks - Update Dockerfile version regex to handle tags with suffixes (e.g., -alpine) - Simplify version selection logic with single grep command - Fix command execution in retry action with proper bash -c wrapper - Correct step output references using .outcome instead of .outputs.outcome - Add missing step IDs for version detection actions - Include go.mod in cache key files for accurate invalidation - Require minor version in all version regex patterns - Improve Bun installation security by verifying script before execution - Replace bc with sort -V for portable PHP version comparison - Remove non-existent pre-commit output references These fixes ensure proper runtime behavior, improved security, and better cross-platform compatibility across all affected actions. * fix: resolve critical runtime and security issues across actions - Fix biome-fix files_changed calculation using git diff instead of git status delta - Fix compress-images output description and add absolute path validation - Remove csharp-publish token default and fix token fallback in push commands - Add @microsoft/eslint-formatter-sarif to all package managers in eslint-check - Fix eslint-check command syntax by using variable assignment - Improve node-setup Bun installation security and remove invalid frozen-lockfile flag - Fix pre-commit token validation by removing ineffective literal comparison - Fix prettier-fix token comparison and expand regex for all GitHub token types - Add version-file-parser regex validation safety and fix csproj wildcard handling These fixes address security vulnerabilities, runtime errors, and functional issues to ensure reliable operation across all affected GitHub Actions. * feat: enhance Docker actions with advanced multi-architecture support Major enhancement to Docker build and publish actions with comprehensive multi-architecture capabilities and enterprise-grade features. Added features: - Advanced buildx configuration (version control, cache modes, build contexts) - Auto-detect platforms for dynamic architecture discovery - Performance optimizations with enhanced caching strategies - Security scanning with Trivy and image signing with Cosign - SBOM generation in multiple formats with validation - Verbose logging and dry-run modes for debugging - Platform-specific build args and fallback mechanisms Enhanced all Docker actions: - docker-build: Core buildx features and multi-arch support - docker-publish-gh: GitHub Packages with security features - docker-publish-hub: Docker Hub with scanning and signing - docker-publish: Orchestrator with unified configuration Updated documentation across all modified actions. * fix: resolve documentation generation placeholder issue Fixed Makefile and package.json to properly replace placeholder tokens in generated documentation, ensuring all README files show correct repository paths instead of ***PROJECT***@***VERSION***. * chore: simplify github token validation * chore(lint): optional yamlfmt, config and fixes * feat: use relative `uses` names * feat: comprehensive testing infrastructure and Python validation system - Migrate from tests/ to _tests/ directory structure with ShellSpec framework - Add comprehensive validation system with Python-based input validation - Implement dual testing approach (ShellSpec + pytest) for complete coverage - Add modern Python tooling (uv, ruff, pytest-cov) and dependencies - Create centralized validation rules with automatic generation system - Update project configuration and build system for new architecture - Enhance documentation to reflect current testing capabilities This establishes a robust foundation for action validation and testing with extensive coverage across all GitHub Actions in the repository. * chore: remove Dockerfile for now * chore: code review fixes * feat: comprehensive GitHub Actions restructuring and tooling improvements This commit represents a major restructuring of the GitHub Actions monorepo with improved tooling, testing infrastructure, and comprehensive PR #186 review implementation. ## Major Changes ### 🔧 Development Tooling & Configuration - **Shellcheck integration**: Exclude shellspec test files from linting - Updated .pre-commit-config.yaml to exclude _tests/*.sh from shellcheck/shfmt - Modified Makefile shellcheck pattern to skip shellspec files - Updated CLAUDE.md documentation with proper exclusion syntax - **Testing infrastructure**: Enhanced Python validation framework - Fixed nested if statements and boolean parameter issues in validation.py - Improved code quality with explicit keyword arguments - All pre-commit hooks now passing ### 🏗️ Project Structure & Documentation - **Added Serena AI integration** with comprehensive project memories: - Project overview, structure, and technical stack documentation - Code style conventions and completion requirements - Comprehensive PR #186 review analysis and implementation tracking - **Enhanced configuration**: Updated .gitignore, .yamlfmt.yml, pyproject.toml - **Improved testing**: Added integration workflows and enhanced test specs ### 🚀 GitHub Actions Improvements (30+ actions updated) - **Centralized validation**: Updated 41 validation rule files - **Enhanced actions**: Improvements across all action categories: - Setup actions (node-setup, version detectors) - Utility actions (version-file-parser, version-validator) - Linting actions (biome, eslint, terraform-lint-fix major refactor) - Build/publish actions (docker-build, npm-publish, csharp-*) - Repository management actions ### 📝 Documentation Updates - **README consistency**: Updated version references across action READMEs - **Enhanced documentation**: Improved action descriptions and usage examples - **CLAUDE.md**: Updated with current tooling and best practices ## Technical Improvements - **Security enhancements**: Input validation and sanitization improvements - **Performance optimizations**: Streamlined action logic and dependencies - **Cross-platform compatibility**: Better Windows/macOS/Linux support - **Error handling**: Improved error reporting and user feedback ## Files Changed - 100 files changed - 13 new Serena memory files documenting project state - 41 validation rules updated for consistency - 30+ GitHub Actions and READMEs improved - Core tooling configuration enhanced * feat: comprehensive GitHub Actions improvements and PR review fixes Major Infrastructure Improvements: - Add comprehensive testing framework with 17+ ShellSpec validation tests - Implement Docker-based testing tools with automated test runner - Add CodeRabbit configuration for automated code reviews - Restructure documentation and memory management system - Update validation rules for 25+ actions with enhanced input validation - Modernize CI/CD workflows and testing infrastructure Critical PR Review Fixes (All Issues Resolved): - Fix double caching in node-setup (eliminate redundant cache operations) - Optimize shell pipeline in version-file-parser (single awk vs complex pipeline) - Fix GitHub expression interpolation in prettier-check cache keys - Resolve terraform command order issue (validation after setup) - Add missing flake8-sarif dependency for Python SARIF output - Fix environment variable scope in pr-lint (export to GITHUB_ENV) Performance & Reliability: - Eliminate duplicate cache operations saving CI time - Improve shell script efficiency with optimized parsing - Fix command execution dependencies preventing runtime failures - Ensure proper dependency installation for all linting tools - Resolve workflow conditional logic issues Security & Quality: - All input validation rules updated with latest security patterns - Cross-platform compatibility improvements maintained - Comprehensive error handling and retry logic preserved - Modern development tooling and best practices adopted This commit addresses 100% of actionable feedback from PR review analysis, implements comprehensive testing infrastructure, and maintains high code quality standards across all 41 GitHub Actions. * feat: enhance expression handling and version parsing - Fix node-setup force-version expression logic for proper empty string handling - Improve version-file-parser with secure regex validation and enhanced Python detection - Add CodeRabbit configuration for CalVer versioning and README review guidance * feat(validate-inputs): implement modular validation system - Add modular validator architecture with specialized validators - Implement base validator classes for different input types - Add validators: boolean, docker, file, network, numeric, security, token, version - Add convention mapper for automatic input validation - Add comprehensive documentation for the validation system - Implement PCRE regex support and injection protection * feat(validate-inputs): add validation rules for all actions - Add YAML validation rules for 42 GitHub Actions - Auto-generated rules with convention mappings - Include metadata for validation coverage and quality indicators - Mark rules as auto-generated to prevent manual edits * test(validate-inputs): add comprehensive test suite for validators - Add unit tests for all validator modules - Add integration tests for the validation system - Add fixtures for version test data - Test coverage for boolean, docker, file, network, numeric, security, token, and version validators - Add tests for convention mapper and registry * feat(tools): add validation scripts and utilities - Add update-validators.py script for auto-generating rules - Add benchmark-validator.py for performance testing - Add debug-validator.py for troubleshooting - Add generate-tests.py for test generation - Add check-rules-not-manually-edited.sh for CI validation - Add fix-local-action-refs.py tool for fixing action references * feat(actions): add CustomValidator.py files for specialized validation - Add custom validators for actions requiring special validation logic - Implement validators for docker, go, node, npm, php, python, terraform actions - Add specialized validation for compress-images, common-cache, common-file-check - Implement version detection validators with language-specific logic - Add validation for build arguments, architectures, and version formats * test: update ShellSpec test framework for Python validation - Update all validation.spec.sh files to use Python validator - Add shared validation_core.py for common test utilities - Remove obsolete bash validation helpers - Update test output expectations for Python validator format - Add codeql-analysis test suite - Refactor framework utilities for Python integration - Remove deprecated test files * feat(actions): update action.yml files to use validate-inputs - Replace inline bash validation with validate-inputs action - Standardize validation across all 42 actions - Add new codeql-analysis action - Update action metadata and branding - Add validation step as first step in composite actions - Maintain backward compatibility with existing inputs/outputs * ci: update GitHub workflows for enhanced security and testing - Add new codeql-new.yml workflow - Update security scanning workflows - Enhance dependency review configuration - Update test-actions workflow for new validation system - Improve workflow permissions and security settings - Update action versions to latest SHA-pinned releases * build: update build configuration and dependencies - Update Makefile with new validation targets - Add Python dependencies in pyproject.toml - Update npm dependencies and scripts - Enhance Docker testing tools configuration - Add targets for validator updates and local ref fixes - Configure uv for Python package management * chore: update linting and documentation configuration - Update EditorConfig settings for consistent formatting - Enhance pre-commit hooks configuration - Update prettier and yamllint ignore patterns - Update gitleaks security scanning rules - Update CodeRabbit review configuration - Update CLAUDE.md with latest project standards and rules * docs: update Serena memory files and project metadata - Remove obsolete PR-186 memory files - Update project overview with current architecture - Update project structure documentation - Add quality standards and communication guidelines - Add modular validator architecture documentation - Add shellspec testing framework documentation - Update project.yml with latest configuration * feat: moved rules.yml to same folder as action, fixes * fix(validators): correct token patterns and fix validator bugs - Fix GitHub classic PAT pattern: ghp_ + 36 chars = 40 total - Fix GitHub fine-grained PAT pattern: github_pat_ + 71 chars = 82 total - Initialize result variable in convention_mapper to prevent UnboundLocalError - Fix empty URL validation in network validator to return error - Add GitHub expression check to docker architectures validator - Update docker-build CustomValidator parallel-builds max to 16 * test(validators): fix test fixtures and expectations - Fix token lengths in test data: github_pat 71 chars, ghp/gho 36 chars - Update integration tests with correct token lengths - Fix file validator test to expect absolute paths rejected for security - Rename TestGenerator import to avoid pytest collection warning - Update custom validator tests with correct input names - Change docker-build tests: platforms->architectures, tags->tag - Update docker-publish tests to match new registry enum validation * test(shellspec): fix token lengths in test helpers and specs - Fix default token lengths in spec_helper.sh to use correct 40-char format - Update csharp-publish default tokens in 4 locations - Update codeql-analysis default tokens in 2 locations - Fix codeql-analysis test tokens to correct lengths (40 and 82 chars) - Fix npm-publish fine-grained token test to use 82-char format * feat(actions): add permissions documentation and environment variable usage - Add permissions comments to all action.yml files documenting required GitHub permissions - Convert direct input usage to environment variables in shell steps for security - Add validation steps with proper error handling - Update input descriptions and add security notes where applicable - Ensure all actions follow consistent patterns for input validation * chore(workflows): update GitHub Actions workflow versions - Update workflow action versions to latest - Improve workflow consistency and maintainability * docs(security): add comprehensive security policy - Document security features and best practices - Add vulnerability reporting process - Include audit history and security testing information * docs(memory): add GitHub workflow reference documentation - Add GitHub Actions workflow commands reference - Add GitHub workflow expressions guide - Add secure workflow usage patterns and best practices * chore: token optimization, code style conventions * chore: cr fixes * fix: trivy reported Dockerfile problems * fix(security): more security fixes * chore: dockerfile and make targets for publishing * fix(ci): add creds to test-actions workflow * fix: security fix and checkout step to codeql-new * chore: test fixes * fix(security): codeql detected issues * chore: code review fixes, ReDos protection * style: apply MegaLinter fixes * fix(ci): missing packages read permission * fix(ci): add missing working directory setting * chore: linting, add validation-regex to use regex_pattern * chore: code review fixes * chore(deps): update actions * fix(security): codeql fixes * chore(cr): apply cr comments * chore: improve POSIX compatibility * chore(cr): apply cr comments * fix: codeql warning in Dockerfile, build failures * chore(cr): apply cr comments * fix: docker-testing-tools/Dockerfile * chore(cr): apply cr comments * fix(docker): update testing-tools image for GitHub Actions compatibility * chore(cr): apply cr comments * feat: add more tests, fix issues * chore: fix codeql issues, update actions * chore(cr): apply cr comments * fix: integration tests * chore: deduplication and fixes * style: apply MegaLinter fixes * chore(cr): apply cr comments * feat: dry-run mode for generate-tests * fix(ci): kcov installation * chore(cr): apply cr comments * chore(cr): apply cr comments * chore(cr): apply cr comments * chore(cr): apply cr comments, simplify action testing, use uv * fix: run-tests.sh action counting * chore(cr): apply cr comments * chore(cr): apply cr comments
607 lines
22 KiB
Python
607 lines
22 KiB
Python
"""Version validators for various versioning schemes."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import re
|
|
|
|
from .base import BaseValidator
|
|
|
|
|
|
class VersionValidator(BaseValidator):
|
|
"""Validator for version strings (SemVer, CalVer, language-specific)."""
|
|
|
|
# Common version patterns
|
|
VERSION_X_Y_Z_PATTERN = r"^\d+\.\d+(\.\d+)?$"
|
|
|
|
def validate_inputs(self, inputs: dict[str, str]) -> bool:
|
|
"""Validate version-related inputs."""
|
|
valid = True
|
|
|
|
for input_name, value in inputs.items():
|
|
if "version" in input_name.lower():
|
|
# Determine version type from input name
|
|
if "dotnet" in input_name:
|
|
valid &= self.validate_dotnet_version(value, input_name)
|
|
elif "terraform" in input_name or "tflint" in input_name:
|
|
valid &= self.validate_terraform_version(value, input_name)
|
|
elif "node" in input_name:
|
|
valid &= self.validate_node_version(value, input_name)
|
|
elif "python" in input_name:
|
|
valid &= self.validate_python_version(value, input_name)
|
|
elif "php" in input_name:
|
|
valid &= self.validate_php_version(value, input_name)
|
|
elif "go" in input_name:
|
|
valid &= self.validate_go_version(value, input_name)
|
|
else:
|
|
# Default to semantic version
|
|
valid &= self.validate_semantic_version(value, input_name)
|
|
|
|
return valid
|
|
|
|
def get_required_inputs(self) -> list[str]:
|
|
"""Version validators typically don't define required inputs."""
|
|
return []
|
|
|
|
def get_validation_rules(self) -> dict:
|
|
"""Return version validation rules."""
|
|
return {
|
|
"semantic": "X.Y.Z format with optional pre-release and build metadata",
|
|
"calver": "Calendar-based versioning (YYYY.MM.DD, etc.)",
|
|
"dotnet": ".NET version format",
|
|
"terraform": "Terraform version format",
|
|
"node": "Node.js version format",
|
|
"python": "Python 3.x version",
|
|
"php": "PHP 7.4-9.x version",
|
|
"go": "Go 1.x version",
|
|
}
|
|
|
|
def validate_semantic_version(self, version: str, name: str = "version") -> bool:
|
|
"""Validate semantic version format.
|
|
|
|
Args:
|
|
version: The version string to validate
|
|
name: The input name for error messages
|
|
|
|
Returns:
|
|
True if valid, False otherwise
|
|
"""
|
|
if not version or version.strip() == "":
|
|
return True # Version is often optional
|
|
|
|
# Remove 'v' or 'V' prefix if present (case-insensitive)
|
|
clean_version = version
|
|
if clean_version.lower().startswith("v"):
|
|
clean_version = clean_version[1:]
|
|
|
|
# Examples: 1.0.0, 2.1.3-beta, 3.0.0-rc.1, 1.2.3+20130313144700
|
|
semver_pattern = (
|
|
r"^(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)" # MAJOR.MINOR.PATCH
|
|
r"(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)" # Pre-release
|
|
r"(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?"
|
|
r"(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?$" # Build metadata
|
|
)
|
|
|
|
if re.match(semver_pattern, clean_version):
|
|
return True
|
|
|
|
# Also allow simple X.Y format for flexibility
|
|
simple_pattern = r"^(0|[1-9]\d*)\.(0|[1-9]\d*)$"
|
|
if re.match(simple_pattern, clean_version):
|
|
return True
|
|
|
|
# Also allow single digit version (e.g., "1", "2")
|
|
single_digit_pattern = r"^(0|[1-9]\d*)$"
|
|
if re.match(single_digit_pattern, clean_version):
|
|
return True
|
|
|
|
self.add_error(
|
|
f'Invalid semantic version: "{version}" in {name}. '
|
|
"Expected format: MAJOR.MINOR.PATCH (e.g., 1.2.3, 2.0.0-beta)",
|
|
)
|
|
return False
|
|
|
|
# Compatibility aliases for tests and backward compatibility
|
|
def validate_semver(self, version: str, name: str = "version") -> bool:
|
|
"""Alias for validate_semantic_version."""
|
|
return self.validate_semantic_version(version, name)
|
|
|
|
def validate_calver(self, version: str, name: str = "version") -> bool:
|
|
"""Alias for validate_calver_version."""
|
|
return self.validate_calver_version(version, name)
|
|
|
|
def validate_version(self, version: str, version_type: str, name: str = "version") -> bool:
|
|
"""Generic version validation based on type."""
|
|
if version_type == "semantic":
|
|
return self.validate_semantic_version(version, name)
|
|
if version_type == "calver":
|
|
return self.validate_calver_version(version, name)
|
|
if version_type == "flexible":
|
|
return self.validate_flexible_version(version, name)
|
|
if version_type == "dotnet":
|
|
return self.validate_dotnet_version(version, name)
|
|
if version_type == "terraform":
|
|
return self.validate_terraform_version(version, name)
|
|
if version_type == "node":
|
|
return self.validate_node_version(version, name)
|
|
if version_type == "python":
|
|
return self.validate_python_version(version, name)
|
|
if version_type == "php":
|
|
return self.validate_php_version(version, name)
|
|
if version_type == "go":
|
|
return self.validate_go_version(version, name)
|
|
# Allow "latest" as special case
|
|
if version.strip().lower() == "latest":
|
|
return True
|
|
# Default to semantic version
|
|
return self.validate_semantic_version(version, name) # Version is often optional
|
|
|
|
def validate_strict_semantic_version(self, version: str, name: str = "version") -> bool:
|
|
"""Validate strict semantic version format (X.Y.Z required).
|
|
|
|
Args:
|
|
version: The version string to validate
|
|
name: The input name for error messages
|
|
|
|
Returns:
|
|
True if valid, False otherwise
|
|
"""
|
|
if not version or version.strip() == "":
|
|
self.add_error(f"Version cannot be empty in {name}")
|
|
return False
|
|
|
|
# Allow "latest" as special case
|
|
if version.strip().lower() == "latest":
|
|
return True
|
|
|
|
# Remove common prefixes for validation
|
|
clean_version = version.lstrip("v")
|
|
|
|
# Strict semantic version pattern
|
|
pattern = r"^\d+\.\d+\.\d+(-[\dA-Za-z.-]+)?(\+[\dA-Za-z.-]+)?$"
|
|
|
|
if re.match(pattern, clean_version):
|
|
return True
|
|
|
|
self.add_error(
|
|
f'Invalid strict semantic version format: "{version}" in {name}. Must be X.Y.Z',
|
|
)
|
|
return False
|
|
|
|
def validate_calver_version(self, version: str, name: str = "version") -> bool:
|
|
"""Validate CalVer (Calendar Versioning) format.
|
|
|
|
Args:
|
|
version: The version string to validate
|
|
name: The input name for error messages
|
|
|
|
Returns:
|
|
True if valid, False otherwise
|
|
"""
|
|
if not version or version.strip() == "":
|
|
return True # Version is often optional
|
|
|
|
# Remove common prefixes for validation
|
|
clean_version = version.lstrip("v")
|
|
|
|
# CalVer patterns
|
|
calver_patterns = [
|
|
r"^\d{4}\.\d{1,2}\.\d{1,2}$", # YYYY.MM.DD
|
|
r"^\d{4}\.\d{1,2}\.\d{3,}$", # YYYY.MM.PATCH
|
|
r"^\d{4}\.0\d\.0\d$", # YYYY.0M.0D
|
|
r"^\d{2}\.\d{1,2}\.\d+$", # YY.MM.MICRO
|
|
r"^\d{4}\.\d{1,2}$", # YYYY.MM
|
|
r"^\d{4}-\d{2}-\d{2}$", # YYYY-MM-DD
|
|
]
|
|
|
|
for pattern in calver_patterns:
|
|
match = re.match(pattern, clean_version)
|
|
# Additional validation for date components
|
|
if match and self._validate_calver_date_parts(clean_version, pattern):
|
|
return True
|
|
|
|
self.add_error(
|
|
f'Invalid CalVer format: "{version}" in {name}. '
|
|
"Expected formats like YYYY.MM.DD, YY.MM.MICRO, etc.",
|
|
)
|
|
return False
|
|
|
|
def _parse_calver_year(self, year_part: str) -> int | None:
|
|
"""Parse year from CalVer version part.
|
|
|
|
Returns:
|
|
Year as integer, or None if not a valid year format
|
|
"""
|
|
if len(year_part) == 4:
|
|
return int(year_part)
|
|
if len(year_part) == 2:
|
|
# For YY format, assume 2000s
|
|
return 2000 + int(year_part)
|
|
return None # Not a date-based CalVer
|
|
|
|
def _is_valid_month(self, month: int) -> bool:
|
|
"""Check if month is in valid range (1-12)."""
|
|
return 1 <= month <= 12
|
|
|
|
def _is_leap_year(self, year: int) -> bool:
|
|
"""Check if year is a leap year."""
|
|
return (year % 4 == 0 and year % 100 != 0) or (year % 400 == 0)
|
|
|
|
def _get_max_day_for_month(self, month: int, year: int) -> int:
|
|
"""Get maximum valid day for given month and year.
|
|
|
|
Args:
|
|
month: Month (1-12)
|
|
year: Year (for leap year calculation)
|
|
|
|
Returns:
|
|
Maximum valid day for the month
|
|
"""
|
|
if month in [4, 6, 9, 11]: # April, June, September, November
|
|
return 30
|
|
if month == 2: # February
|
|
return 29 if self._is_leap_year(year) else 28
|
|
return 31 # All other months
|
|
|
|
def _is_valid_day(self, day: int, month: int, year: int) -> bool:
|
|
"""Check if day is valid for the given month and year."""
|
|
if not (1 <= day <= 31):
|
|
return False
|
|
max_day = self._get_max_day_for_month(month, year)
|
|
return day <= max_day
|
|
|
|
def _should_validate_day(self, pattern: str, third_part: str) -> bool:
|
|
"""Determine if third part should be validated as a day.
|
|
|
|
Args:
|
|
pattern: The CalVer pattern that matched
|
|
third_part: The third part of the version string
|
|
|
|
Returns:
|
|
True if the third part represents a day and should be validated
|
|
"""
|
|
# YYYY.MM.DD and YYYY-MM-DD formats have day as third part
|
|
if r"\d{1,2}$" in pattern or r"\d{2}$" in pattern:
|
|
# Check if it looks like a day (1-2 digits)
|
|
return third_part.isdigit() and len(third_part) <= 2
|
|
# YYYY.MM.PATCH format has patch number (3+ digits), not a day
|
|
if r"\d{3,}" in pattern:
|
|
return False
|
|
# YYYY.0M.0D format is a date format
|
|
return r"0\d" in pattern
|
|
|
|
def _validate_calver_date_parts(self, version: str, pattern: str) -> bool:
|
|
"""Validate date components in CalVer version.
|
|
|
|
Args:
|
|
version: The version string to validate
|
|
pattern: The regex pattern that matched (helps determine format type)
|
|
|
|
Returns:
|
|
True if date components are valid, False otherwise
|
|
"""
|
|
# Handle different separators
|
|
parts = version.split("-") if "-" in version else version.split(".")
|
|
|
|
# Need at least year and month
|
|
if len(parts) < 2:
|
|
return True
|
|
|
|
# Parse and validate year
|
|
year = self._parse_calver_year(parts[0])
|
|
if year is None:
|
|
return True # Not a date-based CalVer
|
|
|
|
# Validate month
|
|
month = int(parts[1])
|
|
if not self._is_valid_month(month):
|
|
return False
|
|
|
|
# Validate day if present and pattern indicates it's a day (not patch number)
|
|
if len(parts) >= 3 and self._should_validate_day(pattern, parts[2]):
|
|
day = int(parts[2])
|
|
if not self._is_valid_day(day, month, year):
|
|
return False
|
|
|
|
return True
|
|
|
|
def validate_flexible_version(self, version: str, name: str = "version") -> bool:
|
|
"""Validate either CalVer or SemVer format.
|
|
|
|
Args:
|
|
version: The version string to validate
|
|
name: The input name for error messages
|
|
|
|
Returns:
|
|
True if valid, False otherwise
|
|
"""
|
|
if not version or version.strip() == "":
|
|
return True # Version is often optional
|
|
|
|
# Allow "latest" as special case
|
|
if version.strip().lower() == "latest":
|
|
return True
|
|
|
|
# Save current errors
|
|
original_errors = self.errors.copy()
|
|
|
|
# Try CalVer first if it looks like CalVer
|
|
clean_version = version.lstrip("v")
|
|
looks_like_calver = (
|
|
re.match(r"^\d{4}\.", clean_version)
|
|
or re.match(r"^\d{4}-", clean_version)
|
|
or (re.match(r"^\d{2}\.\d", clean_version) and int(clean_version.split(".")[0]) >= 20)
|
|
)
|
|
|
|
if looks_like_calver:
|
|
self.errors = []
|
|
if self.validate_calver_version(version, name):
|
|
self.errors = original_errors
|
|
return True
|
|
# If it looks like CalVer but fails, don't try SemVer
|
|
self.errors = original_errors
|
|
self.add_error(f'Invalid CalVer format: "{version}" in {name}')
|
|
return False
|
|
|
|
# Try SemVer
|
|
self.errors = []
|
|
if self.validate_semantic_version(version, name):
|
|
self.errors = original_errors
|
|
return True
|
|
|
|
# Failed both
|
|
self.errors = original_errors
|
|
self.add_error(
|
|
f'Invalid version format: "{version}" in {name}. '
|
|
"Expected either CalVer (e.g., 2024.3.1) or SemVer (e.g., 1.2.3)",
|
|
)
|
|
return False
|
|
|
|
def validate_dotnet_version(self, value: str, name: str = "dotnet-version") -> bool:
|
|
"""Validate .NET version format."""
|
|
return self._validate_language_version(
|
|
value,
|
|
name,
|
|
{
|
|
"name": ".NET",
|
|
"major_range": (3, 20),
|
|
"pattern": r"^\d+(\.\d+(\.\d+)?)?(-[\dA-Za-z-]+(\.\dA-Za-z-]+)*)?$",
|
|
"check_leading_zeros": True,
|
|
},
|
|
)
|
|
|
|
def validate_terraform_version(self, value: str, name: str = "terraform-version") -> bool:
|
|
"""Validate Terraform version format."""
|
|
if not value or value.strip() == "":
|
|
return True
|
|
|
|
if value.strip().lower() == "latest":
|
|
return True
|
|
|
|
clean_version = value.lstrip("v")
|
|
pattern = r"^\d+\.\d+\.\d+(-[\w.-]+)?$"
|
|
|
|
if re.match(pattern, clean_version):
|
|
return True
|
|
|
|
self.add_error(f'Invalid Terraform version format: "{value}" in {name}')
|
|
return False
|
|
|
|
def validate_node_version(self, value: str, name: str = "node-version") -> bool:
|
|
"""Validate Node.js version format."""
|
|
if not value or value.strip() == "":
|
|
return True
|
|
|
|
# Check for special Node.js keywords (case-insensitive)
|
|
value_lower = value.strip().lower()
|
|
node_keywords = ["latest", "lts", "current", "node"]
|
|
if value_lower in node_keywords or value_lower.startswith("lts/"):
|
|
return True
|
|
|
|
# Remove v prefix (case-insensitive)
|
|
clean_version = value
|
|
if clean_version.lower().startswith("v"):
|
|
clean_version = clean_version[1:]
|
|
|
|
pattern = r"^\d+(\.\d+(\.\d+)?)?$"
|
|
|
|
if re.match(pattern, clean_version):
|
|
return True
|
|
|
|
self.add_error(f'Invalid Node.js version format: "{value}" in {name}')
|
|
return False
|
|
|
|
def validate_python_version(self, value: str, name: str = "python-version") -> bool:
|
|
"""Validate Python version format (3.8-3.15)."""
|
|
return self._validate_language_version(
|
|
value,
|
|
name,
|
|
{
|
|
"name": "Python",
|
|
"major_range": 3,
|
|
"minor_range": (8, 15),
|
|
"pattern": self.VERSION_X_Y_Z_PATTERN,
|
|
},
|
|
)
|
|
|
|
def validate_php_version(self, value: str, name: str = "php-version") -> bool:
|
|
"""Validate PHP version format (7.4-9.x)."""
|
|
# First do basic validation
|
|
if not value or value.strip() == "":
|
|
self.add_error(f"{name} cannot be empty")
|
|
return False
|
|
|
|
clean_value = value.strip()
|
|
|
|
# Reject v prefix
|
|
if clean_value.startswith("v"):
|
|
self.add_error(
|
|
f'Invalid PHP version format: "{value}" in {name}. '
|
|
'Version prefix "v" is not allowed',
|
|
)
|
|
return False
|
|
|
|
# Check format
|
|
if not re.match(self.VERSION_X_Y_Z_PATTERN, clean_value):
|
|
self.add_error(
|
|
f'Invalid PHP version format: "{value}" in {name}. Must be X.Y or X.Y.Z format',
|
|
)
|
|
return False
|
|
|
|
# Parse version
|
|
parts = clean_value.split(".")
|
|
major = int(parts[0])
|
|
minor = int(parts[1])
|
|
|
|
# Check major version range (7-9)
|
|
if major < 7 or major > 9:
|
|
self.add_error(
|
|
f'PHP version "{value}" in {name}. Major version should be between 7 and 9',
|
|
)
|
|
return False
|
|
|
|
# Check minor version ranges per major version
|
|
# PHP 7: 7.0-7.4 are the only released versions, but allow higher for testing
|
|
# PHP 8: Allow any minor version for future compatibility
|
|
# PHP 9: Allow any minor for future compatibility
|
|
# Only restrict if the minor version is unreasonably high (>99)
|
|
if minor > 99:
|
|
self.add_error(
|
|
f'PHP version "{value}" in {name}. Minor version {minor} is unreasonably high',
|
|
)
|
|
return False
|
|
|
|
return True
|
|
|
|
def validate_go_version(self, value: str, name: str = "go-version") -> bool:
|
|
"""Validate Go version format (1.18-1.30)."""
|
|
return self._validate_language_version(
|
|
value,
|
|
name,
|
|
{
|
|
"name": "Go",
|
|
"major_range": 1,
|
|
"minor_range": (18, 30),
|
|
"pattern": self.VERSION_X_Y_Z_PATTERN,
|
|
},
|
|
)
|
|
|
|
def _check_version_prefix(
|
|
self, value: str, clean_value: str, name: str, lang_name: str
|
|
) -> bool:
|
|
"""Check if version has invalid 'v' prefix."""
|
|
if clean_value.startswith("v"):
|
|
self.add_error(
|
|
f'Invalid {lang_name} version format: "{value}" in {name}. '
|
|
'Version prefix "v" is not allowed',
|
|
)
|
|
return False
|
|
return True
|
|
|
|
def _check_version_format(self, value: str, clean_value: str, name: str, config: dict) -> bool:
|
|
"""Check if version matches expected format pattern."""
|
|
if not re.match(config["pattern"], clean_value):
|
|
self.add_error(
|
|
f'Invalid {config["name"]} version format: "{value}" in {name}. '
|
|
"Must be X.Y or X.Y.Z format",
|
|
)
|
|
return False
|
|
return True
|
|
|
|
def _check_leading_zeros(self, value: str, parts: list[str], name: str, lang_name: str) -> bool:
|
|
"""Check for invalid leading zeros in version parts."""
|
|
for part in parts:
|
|
if part.startswith("0") and len(part) > 1:
|
|
self.add_error(
|
|
f'Invalid {lang_name} version format: "{value}" in {name}. '
|
|
"Leading zeros are not allowed",
|
|
)
|
|
return False
|
|
return True
|
|
|
|
def _validate_major_version(
|
|
self,
|
|
major: int,
|
|
value: str,
|
|
name: str,
|
|
major_range: int | tuple[int, int] | None,
|
|
lang_name: str,
|
|
) -> bool:
|
|
"""Validate major version against allowed range."""
|
|
if isinstance(major_range, int):
|
|
if major != major_range:
|
|
self.add_error(
|
|
f'{lang_name} version "{value}" in {name}. '
|
|
f"{lang_name} major version should be {major_range}",
|
|
)
|
|
return False
|
|
elif major_range:
|
|
min_major, max_major = major_range
|
|
if major < min_major or major > max_major:
|
|
self.add_error(
|
|
f'{lang_name} version "{value}" in {name}. '
|
|
f"Major version should be between {min_major} and {max_major}",
|
|
)
|
|
return False
|
|
return True
|
|
|
|
def _validate_minor_version(
|
|
self,
|
|
minor: int,
|
|
value: str,
|
|
name: str,
|
|
minor_range: tuple[int, int] | None,
|
|
lang_name: str,
|
|
) -> bool:
|
|
"""Validate minor version against allowed range."""
|
|
if minor_range:
|
|
min_minor, max_minor = minor_range
|
|
if minor < min_minor or minor > max_minor:
|
|
self.add_error(
|
|
f'{lang_name} version "{value}" in {name}. '
|
|
f"Minor version should be between {min_minor} and {max_minor}",
|
|
)
|
|
return False
|
|
return True
|
|
|
|
def _validate_language_version(self, value: str, name: str, config: dict) -> bool:
|
|
"""Consolidated language version validation."""
|
|
if not value or value.strip() == "":
|
|
if config.get("required", False):
|
|
self.add_error(f'Input "{name}" is required and cannot be empty')
|
|
return False
|
|
return True
|
|
|
|
clean_value = value.strip()
|
|
lang_name = config["name"]
|
|
|
|
# Check for invalid 'v' prefix
|
|
if not self._check_version_prefix(value, clean_value, name, lang_name):
|
|
return False
|
|
|
|
# Check version format matches pattern
|
|
if not self._check_version_format(value, clean_value, name, config):
|
|
return False
|
|
|
|
# Parse version components
|
|
parts = clean_value.split(".")
|
|
major = int(parts[0])
|
|
minor = int(parts[1]) if len(parts) > 1 else 0
|
|
|
|
# Check for leading zeros if required
|
|
if config.get("check_leading_zeros") and not self._check_leading_zeros(
|
|
value, parts, name, lang_name
|
|
):
|
|
return False
|
|
|
|
# Validate major version range
|
|
major_valid = self._validate_major_version(
|
|
major, value, name, config.get("major_range"), lang_name
|
|
)
|
|
if not major_valid:
|
|
return False
|
|
|
|
# Validate minor version range
|
|
return self._validate_minor_version(
|
|
minor, value, name, config.get("minor_range"), lang_name
|
|
)
|