mirror of
https://github.com/ivuorinen/actions.git
synced 2026-01-26 11:34:00 +00:00
Ismo Vuorinen
9aa16a8164
* feat: use our own actions in our workflows * fix: add missing inputs to validate-inputs, refactor node * chore: cr comment fixes * fix: update-validators formatting * chore: update validators, add tests, conventions * feat: validate severity with severity_enum * feat: add 10 generic validators to improve input validation coverage Add comprehensive validation system improvements across multiple phases: Phase 2A - Quick Wins: - Add multi_value_enum validator for 2-10 value enumerations - Add exit_code_list validator for Unix/Linux exit codes (0-255) - Refactor coverage_driver to use multi_value_enum Phase 2B - High-Value Validators: - Add key_value_list validator with shell injection prevention - Add path_list validator with path traversal and glob support Quick Wins - Additional Enums: - Add network_mode validator for Docker network modes - Add language_enum validator for language detection - Add framework_mode validator for PHP framework modes - Update boolean pattern to include 'push' Phase 2C - Specialized Validators: - Add json_format validator for JSON syntax validation - Add cache_config validator for Docker BuildKit cache configs Improvements: - All validators include comprehensive security checks - Pattern-based validation with clear error messages - 23 new test methods with edge case coverage - Update special case mappings for 20+ inputs - Fix build-args mapping test expectation Coverage impact: 22 actions now at 100% validation (88% → 92%) Test suite: 762 → 785 tests (+23 tests, all passing) * chore: regenerate rules.yml with improved validator coverage Regenerate validation rules for all actions with new validators: - compress-images: 86% → 100% (+1 input: ignore-paths) - docker-build: 63% → 100% (+4 inputs: cache configs, platform-build-args) - docker-publish: 73% → 100% (+1 input: build-args) - language-version-detect: 67% → 100% (+1 input: language) - php-tests: 89% (fixed framework→framework_mode mapping) - prettier-lint: 86% → 100% (+2 inputs: file-pattern, plugins) - security-scan: 86% (maintained coverage) Overall: 23 of 25 actions now at 100% validation coverage (92%) * fix: address PR #377 review comments - Add | None type annotations to 6 optional parameters (PEP 604) - Standardize injection pattern: remove @# from comma_separated_list validator (@ and # are not shell injection vectors, allows npm scoped packages) - Remove dead code: unused value expression in key_value_list validator - Update tests to reflect injection pattern changes
82 lines
2.5 KiB
YAML
82 lines
2.5 KiB
YAML
---
|
|
# yaml-language-server: $schema=https://json.schemastore.org/github-workflow.json
|
|
name: Action Security
|
|
|
|
on:
|
|
push:
|
|
paths:
|
|
- '**/action.yml'
|
|
- '**/action.yaml'
|
|
pull_request:
|
|
paths:
|
|
- '**/action.yml'
|
|
- '**/action.yaml'
|
|
merge_group:
|
|
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
permissions:
|
|
contents: read
|
|
actions: read
|
|
pull-requests: read
|
|
|
|
jobs:
|
|
analyze:
|
|
name: Analyze Action Security
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 30
|
|
|
|
permissions:
|
|
security-events: write
|
|
statuses: write
|
|
issues: write
|
|
|
|
steps:
|
|
- name: Checkout Repository
|
|
uses: actions/checkout@71cf2267d89c5cb81562390fa70a37fa40b1305e # v6-beta
|
|
with:
|
|
fetch-depth: 0
|
|
|
|
- name: Run Security Scan
|
|
id: security-scan
|
|
uses: ./security-scan
|
|
with:
|
|
gitleaks-license: ${{ secrets.GITLEAKS_LICENSE }}
|
|
token: ${{ secrets.GITHUB_TOKEN }}
|
|
|
|
- name: Notify on Critical Issues
|
|
if: failure() && steps.security-scan.outputs.critical_issues != '0'
|
|
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8.0.0
|
|
with:
|
|
script: |-
|
|
const { repo, owner } = context.repo;
|
|
const critical = '${{ steps.security-scan.outputs.critical_issues }}';
|
|
const total = '${{ steps.security-scan.outputs.total_issues }}';
|
|
|
|
const body = `🚨 Critical security issues found in GitHub Actions
|
|
|
|
${critical} critical security issues (out of ${total} total) were found during the security scan.
|
|
|
|
### Scan Results
|
|
- Actionlint: Completed
|
|
- Trivy: ${{ steps.security-scan.outputs.has_trivy_results == 'true' && 'Completed' || 'Skipped/Failed' }}
|
|
- Gitleaks: ${{ steps.security-scan.outputs.has_gitleaks_results == 'true' && 'Completed' || 'Skipped' }}
|
|
|
|
[View detailed scan results](https://github.com/${owner}/${repo}/actions/runs/${context.runId})
|
|
|
|
Please address these issues immediately.
|
|
|
|
> Note: Some security tools might have been skipped due to missing configurations.
|
|
> Check the workflow run for details.`;
|
|
|
|
await github.rest.issues.create({
|
|
owner,
|
|
repo,
|
|
title: '🚨 Critical Security Issues in Actions',
|
|
body,
|
|
labels: ['security', 'critical', 'actions'],
|
|
assignees: ['ivuorinen']
|
|
});
|