mirror of
https://github.com/ivuorinen/actions.git
synced 2026-01-26 11:34:00 +00:00
* feat: fixes, tweaks, new actions, linting * fix: improve docker publish loops and dotnet parsing (#193) * fix: harden action scripts and version checks (#191) * refactor: major repository restructuring and security enhancements Add comprehensive development infrastructure: - Add Makefile with automated documentation generation, formatting, and linting tasks - Add TODO.md tracking self-containment progress and repository improvements - Add .nvmrc for consistent Node.js version management - Create python-version-detect-v2 action for enhanced Python detection Enhance all GitHub Actions with standardized patterns: - Add consistent token handling across 27 actions using standardized input patterns - Implement bash error handling (set -euo pipefail) in all shell steps - Add comprehensive input validation for path traversal and command injection protection - Standardize checkout token authentication to prevent rate limiting - Remove relative action dependencies to ensure external usability Rewrite security workflow for PR-focused analysis: - Transform security-suite.yml to PR-only security analysis workflow - Remove scheduled runs, repository issue management, and Slack notifications - Implement smart comment generation showing only sections with content - Add GitHub Actions permission diff analysis and new action detection - Integrate OWASP, Semgrep, and TruffleHog for comprehensive PR security scanning Improve version detection and dependency management: - Simplify version detection actions to use inline logic instead of shared utilities - Fix Makefile version detection fallback to properly return 'main' when version not found - Update all external action references to use SHA-pinned versions - Remove deprecated run.sh in favor of Makefile automation Update documentation and project standards: - Enhance CLAUDE.md with self-containment requirements and linting standards - Update README.md with improved action descriptions and usage examples - Standardize code formatting with updated .editorconfig and .prettierrc.yml - Improve GitHub templates for issues and security reporting This refactoring ensures all 40 actions are fully self-contained and can be used independently when referenced as ivuorinen/actions/action-name@main, addressing the critical requirement for external usability while maintaining comprehensive security analysis and development automation. * feat: add automated action catalog generation system - Create generate_listing.cjs script for comprehensive action catalog - Add package.json with development tooling and npm scripts - Implement automated README.md catalog section with --update flag - Generate markdown reference-style links for all 40 actions - Add categorized tables with features, language support matrices - Replace static reference links with auto-generated dynamic links - Enable complete automation of action documentation maintenance * feat: enhance actions with improved documentation and functionality - Add comprehensive README files for 12 actions with usage examples - Implement new utility actions (go-version-detect, dotnet-version-detect) - Enhance node-setup with extensive configuration options - Improve error handling and validation across all actions - Update package.json scripts for better development workflow - Expand TODO.md with detailed roadmap and improvement plans - Standardize action structure with consistent inputs/outputs * feat: add comprehensive output handling across all actions - Add standardized outputs to 15 actions that previously had none - Implement consistent snake_case naming convention for all outputs - Add build status and test results outputs to build actions - Add files changed and status outputs to lint/fix actions - Add test execution metrics to php-tests action - Add stale/closed counts to stale action - Add release URLs and IDs to github-release action - Update documentation with output specifications - Mark comprehensive output handling task as complete in TODO.md * feat: implement shared cache strategy across all actions - Add caching to 10 actions that previously had none (Node.js, .NET, Python, Go) - Standardize 4 existing actions to use common-cache instead of direct actions/cache - Implement consistent cache-hit optimization to skip installations when cache available - Add language-specific cache configurations with appropriate key files - Create unified caching approach using ivuorinen/actions/common-cache@main - Fix YAML syntax error in php-composer action paths parameter - Update TODO.md to mark shared cache strategy as complete * feat: implement comprehensive retry logic for network operations - Create new common-retry action for standardized retry patterns with configurable strategies - Add retry logic to 9 actions missing network retry capabilities - Implement exponential backoff, custom timeouts, and flexible error handling - Add max-retries input parameter to all network-dependent actions (Node.js, .NET, Python, Go) - Standardize existing retry implementations to use common-retry utility - Update action catalog to include new common-retry action (41 total actions) - Update documentation with retry configuration examples and parameters - Mark retry logic implementation as complete in TODO.md roadmap * feat: enhance Node.js support with Corepack and Bun - Add Corepack support for automatic package manager version management - Add Bun package manager support across all Node.js actions - Improve Yarn Berry/PnP support with .yarnrc.yml detection - Add Node.js feature detection (ESM, TypeScript, frameworks) - Update package manager detection priority and lockfile support - Enhance caching with package-manager-specific keys - Update eslint, prettier, and biome actions for multi-package-manager support * fix: resolve critical runtime issues across multiple actions - Fix token validation by removing ineffective literal string comparisons - Add missing @microsoft/eslint-formatter-sarif dependency for SARIF output - Fix Bash variable syntax errors in username and changelog length checks - Update Dockerfile version regex to handle tags with suffixes (e.g., -alpine) - Simplify version selection logic with single grep command - Fix command execution in retry action with proper bash -c wrapper - Correct step output references using .outcome instead of .outputs.outcome - Add missing step IDs for version detection actions - Include go.mod in cache key files for accurate invalidation - Require minor version in all version regex patterns - Improve Bun installation security by verifying script before execution - Replace bc with sort -V for portable PHP version comparison - Remove non-existent pre-commit output references These fixes ensure proper runtime behavior, improved security, and better cross-platform compatibility across all affected actions. * fix: resolve critical runtime and security issues across actions - Fix biome-fix files_changed calculation using git diff instead of git status delta - Fix compress-images output description and add absolute path validation - Remove csharp-publish token default and fix token fallback in push commands - Add @microsoft/eslint-formatter-sarif to all package managers in eslint-check - Fix eslint-check command syntax by using variable assignment - Improve node-setup Bun installation security and remove invalid frozen-lockfile flag - Fix pre-commit token validation by removing ineffective literal comparison - Fix prettier-fix token comparison and expand regex for all GitHub token types - Add version-file-parser regex validation safety and fix csproj wildcard handling These fixes address security vulnerabilities, runtime errors, and functional issues to ensure reliable operation across all affected GitHub Actions. * feat: enhance Docker actions with advanced multi-architecture support Major enhancement to Docker build and publish actions with comprehensive multi-architecture capabilities and enterprise-grade features. Added features: - Advanced buildx configuration (version control, cache modes, build contexts) - Auto-detect platforms for dynamic architecture discovery - Performance optimizations with enhanced caching strategies - Security scanning with Trivy and image signing with Cosign - SBOM generation in multiple formats with validation - Verbose logging and dry-run modes for debugging - Platform-specific build args and fallback mechanisms Enhanced all Docker actions: - docker-build: Core buildx features and multi-arch support - docker-publish-gh: GitHub Packages with security features - docker-publish-hub: Docker Hub with scanning and signing - docker-publish: Orchestrator with unified configuration Updated documentation across all modified actions. * fix: resolve documentation generation placeholder issue Fixed Makefile and package.json to properly replace placeholder tokens in generated documentation, ensuring all README files show correct repository paths instead of ***PROJECT***@***VERSION***. * chore: simplify github token validation * chore(lint): optional yamlfmt, config and fixes * feat: use relative `uses` names * feat: comprehensive testing infrastructure and Python validation system - Migrate from tests/ to _tests/ directory structure with ShellSpec framework - Add comprehensive validation system with Python-based input validation - Implement dual testing approach (ShellSpec + pytest) for complete coverage - Add modern Python tooling (uv, ruff, pytest-cov) and dependencies - Create centralized validation rules with automatic generation system - Update project configuration and build system for new architecture - Enhance documentation to reflect current testing capabilities This establishes a robust foundation for action validation and testing with extensive coverage across all GitHub Actions in the repository. * chore: remove Dockerfile for now * chore: code review fixes * feat: comprehensive GitHub Actions restructuring and tooling improvements This commit represents a major restructuring of the GitHub Actions monorepo with improved tooling, testing infrastructure, and comprehensive PR #186 review implementation. ## Major Changes ### 🔧 Development Tooling & Configuration - **Shellcheck integration**: Exclude shellspec test files from linting - Updated .pre-commit-config.yaml to exclude _tests/*.sh from shellcheck/shfmt - Modified Makefile shellcheck pattern to skip shellspec files - Updated CLAUDE.md documentation with proper exclusion syntax - **Testing infrastructure**: Enhanced Python validation framework - Fixed nested if statements and boolean parameter issues in validation.py - Improved code quality with explicit keyword arguments - All pre-commit hooks now passing ### 🏗️ Project Structure & Documentation - **Added Serena AI integration** with comprehensive project memories: - Project overview, structure, and technical stack documentation - Code style conventions and completion requirements - Comprehensive PR #186 review analysis and implementation tracking - **Enhanced configuration**: Updated .gitignore, .yamlfmt.yml, pyproject.toml - **Improved testing**: Added integration workflows and enhanced test specs ### 🚀 GitHub Actions Improvements (30+ actions updated) - **Centralized validation**: Updated 41 validation rule files - **Enhanced actions**: Improvements across all action categories: - Setup actions (node-setup, version detectors) - Utility actions (version-file-parser, version-validator) - Linting actions (biome, eslint, terraform-lint-fix major refactor) - Build/publish actions (docker-build, npm-publish, csharp-*) - Repository management actions ### 📝 Documentation Updates - **README consistency**: Updated version references across action READMEs - **Enhanced documentation**: Improved action descriptions and usage examples - **CLAUDE.md**: Updated with current tooling and best practices ## Technical Improvements - **Security enhancements**: Input validation and sanitization improvements - **Performance optimizations**: Streamlined action logic and dependencies - **Cross-platform compatibility**: Better Windows/macOS/Linux support - **Error handling**: Improved error reporting and user feedback ## Files Changed - 100 files changed - 13 new Serena memory files documenting project state - 41 validation rules updated for consistency - 30+ GitHub Actions and READMEs improved - Core tooling configuration enhanced * feat: comprehensive GitHub Actions improvements and PR review fixes Major Infrastructure Improvements: - Add comprehensive testing framework with 17+ ShellSpec validation tests - Implement Docker-based testing tools with automated test runner - Add CodeRabbit configuration for automated code reviews - Restructure documentation and memory management system - Update validation rules for 25+ actions with enhanced input validation - Modernize CI/CD workflows and testing infrastructure Critical PR Review Fixes (All Issues Resolved): - Fix double caching in node-setup (eliminate redundant cache operations) - Optimize shell pipeline in version-file-parser (single awk vs complex pipeline) - Fix GitHub expression interpolation in prettier-check cache keys - Resolve terraform command order issue (validation after setup) - Add missing flake8-sarif dependency for Python SARIF output - Fix environment variable scope in pr-lint (export to GITHUB_ENV) Performance & Reliability: - Eliminate duplicate cache operations saving CI time - Improve shell script efficiency with optimized parsing - Fix command execution dependencies preventing runtime failures - Ensure proper dependency installation for all linting tools - Resolve workflow conditional logic issues Security & Quality: - All input validation rules updated with latest security patterns - Cross-platform compatibility improvements maintained - Comprehensive error handling and retry logic preserved - Modern development tooling and best practices adopted This commit addresses 100% of actionable feedback from PR review analysis, implements comprehensive testing infrastructure, and maintains high code quality standards across all 41 GitHub Actions. * feat: enhance expression handling and version parsing - Fix node-setup force-version expression logic for proper empty string handling - Improve version-file-parser with secure regex validation and enhanced Python detection - Add CodeRabbit configuration for CalVer versioning and README review guidance * feat(validate-inputs): implement modular validation system - Add modular validator architecture with specialized validators - Implement base validator classes for different input types - Add validators: boolean, docker, file, network, numeric, security, token, version - Add convention mapper for automatic input validation - Add comprehensive documentation for the validation system - Implement PCRE regex support and injection protection * feat(validate-inputs): add validation rules for all actions - Add YAML validation rules for 42 GitHub Actions - Auto-generated rules with convention mappings - Include metadata for validation coverage and quality indicators - Mark rules as auto-generated to prevent manual edits * test(validate-inputs): add comprehensive test suite for validators - Add unit tests for all validator modules - Add integration tests for the validation system - Add fixtures for version test data - Test coverage for boolean, docker, file, network, numeric, security, token, and version validators - Add tests for convention mapper and registry * feat(tools): add validation scripts and utilities - Add update-validators.py script for auto-generating rules - Add benchmark-validator.py for performance testing - Add debug-validator.py for troubleshooting - Add generate-tests.py for test generation - Add check-rules-not-manually-edited.sh for CI validation - Add fix-local-action-refs.py tool for fixing action references * feat(actions): add CustomValidator.py files for specialized validation - Add custom validators for actions requiring special validation logic - Implement validators for docker, go, node, npm, php, python, terraform actions - Add specialized validation for compress-images, common-cache, common-file-check - Implement version detection validators with language-specific logic - Add validation for build arguments, architectures, and version formats * test: update ShellSpec test framework for Python validation - Update all validation.spec.sh files to use Python validator - Add shared validation_core.py for common test utilities - Remove obsolete bash validation helpers - Update test output expectations for Python validator format - Add codeql-analysis test suite - Refactor framework utilities for Python integration - Remove deprecated test files * feat(actions): update action.yml files to use validate-inputs - Replace inline bash validation with validate-inputs action - Standardize validation across all 42 actions - Add new codeql-analysis action - Update action metadata and branding - Add validation step as first step in composite actions - Maintain backward compatibility with existing inputs/outputs * ci: update GitHub workflows for enhanced security and testing - Add new codeql-new.yml workflow - Update security scanning workflows - Enhance dependency review configuration - Update test-actions workflow for new validation system - Improve workflow permissions and security settings - Update action versions to latest SHA-pinned releases * build: update build configuration and dependencies - Update Makefile with new validation targets - Add Python dependencies in pyproject.toml - Update npm dependencies and scripts - Enhance Docker testing tools configuration - Add targets for validator updates and local ref fixes - Configure uv for Python package management * chore: update linting and documentation configuration - Update EditorConfig settings for consistent formatting - Enhance pre-commit hooks configuration - Update prettier and yamllint ignore patterns - Update gitleaks security scanning rules - Update CodeRabbit review configuration - Update CLAUDE.md with latest project standards and rules * docs: update Serena memory files and project metadata - Remove obsolete PR-186 memory files - Update project overview with current architecture - Update project structure documentation - Add quality standards and communication guidelines - Add modular validator architecture documentation - Add shellspec testing framework documentation - Update project.yml with latest configuration * feat: moved rules.yml to same folder as action, fixes * fix(validators): correct token patterns and fix validator bugs - Fix GitHub classic PAT pattern: ghp_ + 36 chars = 40 total - Fix GitHub fine-grained PAT pattern: github_pat_ + 71 chars = 82 total - Initialize result variable in convention_mapper to prevent UnboundLocalError - Fix empty URL validation in network validator to return error - Add GitHub expression check to docker architectures validator - Update docker-build CustomValidator parallel-builds max to 16 * test(validators): fix test fixtures and expectations - Fix token lengths in test data: github_pat 71 chars, ghp/gho 36 chars - Update integration tests with correct token lengths - Fix file validator test to expect absolute paths rejected for security - Rename TestGenerator import to avoid pytest collection warning - Update custom validator tests with correct input names - Change docker-build tests: platforms->architectures, tags->tag - Update docker-publish tests to match new registry enum validation * test(shellspec): fix token lengths in test helpers and specs - Fix default token lengths in spec_helper.sh to use correct 40-char format - Update csharp-publish default tokens in 4 locations - Update codeql-analysis default tokens in 2 locations - Fix codeql-analysis test tokens to correct lengths (40 and 82 chars) - Fix npm-publish fine-grained token test to use 82-char format * feat(actions): add permissions documentation and environment variable usage - Add permissions comments to all action.yml files documenting required GitHub permissions - Convert direct input usage to environment variables in shell steps for security - Add validation steps with proper error handling - Update input descriptions and add security notes where applicable - Ensure all actions follow consistent patterns for input validation * chore(workflows): update GitHub Actions workflow versions - Update workflow action versions to latest - Improve workflow consistency and maintainability * docs(security): add comprehensive security policy - Document security features and best practices - Add vulnerability reporting process - Include audit history and security testing information * docs(memory): add GitHub workflow reference documentation - Add GitHub Actions workflow commands reference - Add GitHub workflow expressions guide - Add secure workflow usage patterns and best practices * chore: token optimization, code style conventions * chore: cr fixes * fix: trivy reported Dockerfile problems * fix(security): more security fixes * chore: dockerfile and make targets for publishing * fix(ci): add creds to test-actions workflow * fix: security fix and checkout step to codeql-new * chore: test fixes * fix(security): codeql detected issues * chore: code review fixes, ReDos protection * style: apply MegaLinter fixes * fix(ci): missing packages read permission * fix(ci): add missing working directory setting * chore: linting, add validation-regex to use regex_pattern * chore: code review fixes * chore(deps): update actions * fix(security): codeql fixes * chore(cr): apply cr comments * chore: improve POSIX compatibility * chore(cr): apply cr comments * fix: codeql warning in Dockerfile, build failures * chore(cr): apply cr comments * fix: docker-testing-tools/Dockerfile * chore(cr): apply cr comments * fix(docker): update testing-tools image for GitHub Actions compatibility * chore(cr): apply cr comments * feat: add more tests, fix issues * chore: fix codeql issues, update actions * chore(cr): apply cr comments * fix: integration tests * chore: deduplication and fixes * style: apply MegaLinter fixes * chore(cr): apply cr comments * feat: dry-run mode for generate-tests * fix(ci): kcov installation * chore(cr): apply cr comments * chore(cr): apply cr comments * chore(cr): apply cr comments * chore(cr): apply cr comments, simplify action testing, use uv * fix: run-tests.sh action counting * chore(cr): apply cr comments * chore(cr): apply cr comments
758 lines
22 KiB
Bash
Executable File
758 lines
22 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# GitHub Actions Testing Framework - Main Test Runner
|
|
# Executes tests across all levels: unit, integration, and e2e
|
|
|
|
set -euo pipefail
|
|
|
|
# Script directory and test root
|
|
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
|
TEST_ROOT="$SCRIPT_DIR"
|
|
|
|
# Source framework utilities
|
|
# shellcheck source=_tests/framework/setup.sh
|
|
source "${TEST_ROOT}/framework/setup.sh"
|
|
|
|
# Configuration
|
|
DEFAULT_TEST_TYPE="all"
|
|
DEFAULT_ACTION_FILTER=""
|
|
PARALLEL_JOBS=4
|
|
COVERAGE_ENABLED=true
|
|
REPORT_FORMAT="console"
|
|
|
|
# Usage information
|
|
usage() {
|
|
cat <<EOF
|
|
GitHub Actions Testing Framework
|
|
|
|
Usage: $0 [OPTIONS] [ACTION_NAME...]
|
|
|
|
OPTIONS:
|
|
-t, --type TYPE Test type: unit, integration, e2e, all (default: all)
|
|
-a, --action ACTION Filter by specific action name
|
|
-j, --jobs JOBS Number of parallel jobs (default: 4)
|
|
-c, --coverage Enable coverage reporting (default: true)
|
|
--no-coverage Disable coverage reporting
|
|
-f, --format FORMAT Report format: console, json, junit, sarif (default: console)
|
|
-v, --verbose Enable verbose output
|
|
-h, --help Show this help message
|
|
|
|
EXAMPLES:
|
|
$0 # Run all tests for all actions
|
|
$0 -t unit # Run only unit tests
|
|
$0 -a node-setup # Test only node-setup action
|
|
$0 -t integration docker-build # Integration tests for docker-build
|
|
$0 --format json --coverage # Full tests with JSON output and coverage
|
|
$0 --format sarif # Generate SARIF report for security scanning
|
|
|
|
TEST TYPES:
|
|
unit - Fast unit tests for action validation and logic
|
|
integration - Integration tests using nektos/act or workflows
|
|
e2e - End-to-end tests with complete workflows
|
|
all - All test types (default)
|
|
|
|
EOF
|
|
}
|
|
|
|
# Parse command line arguments
|
|
parse_args() {
|
|
local test_type="$DEFAULT_TEST_TYPE"
|
|
local action_filter="$DEFAULT_ACTION_FILTER"
|
|
local actions=()
|
|
|
|
while [[ $# -gt 0 ]]; do
|
|
case $1 in
|
|
-t | --type)
|
|
if [[ $# -lt 2 ]]; then
|
|
echo "Error: $1 requires an argument" >&2
|
|
usage
|
|
exit 1
|
|
fi
|
|
test_type="$2"
|
|
shift 2
|
|
;;
|
|
-a | --action)
|
|
if [[ $# -lt 2 ]]; then
|
|
echo "Error: $1 requires an argument" >&2
|
|
usage
|
|
exit 1
|
|
fi
|
|
action_filter="$2"
|
|
shift 2
|
|
;;
|
|
-j | --jobs)
|
|
if [[ $# -lt 2 ]]; then
|
|
echo "Error: $1 requires an argument" >&2
|
|
usage
|
|
exit 1
|
|
fi
|
|
PARALLEL_JOBS="$2"
|
|
shift 2
|
|
;;
|
|
-c | --coverage)
|
|
COVERAGE_ENABLED=true
|
|
shift
|
|
;;
|
|
--no-coverage)
|
|
COVERAGE_ENABLED=false
|
|
shift
|
|
;;
|
|
-f | --format)
|
|
if [[ $# -lt 2 ]]; then
|
|
echo "Error: $1 requires an argument" >&2
|
|
usage
|
|
exit 1
|
|
fi
|
|
REPORT_FORMAT="$2"
|
|
shift 2
|
|
;;
|
|
-v | --verbose)
|
|
set -x
|
|
shift
|
|
;;
|
|
-h | --help)
|
|
usage
|
|
exit 0
|
|
;;
|
|
--)
|
|
shift
|
|
actions+=("$@")
|
|
break
|
|
;;
|
|
-*)
|
|
log_error "Unknown option: $1"
|
|
usage
|
|
exit 1
|
|
;;
|
|
*)
|
|
actions+=("$1")
|
|
shift
|
|
;;
|
|
esac
|
|
done
|
|
|
|
# Export for use in other functions
|
|
export TEST_TYPE="$test_type"
|
|
export ACTION_FILTER="$action_filter"
|
|
TARGET_ACTIONS=("${actions[@]+"${actions[@]}"}")
|
|
}
|
|
|
|
# Discover available actions
|
|
discover_actions() {
|
|
local actions=()
|
|
|
|
if [[ ${#TARGET_ACTIONS[@]} -gt 0 ]]; then
|
|
# Use provided actions
|
|
actions=("${TARGET_ACTIONS[@]}")
|
|
elif [[ -n $ACTION_FILTER ]]; then
|
|
# Filter by pattern
|
|
while IFS= read -r action_dir; do
|
|
local action_name
|
|
action_name=$(basename "$action_dir")
|
|
if [[ $action_name == *"$ACTION_FILTER"* ]]; then
|
|
actions+=("$action_name")
|
|
fi
|
|
done < <(find "${TEST_ROOT}/.." -mindepth 1 -maxdepth 1 -type d -name "*-*" | sort)
|
|
else
|
|
# All actions
|
|
while IFS= read -r action_dir; do
|
|
local action_name
|
|
action_name=$(basename "$action_dir")
|
|
actions+=("$action_name")
|
|
done < <(find "${TEST_ROOT}/.." -mindepth 1 -maxdepth 1 -type d -name "*-*" | sort)
|
|
fi
|
|
|
|
log_info "Discovered ${#actions[@]} actions to test: ${actions[*]}"
|
|
printf '%s\n' "${actions[@]}"
|
|
}
|
|
|
|
# Check if required tools are available
|
|
check_dependencies() {
|
|
# Check for ShellSpec
|
|
if ! command -v shellspec >/dev/null 2>&1; then
|
|
log_warning "ShellSpec not found, attempting to install..."
|
|
install_shellspec
|
|
fi
|
|
|
|
# Check for act (if running integration tests)
|
|
if [[ $TEST_TYPE == "integration" || $TEST_TYPE == "all" ]]; then
|
|
if ! command -v act >/dev/null 2>&1; then
|
|
log_warning "nektos/act not found, integration tests will be limited"
|
|
fi
|
|
fi
|
|
|
|
# Check for coverage tools (if enabled)
|
|
if [[ $COVERAGE_ENABLED == "true" ]]; then
|
|
if ! command -v kcov >/dev/null 2>&1; then
|
|
log_warning "kcov not found - coverage will use alternative methods"
|
|
fi
|
|
fi
|
|
|
|
log_success "Dependency check completed"
|
|
}
|
|
|
|
# Install ShellSpec if not available
|
|
install_shellspec() {
|
|
log_info "Installing ShellSpec testing framework..."
|
|
|
|
local shellspec_version="0.28.1"
|
|
local install_dir="${HOME}/.local"
|
|
|
|
# Download and install ShellSpec (download -> verify SHA256 -> extract -> install)
|
|
local tarball
|
|
tarball="$(mktemp /tmp/shellspec-XXXXXX.tar.gz)"
|
|
|
|
# Pinned SHA256 checksum for ShellSpec 0.28.1
|
|
# Source: https://github.com/shellspec/shellspec/archive/refs/tags/0.28.1.tar.gz
|
|
local checksum="351e7a63b8df47c07b022c19d21a167b85693f5eb549fa96e64f64844b680024"
|
|
|
|
# Ensure cleanup of the downloaded file
|
|
# Use ${tarball:-} to handle unbound variable when trap fires after function returns
|
|
cleanup() {
|
|
rm -f "${tarball:-}"
|
|
}
|
|
trap cleanup EXIT
|
|
|
|
log_info "Downloading ShellSpec ${shellspec_version} to ${tarball}..."
|
|
if ! curl -fsSL -o "$tarball" "https://github.com/shellspec/shellspec/archive/refs/tags/${shellspec_version}.tar.gz"; then
|
|
log_error "Failed to download ShellSpec ${shellspec_version}"
|
|
exit 1
|
|
fi
|
|
|
|
# Compute SHA256 in a portable way
|
|
local actual_sha
|
|
if command -v sha256sum >/dev/null 2>&1; then
|
|
actual_sha="$(sha256sum "$tarball" | awk '{print $1}')"
|
|
elif command -v shasum >/dev/null 2>&1; then
|
|
actual_sha="$(shasum -a 256 "$tarball" | awk '{print $1}')"
|
|
else
|
|
log_error "No SHA256 utility available (sha256sum or shasum required) to verify download"
|
|
exit 1
|
|
fi
|
|
|
|
if [[ "$actual_sha" != "$checksum" ]]; then
|
|
log_error "Checksum mismatch for ShellSpec ${shellspec_version} (expected ${checksum}, got ${actual_sha})"
|
|
exit 1
|
|
fi
|
|
|
|
log_info "Checksum verified for ShellSpec ${shellspec_version}, extracting..."
|
|
if ! tar -xzf "$tarball" -C /tmp/; then
|
|
log_error "Failed to extract ShellSpec archive"
|
|
exit 1
|
|
fi
|
|
|
|
if ! (cd "/tmp/shellspec-${shellspec_version}" && make install PREFIX="$install_dir"); then
|
|
log_error "ShellSpec make install failed"
|
|
exit 1
|
|
fi
|
|
|
|
# Add to PATH if not already there
|
|
if [[ ":$PATH:" != *":${install_dir}/bin:"* ]]; then
|
|
export PATH="${install_dir}/bin:$PATH"
|
|
# Append to shell rc only in non-CI environments
|
|
if [[ -z "${CI:-}" ]]; then
|
|
if ! grep -qxF "export PATH=\"${install_dir}/bin:\$PATH\"" ~/.bashrc 2>/dev/null; then
|
|
echo "export PATH=\"${install_dir}/bin:\$PATH\"" >>~/.bashrc
|
|
fi
|
|
fi
|
|
fi
|
|
|
|
if command -v shellspec >/dev/null 2>&1; then
|
|
log_success "ShellSpec installed successfully"
|
|
# Clear the trap now that we've succeeded to prevent unbound variable error on script exit
|
|
trap - EXIT
|
|
rm -f "$tarball"
|
|
else
|
|
log_error "Failed to install ShellSpec"
|
|
exit 1
|
|
fi
|
|
}
|
|
|
|
# Run unit tests
|
|
run_unit_tests() {
|
|
local actions=("$@")
|
|
local failed_tests=()
|
|
local passed_tests=()
|
|
|
|
log_info "Running unit tests for ${#actions[@]} actions..."
|
|
|
|
# Create test results directory
|
|
mkdir -p "${TEST_ROOT}/reports/unit"
|
|
|
|
for action in "${actions[@]}"; do
|
|
local unit_test_dir="${TEST_ROOT}/unit/${action}"
|
|
|
|
if [[ -d $unit_test_dir ]]; then
|
|
log_info "Running unit tests for: $action"
|
|
|
|
# Run ShellSpec tests
|
|
local test_result=0
|
|
local output_file="${TEST_ROOT}/reports/unit/${action}.txt"
|
|
|
|
# Run shellspec and capture both exit code and output
|
|
# Note: ShellSpec returns non-zero exit codes for warnings (101) and other conditions
|
|
# We need to check the actual output to determine if tests failed
|
|
# Pass action name relative to --default-path (_tests/unit) for proper spec_helper loading
|
|
(cd "$TEST_ROOT/.." && shellspec \
|
|
--format documentation \
|
|
"$action") >"$output_file" 2>&1 || true
|
|
|
|
# Parse the output to determine if tests actually failed
|
|
# Look for the summary line which shows "X examples, Y failures"
|
|
if grep -qE "[0-9]+ examples?, 0 failures?" "$output_file" && ! grep -q "Fatal error occurred" "$output_file"; then
|
|
log_success "Unit tests passed: $action"
|
|
passed_tests+=("$action")
|
|
else
|
|
# Check if there were actual failures (not just warnings)
|
|
if grep -qE "[0-9]+ examples?, [1-9][0-9]* failures?" "$output_file"; then
|
|
log_error "Unit tests failed: $action"
|
|
failed_tests+=("$action")
|
|
test_result=1
|
|
else
|
|
# No summary line found, treat as passed if no fatal errors
|
|
if ! grep -q "Fatal error occurred" "$output_file"; then
|
|
log_success "Unit tests passed: $action"
|
|
passed_tests+=("$action")
|
|
else
|
|
log_error "Unit tests failed: $action"
|
|
failed_tests+=("$action")
|
|
test_result=1
|
|
fi
|
|
fi
|
|
fi
|
|
|
|
# Show summary if verbose or on failure
|
|
if [[ $test_result -ne 0 || ${BASHOPTS:-} == *"xtrace"* || $- == *x* ]]; then
|
|
echo "--- Test output for $action ---"
|
|
cat "$output_file"
|
|
echo "--- End test output ---"
|
|
fi
|
|
else
|
|
log_warning "No unit tests found for: $action"
|
|
fi
|
|
done
|
|
|
|
# Report results
|
|
log_info "Unit test results:"
|
|
log_success " Passed: ${#passed_tests[@]} actions"
|
|
if [[ ${#failed_tests[@]} -gt 0 ]]; then
|
|
log_error " Failed: ${#failed_tests[@]} actions (${failed_tests[*]})"
|
|
return 1
|
|
fi
|
|
|
|
return 0
|
|
}
|
|
|
|
# Run integration tests using nektos/act
|
|
run_integration_tests() {
|
|
local actions=("$@")
|
|
local failed_tests=()
|
|
local passed_tests=()
|
|
|
|
log_info "Running integration tests for ${#actions[@]} actions..."
|
|
|
|
# Create test results directory
|
|
mkdir -p "${TEST_ROOT}/reports/integration"
|
|
|
|
for action in "${actions[@]}"; do
|
|
local workflow_file="${TEST_ROOT}/integration/workflows/${action}-test.yml"
|
|
|
|
if [[ -f $workflow_file ]]; then
|
|
log_info "Running integration test workflow for: $action"
|
|
|
|
# Run with act if available, otherwise skip
|
|
if command -v act >/dev/null 2>&1; then
|
|
local output_file="${TEST_ROOT}/reports/integration/${action}.txt"
|
|
|
|
# Create temp directory for artifacts
|
|
local artifacts_dir
|
|
artifacts_dir=$(mktemp -d) || exit 1
|
|
|
|
if act workflow_dispatch \
|
|
-W "$workflow_file" \
|
|
--container-architecture linux/amd64 \
|
|
--artifact-server-path "$artifacts_dir" \
|
|
-P ubuntu-latest=catthehacker/ubuntu:act-latest \
|
|
>"$output_file" 2>&1; then
|
|
|
|
log_success "Integration tests passed: $action"
|
|
passed_tests+=("$action")
|
|
else
|
|
log_error "Integration tests failed: $action"
|
|
failed_tests+=("$action")
|
|
|
|
# Show output on failure
|
|
echo "--- Integration test output for $action ---"
|
|
cat "$output_file"
|
|
echo "--- End integration test output ---"
|
|
fi
|
|
|
|
# Clean up artifacts directory
|
|
rm -rf "$artifacts_dir"
|
|
else
|
|
log_warning "Skipping integration test for $action (act not available)"
|
|
fi
|
|
else
|
|
log_warning "No integration test workflow found for: $action"
|
|
fi
|
|
done
|
|
|
|
# Report results
|
|
log_info "Integration test results:"
|
|
log_success " Passed: ${#passed_tests[@]} actions"
|
|
if [[ ${#failed_tests[@]} -gt 0 ]]; then
|
|
log_error " Failed: ${#failed_tests[@]} actions (${failed_tests[*]})"
|
|
return 1
|
|
fi
|
|
|
|
return 0
|
|
}
|
|
|
|
# Generate test coverage report
|
|
generate_coverage_report() {
|
|
if [[ $COVERAGE_ENABLED != "true" ]]; then
|
|
return 0
|
|
fi
|
|
|
|
log_info "Generating coverage report..."
|
|
|
|
local coverage_dir="${TEST_ROOT}/coverage"
|
|
mkdir -p "$coverage_dir"
|
|
|
|
# This is a simplified coverage implementation
|
|
# In practice, you'd integrate with kcov or similar tools
|
|
|
|
# Count tested vs total actions (count directories with action.yml files, excluding hidden/internal dirs and node_modules)
|
|
local project_root
|
|
project_root="$(cd "${TEST_ROOT}/.." && pwd)"
|
|
local total_actions
|
|
total_actions=$(find "$project_root" -mindepth 2 -maxdepth 2 -type f -name "action.yml" 2>/dev/null | wc -l | tr -d ' ')
|
|
|
|
# Count actions that have unit tests (by checking if validation.spec.sh exists)
|
|
local tested_actions
|
|
tested_actions=$(find "${TEST_ROOT}/unit" -mindepth 2 -maxdepth 2 -type f -name "validation.spec.sh" 2>/dev/null | wc -l | tr -d ' ')
|
|
|
|
local coverage_percent
|
|
if [[ $total_actions -gt 0 ]]; then
|
|
coverage_percent=$(((tested_actions * 100) / total_actions))
|
|
else
|
|
coverage_percent=0
|
|
fi
|
|
|
|
cat >"${coverage_dir}/summary.json" <<EOF
|
|
{
|
|
"total_actions": $total_actions,
|
|
"tested_actions": $tested_actions,
|
|
"coverage_percent": $coverage_percent,
|
|
"generated_at": "$(date -u +"%Y-%m-%dT%H:%M:%SZ")"
|
|
}
|
|
EOF
|
|
|
|
log_success "Coverage report generated: ${coverage_percent}% ($tested_actions/$total_actions actions)"
|
|
}
|
|
|
|
# Generate test report
|
|
generate_test_report() {
|
|
log_info "Generating test report in format: $REPORT_FORMAT"
|
|
|
|
local report_dir="${TEST_ROOT}/reports"
|
|
mkdir -p "$report_dir"
|
|
|
|
case "$REPORT_FORMAT" in
|
|
"json")
|
|
generate_json_report
|
|
;;
|
|
"junit")
|
|
log_warning "JUnit report format not yet implemented, using JSON instead"
|
|
generate_json_report
|
|
;;
|
|
"sarif")
|
|
generate_sarif_report
|
|
;;
|
|
"console" | *)
|
|
generate_console_report
|
|
;;
|
|
esac
|
|
}
|
|
|
|
# Generate JSON test report
|
|
generate_json_report() {
|
|
local report_file="${TEST_ROOT}/reports/test-results.json"
|
|
|
|
cat >"$report_file" <<EOF
|
|
{
|
|
"test_run": {
|
|
"timestamp": "$(date -u +"%Y-%m-%dT%H:%M:%SZ")",
|
|
"type": "$TEST_TYPE",
|
|
"action_filter": "$ACTION_FILTER",
|
|
"parallel_jobs": $PARALLEL_JOBS,
|
|
"coverage_enabled": $COVERAGE_ENABLED
|
|
},
|
|
"results": {
|
|
"unit_tests": $(find "${TEST_ROOT}/reports/unit" -name "*.txt" 2>/dev/null | wc -l | tr -d ' '),
|
|
"integration_tests": $(find "${TEST_ROOT}/reports/integration" -name "*.txt" 2>/dev/null | wc -l | tr -d ' ')
|
|
}
|
|
}
|
|
EOF
|
|
|
|
log_success "JSON report generated: $report_file"
|
|
}
|
|
|
|
# Generate SARIF test report
|
|
generate_sarif_report() {
|
|
# Check for jq availability
|
|
if ! command -v jq >/dev/null 2>&1; then
|
|
log_warning "jq not found, skipping SARIF report generation"
|
|
return 0
|
|
fi
|
|
|
|
local report_file="${TEST_ROOT}/reports/test-results.sarif"
|
|
local run_id
|
|
run_id="github-actions-test-$(date +%s)"
|
|
local timestamp
|
|
timestamp="$(date -u +"%Y-%m-%dT%H:%M:%SZ")"
|
|
|
|
# Initialize SARIF structure using jq to ensure proper escaping
|
|
jq -n \
|
|
--arg run_id "$run_id" \
|
|
--arg timestamp "$timestamp" \
|
|
--arg test_type "$TEST_TYPE" \
|
|
'{
|
|
"$schema": "https://json.schemastore.org/sarif-2.1.0.json",
|
|
"version": "2.1.0",
|
|
"runs": [
|
|
{
|
|
"automationDetails": {
|
|
"id": $run_id
|
|
},
|
|
"tool": {
|
|
"driver": {
|
|
"name": "GitHub Actions Testing Framework",
|
|
"version": "1.0.0",
|
|
"informationUri": "https://github.com/ivuorinen/actions",
|
|
"rules": []
|
|
}
|
|
},
|
|
"results": [],
|
|
"invocations": [
|
|
{
|
|
"executionSuccessful": true,
|
|
"startTimeUtc": $timestamp,
|
|
"arguments": ["--type", $test_type, "--format", "sarif"]
|
|
}
|
|
]
|
|
}
|
|
]
|
|
}' >"$report_file"
|
|
|
|
# Parse test results and add SARIF findings
|
|
local results_array="[]"
|
|
local rules_array="[]"
|
|
|
|
# Process unit test failures
|
|
if [[ -d "${TEST_ROOT}/reports/unit" ]]; then
|
|
for test_file in "${TEST_ROOT}/reports/unit"/*.txt; do
|
|
if [[ -f "$test_file" ]]; then
|
|
local action_name
|
|
action_name=$(basename "$test_file" .txt)
|
|
|
|
# Check if test failed by looking for actual failures in the summary line
|
|
if grep -qE "[0-9]+ examples?, [1-9][0-9]* failures?" "$test_file" || grep -q "Fatal error occurred" "$test_file"; then
|
|
# Extract failure details
|
|
local failure_message
|
|
failure_message=$(grep -E "(Fatal error|failure|FAILED)" "$test_file" | head -1 || echo "Test failed")
|
|
|
|
# Add rule if not exists
|
|
if ! echo "$rules_array" | jq -e '.[] | select(.id == "test-failure")' >/dev/null 2>&1; then
|
|
rules_array=$(echo "$rules_array" | jq '. + [{
|
|
"id": "test-failure",
|
|
"name": "TestFailure",
|
|
"shortDescription": {"text": "Test execution failed"},
|
|
"fullDescription": {"text": "A unit or integration test failed during execution"},
|
|
"defaultConfiguration": {"level": "error"}
|
|
}]')
|
|
fi
|
|
|
|
# Add result using jq --arg to safely escape dynamic strings
|
|
results_array=$(echo "$results_array" | jq \
|
|
--arg failure_msg "$failure_message" \
|
|
--arg action_name "$action_name" \
|
|
'. + [{
|
|
"ruleId": "test-failure",
|
|
"level": "error",
|
|
"message": {"text": $failure_msg},
|
|
"locations": [{
|
|
"physicalLocation": {
|
|
"artifactLocation": {"uri": ($action_name + "/action.yml")},
|
|
"region": {"startLine": 1, "startColumn": 1}
|
|
}
|
|
}]
|
|
}]')
|
|
fi
|
|
fi
|
|
done
|
|
fi
|
|
|
|
# Process integration test failures similarly
|
|
if [[ -d "${TEST_ROOT}/reports/integration" ]]; then
|
|
for test_file in "${TEST_ROOT}/reports/integration"/*.txt; do
|
|
if [[ -f "$test_file" ]]; then
|
|
local action_name
|
|
action_name=$(basename "$test_file" .txt)
|
|
|
|
if grep -qE "FAILED|ERROR|error:" "$test_file"; then
|
|
local failure_message
|
|
failure_message=$(grep -E "(FAILED|ERROR|error:)" "$test_file" | head -1 || echo "Integration test failed")
|
|
|
|
# Add integration rule if not exists
|
|
if ! echo "$rules_array" | jq -e '.[] | select(.id == "integration-failure")' >/dev/null 2>&1; then
|
|
rules_array=$(echo "$rules_array" | jq '. + [{
|
|
"id": "integration-failure",
|
|
"name": "IntegrationFailure",
|
|
"shortDescription": {"text": "Integration test failed"},
|
|
"fullDescription": {"text": "An integration test failed during workflow execution"},
|
|
"defaultConfiguration": {"level": "warning"}
|
|
}]')
|
|
fi
|
|
|
|
# Add result using jq --arg to safely escape dynamic strings
|
|
results_array=$(echo "$results_array" | jq \
|
|
--arg failure_msg "$failure_message" \
|
|
--arg action_name "$action_name" \
|
|
'. + [{
|
|
"ruleId": "integration-failure",
|
|
"level": "warning",
|
|
"message": {"text": $failure_msg},
|
|
"locations": [{
|
|
"physicalLocation": {
|
|
"artifactLocation": {"uri": ($action_name + "/action.yml")},
|
|
"region": {"startLine": 1, "startColumn": 1}
|
|
}
|
|
}]
|
|
}]')
|
|
fi
|
|
fi
|
|
done
|
|
fi
|
|
|
|
# Update SARIF file with results and rules
|
|
local temp_file
|
|
temp_file=$(mktemp)
|
|
jq --argjson rules "$rules_array" --argjson results "$results_array" \
|
|
'.runs[0].tool.driver.rules = $rules | .runs[0].results = $results' \
|
|
"$report_file" >"$temp_file" && mv "$temp_file" "$report_file"
|
|
|
|
log_success "SARIF report generated: $report_file"
|
|
}
|
|
|
|
# Generate console test report
|
|
generate_console_report() {
|
|
echo ""
|
|
echo "========================================"
|
|
echo " GitHub Actions Test Framework Report"
|
|
echo "========================================"
|
|
echo "Test Type: $TEST_TYPE"
|
|
echo "Timestamp: $(date)"
|
|
echo "Coverage Enabled: $COVERAGE_ENABLED"
|
|
echo ""
|
|
|
|
if [[ -d "${TEST_ROOT}/reports/unit" ]]; then
|
|
local unit_tests
|
|
unit_tests=$(find "${TEST_ROOT}/reports/unit" -name "*.txt" 2>/dev/null | wc -l | tr -d ' ')
|
|
printf "%-25s %4s\n" "Unit Tests Run:" "$unit_tests"
|
|
fi
|
|
|
|
if [[ -d "${TEST_ROOT}/reports/integration" ]]; then
|
|
local integration_tests
|
|
integration_tests=$(find "${TEST_ROOT}/reports/integration" -name "*.txt" 2>/dev/null | wc -l | tr -d ' ')
|
|
printf "%-25s %4s\n" "Integration Tests Run:" "$integration_tests"
|
|
fi
|
|
|
|
if [[ -f "${TEST_ROOT}/coverage/summary.json" ]]; then
|
|
local coverage
|
|
coverage=$(jq -r '.coverage_percent' "${TEST_ROOT}/coverage/summary.json" 2>/dev/null || echo "N/A")
|
|
if [[ "$coverage" =~ ^[0-9]+$ ]]; then
|
|
printf "%-25s %4s%%\n" "Test Coverage:" "$coverage"
|
|
else
|
|
printf "%-25s %s\n" "Test Coverage:" "$coverage"
|
|
fi
|
|
fi
|
|
|
|
echo "========================================"
|
|
}
|
|
|
|
# Main test execution function
|
|
main() {
|
|
log_info "Starting GitHub Actions Testing Framework"
|
|
|
|
# Parse arguments
|
|
parse_args "$@"
|
|
|
|
# Initialize framework
|
|
init_testing_framework
|
|
|
|
# Check dependencies
|
|
check_dependencies
|
|
|
|
# Discover actions to test
|
|
local actions=()
|
|
while IFS= read -r action; do
|
|
actions+=("$action")
|
|
done < <(discover_actions)
|
|
|
|
if [[ ${#actions[@]} -eq 0 ]]; then
|
|
log_error "No actions found to test"
|
|
exit 1
|
|
fi
|
|
|
|
# Run tests based on type
|
|
local test_failed=false
|
|
|
|
case "$TEST_TYPE" in
|
|
"unit")
|
|
if ! run_unit_tests "${actions[@]}"; then
|
|
test_failed=true
|
|
fi
|
|
;;
|
|
"integration")
|
|
if ! run_integration_tests "${actions[@]}"; then
|
|
test_failed=true
|
|
fi
|
|
;;
|
|
"e2e")
|
|
log_warning "E2E tests not yet implemented"
|
|
;;
|
|
"all")
|
|
if ! run_unit_tests "${actions[@]}"; then
|
|
test_failed=true
|
|
fi
|
|
if ! run_integration_tests "${actions[@]}"; then
|
|
test_failed=true
|
|
fi
|
|
;;
|
|
*)
|
|
log_error "Unknown test type: $TEST_TYPE"
|
|
exit 1
|
|
;;
|
|
esac
|
|
|
|
# Generate coverage report
|
|
generate_coverage_report
|
|
|
|
# Generate test report
|
|
generate_test_report
|
|
|
|
# Final status
|
|
if [[ $test_failed == "true" ]]; then
|
|
log_error "Some tests failed"
|
|
exit 1
|
|
else
|
|
log_success "All tests passed!"
|
|
exit 0
|
|
fi
|
|
}
|
|
|
|
# Run main function if script is executed directly
|
|
if [[ ${BASH_SOURCE[0]} == "${0}" ]]; then
|
|
main "$@"
|
|
fi
|