From 443361cddb8dbe815d93556a95f7b545eb9e966f Mon Sep 17 00:00:00 2001 From: Ismo Vuorinen Date: Thu, 5 Feb 2026 22:57:20 +0200 Subject: [PATCH] chore(scripts): remove unused VERBOSE declarations Remove VERBOSE="${VERBOSE:-0}" from scripts that never reference $VERBOSE after setting it. The variable is already set in scripts/shared.sh line 5. --- scripts/install-gh-extensions.sh | 3 --- scripts/install-git-crypt.sh | 3 --- scripts/install-go-packages.sh | 3 --- scripts/install-npm-packages.sh | 3 --- scripts/install-ntfy.sh | 3 --- scripts/install-python-packages.sh | 3 --- scripts/install-xcode-cli-tools.sh | 3 --- 7 files changed, 21 deletions(-) diff --git a/scripts/install-gh-extensions.sh b/scripts/install-gh-extensions.sh index f3d4da6..d3a6d25 100755 --- a/scripts/install-gh-extensions.sh +++ b/scripts/install-gh-extensions.sh @@ -5,9 +5,6 @@ set -euo pipefail # shellcheck source="shared.sh" source "${DOTFILES}/config/shared.sh" -# Enable verbosity with VERBOSE=1 -VERBOSE="${VERBOSE:-0}" - msgr run "Installing gh (GitHub Client) extensions" if ! command -v gh &> /dev/null; then diff --git a/scripts/install-git-crypt.sh b/scripts/install-git-crypt.sh index b4facf4..575146c 100755 --- a/scripts/install-git-crypt.sh +++ b/scripts/install-git-crypt.sh @@ -7,9 +7,6 @@ set -euo pipefail # shellcheck source=shared.sh source "${DOTFILES}/config/shared.sh" -# Enable verbosity with VERBOSE=1 -VERBOSE="${VERBOSE:-0}" - msgr run "Installing git-crypt" if ! command -v git-crypt &> /dev/null; then diff --git a/scripts/install-go-packages.sh b/scripts/install-go-packages.sh index 0d61d96..0e4e6b9 100755 --- a/scripts/install-go-packages.sh +++ b/scripts/install-go-packages.sh @@ -5,9 +5,6 @@ set -euo pipefail # shellcheck source=shared.sh source "$DOTFILES/config/shared.sh" -# Enable verbosity with VERBOSE=1 -VERBOSE="${VERBOSE:-0}" - msgr run "Installing go packages" ! x-have "go" && msgr err "go hasn't been installed yet." && exit 0 diff --git a/scripts/install-npm-packages.sh b/scripts/install-npm-packages.sh index 64482f9..5ffaf2c 100755 --- a/scripts/install-npm-packages.sh +++ b/scripts/install-npm-packages.sh @@ -5,9 +5,6 @@ set -euo pipefail # shellcheck source=shared.sh source "$DOTFILES/config/shared.sh" -# Enable verbosity with VERBOSE=1 -VERBOSE="${VERBOSE:-0}" - msgr msg "Starting to install npm packages" if ! command -v npm &> /dev/null; then diff --git a/scripts/install-ntfy.sh b/scripts/install-ntfy.sh index 6cd2cc3..0dfeb7e 100755 --- a/scripts/install-ntfy.sh +++ b/scripts/install-ntfy.sh @@ -5,9 +5,6 @@ set -euo pipefail # shellcheck source=shared.sh source "$DOTFILES/config/shared.sh" -# Enable verbosity with VERBOSE=1 -VERBOSE="${VERBOSE:-0}" - # Check if ntfy is already installed if x-have "ntfy"; then msgr "done" "ntfy already installed" diff --git a/scripts/install-python-packages.sh b/scripts/install-python-packages.sh index fb66ec8..2ba0fa9 100755 --- a/scripts/install-python-packages.sh +++ b/scripts/install-python-packages.sh @@ -5,9 +5,6 @@ set -euo pipefail # shellcheck source=shared.sh source "$DOTFILES/config/shared.sh" -# Enable verbosity with VERBOSE=1 -VERBOSE="${VERBOSE:-0}" - msgr run "Starting to install Python packages" # Ensure uv is available diff --git a/scripts/install-xcode-cli-tools.sh b/scripts/install-xcode-cli-tools.sh index a4c803f..e9172db 100755 --- a/scripts/install-xcode-cli-tools.sh +++ b/scripts/install-xcode-cli-tools.sh @@ -4,9 +4,6 @@ set -euo pipefail # Ismo Vuorinen 2018 # -# Enable verbosity with VERBOSE=1 -VERBOSE="${VERBOSE:-0}" - # Check if the script is running on macOS if [ "$(uname)" != "Darwin" ]; then msgr warn "Not a macOS system"