From b8070e28151a020c0fb466040057efcd61383f43 Mon Sep 17 00:00:00 2001 From: Ismo Vuorinen Date: Thu, 5 Feb 2026 22:44:44 +0200 Subject: [PATCH] fix(scripts): add missing exit after error handlers Critical bugs where error paths print a message but don't stop execution: - install-fonts.sh: cd failure now exits properly - install-ntfy.sh: unsupported OS case now exits with error - install-git-crypt.sh: git clone and cd failures now exit properly --- scripts/install-fonts.sh | 2 +- scripts/install-git-crypt.sh | 4 ++-- scripts/install-ntfy.sh | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/scripts/install-fonts.sh b/scripts/install-fonts.sh index b0ae4ed..65d7a02 100755 --- a/scripts/install-fonts.sh +++ b/scripts/install-fonts.sh @@ -21,7 +21,7 @@ clone_or_update_repo() git clone --quiet --filter=blob:none --sparse --depth=1 "$GIT_REPO" "$TMP_PATH" fi - cd "$TMP_PATH" || msgr err "No such folder $TMP_PATH" + cd "$TMP_PATH" || { msgr err "No such folder $TMP_PATH"; exit 1; } } # Function to add fonts to sparse-checkout diff --git a/scripts/install-git-crypt.sh b/scripts/install-git-crypt.sh index 34d7c4d..9c23531 100755 --- a/scripts/install-git-crypt.sh +++ b/scripts/install-git-crypt.sh @@ -19,8 +19,8 @@ if ! command -v git-crypt &> /dev/null; then rm -rf "$BUILD_PATH" if [ ! -d "$CHECK_PATH" ]; then - git clone --depth 1 "$REPO_URL" "$BUILD_PATH" || true - cd "$BUILD_PATH" || msg_err "$BUILD_PATH not found" + git clone --depth 1 "$REPO_URL" "$BUILD_PATH" || { msgr err "Failed to clone $REPO_URL"; exit 1; } + cd "$BUILD_PATH" || { msgr err "$BUILD_PATH not found"; exit 1; } make && make install PREFIX="$HOME/.local" else msgr run_done "git-crypt ($CHECK_PATH) already installed" diff --git a/scripts/install-ntfy.sh b/scripts/install-ntfy.sh index 672697f..8563f86 100755 --- a/scripts/install-ntfy.sh +++ b/scripts/install-ntfy.sh @@ -23,6 +23,7 @@ case $(dfm check arch) in ;; *) msgr err "Unsupported OS" + exit 1 ;; esac