Tweaks & EOL's added

local/bin/dfm

@@ -124,7 +124,7 @@ function section_dotfiles
     shfmt)
       # Format shell scripts according to following rules.
       find "$DOTFILES" \
-        \( -name '*.sh' -or -name '*.zsh' -or -name 'x-*' -or -not '*.pl' \) \
+        \( -name '*.sh' -or -name '*.zsh' -or -name 'x-*' \) \
         -exec shfmt -fn -l -w -i 2 -ci -sr -bn {} \;
       msg_done "🎉 dotfiles have been formatted!"
       ;;
@@ -209,3 +209,4 @@ case "$1" in
   tests) section_tests "$2" ;;
   *) usage && exit 0 ;;
 esac
+

local/bin/git-dirty

@@ -80,3 +80,4 @@ trap 'case $? in
       esac' EXIT
 
 gitdirtyrepos "$GIT_DIRTY_DIR"
+

local/bin/x-backup-mysql-with-prefix.sh

@@ -35,9 +35,10 @@ TIMESTAMP=$(date "+%Y%m%d_%H%M%S")
 FILENAME_TIMESTAMP="${DATABASE}_${FILENAME}_${TIMESTAMP}.sql"
 
 mysqldump \
-  ${DATABASE} \
+  "${DATABASE}" \
   "$(
     echo "show tables like '${PREFIX}%';" \
-      | mysql ${DATABASE} \
+      | mysql "${DATABASE}" \
       | sed '/Tables_in/d'
   )" > "${FILENAME_TIMESTAMP}"
+

local/bin/x-check-git-attributes

@@ -6,7 +6,7 @@
 
 if ! command -v git &> /dev/null; then
   echo "git could not be found, please install it first"
-  exit
+  exit 1
 fi
 
 missing_attributes=$(git ls-files | git check-attr -a --stdin | grep "text: auto")
@@ -17,3 +17,4 @@ if [[ "$missing_attributes" ]]; then
 else
   echo "All files have a corresponding rule in .gitattributes"
 fi
+

local/bin/x-dupes.pl

@@ -206,3 +206,4 @@ sub parsedOptions
     return (%vars);
 
 }
+

local/bin/x-foreach

@@ -14,3 +14,4 @@ for dir in $($cmd); do
     eval "$@" # allow multiple commands like "foo && bar"
   )
 done
+

local/bin/x-multi-ping.pl

@@ -226,3 +226,4 @@ sub parsedOptions
     return (%vars);
 
 }
+

local/bin/x-open-ports

@@ -3,6 +3,7 @@
 # List open (listened) ports, without the crud that
 # usually comes with `lsof -i`
 #
+# Modified by:     Ismo Vuorinen <https://github.com/ivuorinen> 2020
 # Originally from: https://www.commandlinefu.com/commands/view/8951
 # Original author: https://www.commandlinefu.com/commands/by/wickedcpj
 #
@@ -18,3 +19,4 @@ lsof -i 4 -P -n +c 0 \
   | uniq
 
 echo ""
+

local/bin/x-ssl-expiry-date

@@ -4,37 +4,27 @@
 # -----
 # Check the expiry date of the SSL certificate on the given host.
 #
-#
 # License
 # -------
-#
 # Copyright (c) 2013-2015 by Steve Kemp.  All rights reserved.
 #
 # This script is free software; you can redistribute it and/or modify it under
 # the same terms as Perl itself.
 #
 # The LICENSE file contains the full text of the license.
-#
-#
 
-#
-#  Simple function to show usage information, and exit.
-#
+# Simple function to show usage information, and exit.
 usage()
 {
   echo "Usage: $0 [-d] [-p 443] domain1.org domain2.com .. domainN"
   exit 0
 }
 
-#
-#  Default settings for flags set by the command-line arguments
-#
+# Default settings for flags set by the command-line arguments
 days=0
 port=443
 
-#
-#  Parse the argument(s) - i.e. look for "-d" / "-p 443".
-#
+# Parse the argument(s) - i.e. look for "-d" / "-p 443".
 while getopts "h?dp:" opt; do
   case $opt in
     h)
@@ -53,21 +43,15 @@ while getopts "h?dp:" opt; do
 done
 shift $((OPTIND - 1))
 
-#
-#  Ensure we have some arguments
-#
+# Ensure we have some arguments
 if [ "$#" = "0" ]; then
   usage
 fi
 
-#
 # For each domain-name on the command-line.
-#
 for name in "$@"; do
 
-  #
-  #  Make a temporary file
-  #
+  # Make a temporary file
   # Test if we have BSD or GNU version of mktemp
   if (strings "$(which mktemp)" | grep -q GNU); then
     # We have the GNU version
@@ -77,27 +61,19 @@ for name in "$@"; do
     tmp=$(mktemp -t tmp)
   fi
 
-  #
-  #  Download the certificate
-  #
-  if (! echo "" | openssl s_client -connect $name:$port > $tmp 2> /dev/null); then
+  # Download the certificate
+  if (! echo "" | openssl s_client -connect "$name:$port" > "$tmp" 2> /dev/null); then
     echo "Failed to get cert from https://$name:$port/"
     exit 3
   fi
 
-  #
-  #  Get the expiry date
-  #
+  # Get the expiry date
   date=$(openssl x509 -in "$tmp" -noout -enddate | awk -F= '{print $2}')
 
-  #
-  #  Remove the temporary file
-  #
+  # Remove the temporary file
   rm -f "$tmp"
 
-  #
-  #  Convert the expiry date + todays date to seconds-past epoch
-  #
+  # Convert the expiry date + todays date to seconds-past epoch
   # Check if we have the BSD or the GNU version of date
   if (strings "$(which date)" | grep -q GNU); then
     # We have GNU this is easy
@@ -115,15 +91,11 @@ for name in "$@"; do
 
   now=$(date +%s)
 
-  #
-  #  Day diff
-  #
+  # Day diff
   diff=$(("$then" - "$now"))
   diff=$($diff / 86400)
 
-  #
-  #  All done
-  #
+  # All done
   if [ "$days" = "1" ]; then
     echo "${name}: ${diff}"
   else
@@ -132,3 +104,4 @@ for name in "$@"; do
     echo "    Days: ${diff}"
   fi
 done
+

local/bin/x-until-error

@@ -3,13 +3,11 @@
 # About
 # -----
 # Repeat the command until it fails - always run at least once.
-#
 
 "$@"
 
-#
-#  If the status code was zero then repeat.
-#
+# If the status code was zero then repeat.
 while [ $? -eq 0 ]; do
   "$@"
 done
+

local/bin/x-until-success

@@ -14,17 +14,12 @@
 # the same terms as Perl itself.
 #
 # The LICENSE file contains the full text of the license.
-#
-#
 
-#
-#  Run the first time.
-#
+# Run the first time.
 "$@"
 
-#
-#  If the status code was not zero then repeat.
-#
+# If the status code was not zero then repeat.
 while [ $? -ne 0 ]; do
   "$@"
 done
+

local/bin/x-validate-sha256sum.sh

@@ -50,3 +50,4 @@ elif [ "$(get_sha256sum "$filename")" = "$file_hash" ]; then
 else
   error "$filename doesn't match provided sha256sum"
 fi
+

local/bin/x-when-down

@@ -24,9 +24,10 @@ echo "Waiting for $HOST to get down..."
 
 true
 while [ $? -ne 1 ]; do
-  ping -c 1 -W 1 $HOST > /dev/null
+  ping -c 1 -W 1 "$HOST" > /dev/null
 done
 
 shift
 
 "$@"
+

local/bin/x-when-up

@@ -22,7 +22,7 @@ if [ $# -lt 2 ]; then
   exit 1
 fi
 
-if [ $1 = "ssh" ]; then
+if [ "$1" = "ssh" ]; then
   HOST=$2
 else
   HOST=$1
@@ -30,16 +30,17 @@ fi
 
 echo "Waiting for $HOST to come online..."
 
-ping -c 1 -W 1 $HOST > /dev/null
+ping -c 1 -W 1 "$HOST" > /dev/null
 while [ $? -ne 0 ]; do
   sleep 1
-  ping -c 1 -W 1 $HOST > /dev/null
+  ping -c 1 -W 1 "$HOST" > /dev/null
 done
 
 # By the time we reach here the ping-command has completed successfully
 # so we can launch the command we were given - along with any arguments.
-if [ $1 != "ssh" ]; then
+if [ "$1" != "ssh" ]; then
   shift
 fi
 
 "$@"
+