Commit Graph

128 Commits

Author SHA1 Message Date
6d72003446 fix(lint): fix all sonarcloud detected issues (#279)
* fix(ci): replace broad permissions with specific scopes in workflows

Replace read-all/write-all with minimum required permission scopes
across all GitHub Actions workflows to follow the principle of least
privilege (SonarCloud rule githubactions:S8234).

* fix(shell): use [[ instead of [ for conditional tests

Replace single brackets with double brackets in bash conditional
expressions across 14 files (28 changes). All scripts use bash
shebangs so [[ is safe everywhere (SonarCloud rule shelldre:S7688).

* fix(shell): add explicit return statements to functions

Add return 0 as the last statement in ~46 shell functions across
17 files that previously relied on implicit return codes
(SonarCloud rule shelldre:S7682).

* fix(shell): assign positional parameters to local variables

Replace direct $1/$2/$3 usage with named local variables in _log(),
msg(), msg_err(), msg_done(), msg_run(), msg_ok(), and array_diff()
(SonarCloud rule shelldre:S7679).

* fix(python): replace dict() constructor with literal

Use {} instead of dict() for empty dictionary initialization
(SonarCloud rule python:S7498).

* fix(shell): fix husky shebang and tolerate npm outdated exit code

* docs(shell): add function docstring comments

* fix(shell): fix heredoc indentation in x-sonarcloud

* feat(python): add ruff linter and formatter configuration

* fix(ci): align megalinter config with biome, ruff, and shfmt settings

* fix(ci): disable black and yaml-prettier in megalinter config

* chore(ci): update ruff-pre-commit to v0.15.0 and fix hook name

* fix(scripts): check for .git dir before skipping clone in install-fonts

* fix(shell): address code review issues in scripts and shared.sh

- Guard wezterm show-keys failure in create-wezterm-keymaps.sh
- Stop masking git failures with return 0 in install-cheat-purebashbible.sh
- Add missing shared.sh source in install-xcode-cli-tools.sh
- Replace exit 1 with return 1 in sourced shared.sh

* fix(scripts): address code review and security findings

- Guard wezterm show-keys failure in create-wezterm-keymaps.sh
- Stop masking git failures with return 0 in install-cheat-purebashbible.sh
- Add missing shared.sh source in install-xcode-cli-tools.sh
- Replace exit 1 with return 1 in sourced shared.sh
- Remove shell=True subprocess calls in x-git-largest-files.py

* style(shell): apply shfmt formatting and add args to pre-commit hook

* fix(python): suppress bandit false positives in x-git-largest-files

* fix(python): add nosemgrep suppression for check_output call

* feat(format): add prettier for YAML formatting

Install prettier, add .prettierrc.json config (200-char width, 2-space
indent, LF endings), .prettierignore, yarn scripts (lint:prettier,
fix:prettier, format:yaml), and pre-commit hook scoped to YAML files.

* style(yaml): apply prettier formatting

* fix(scripts): address remaining code review findings

- Python: use list comprehension to filter empty strings instead of
  slicing off the last element
- create-wezterm-keymaps: write to temp file and mv for atomic updates
- install-xcode-cli-tools: fix shellcheck source directive path

* fix(python): sort imports alphabetically in x-git-largest-files

* fix(lint): disable PYTHON_ISORT in MegaLinter, ruff handles it

* chore(git): add __pycache__ to gitignore

* fix(python): rename ambiguous variable l to line (E741)

* style: remove trailing whitespace and blank lines

* style(fzf): apply shfmt formatting

* style(shell): apply shfmt formatting

* docs(plans): add design documents

* style(docs): add language specifier to fenced code block

* feat(lint): add markdown-table-formatter to dev tooling

Add markdown-table-formatter as a dev dependency with yarn scripts
(lint:md-table, fix:md-table) and a local pre-commit hook to
automatically format markdown tables on commit.
2026-02-07 19:01:02 +02:00
renovate[bot]
c61127abbe chore(deps): update pre-commit hook adrienverge/yamllint (v1.37.1 → v1.38.0) (#271)
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-01-15 07:07:14 +02:00
renovate[bot]
678466b898 chore(deps): update pre-commit hook rhysd/actionlint (v1.7.9 → v1.7.10) (#266)
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2026-01-01 04:25:25 +00:00
961efec364 feat: switch to biome, apply formatting, shellcheck (#227)
* feat: switch to biome, apply formatting, shellcheck
* chore: apply cr comments
* chore: few config tweaks, shellcheck hook now py-based
* chore: lint fixes and pr comments
* chore(lint): megalinter, and other fixes

Signed-off-by: Ismo Vuorinen <ismo@ivuorinen.net>
2025-12-17 16:03:29 +02:00
github-actions[bot]
c6ba0e4036 chore: update pre-commit hooks (#263)
Co-authored-by: ivuorinen <11024+ivuorinen@users.noreply.github.com>
2025-12-15 09:35:47 +02:00
renovate[bot]
7b1ed2f596 chore(deps): update pre-commit hook igorshubovych/markdownlint-cli (v0.46.0 → v0.47.0) (#262)
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-12-13 20:55:07 +00:00
github-actions[bot]
48f61fa917 chore: update pre-commit hooks (#260)
Co-authored-by: ivuorinen <11024+ivuorinen@users.noreply.github.com>
2025-12-11 13:56:31 +02:00
github-actions[bot]
d35014ed2e chore: update pre-commit hooks (#257) 2025-12-08 07:41:13 +02:00
github-actions[bot]
8e7af8ddc7 chore: update pre-commit hooks (#254) 2025-12-04 12:06:46 +02:00
renovate[bot]
0b5f80cb03 chore(deps): update pre-commit hook renovatebot/pre-commit-hooks (42.27.0 → 42.27.1) (#251)
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-12-01 09:15:57 +02:00
github-actions[bot]
72f42835ff chore: update pre-commit hooks (#252)
Co-authored-by: ivuorinen <11024+ivuorinen@users.noreply.github.com>
2025-12-01 09:14:14 +02:00
github-actions[bot]
055cf7ef2e chore: update pre-commit hooks (#242) 2025-11-27 07:51:23 +02:00
bba76843db chore(deps): update pre-commit hooks 2025-11-22 09:39:37 +02:00
renovate[bot]
beb89e9490 chore(deps): update pre-commit hook renovatebot/pre-commit-hooks (42.7.0 → 42.11.0) (#240)
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-11-17 04:10:37 +00:00
github-actions[bot]
d16ce9ad0f chore: update pre-commit hooks (#237) 2025-11-13 13:21:31 +02:00
github-actions[bot]
62eb417935 chore: update pre-commit hooks (#234) 2025-11-11 22:34:15 +02:00
renovate[bot]
8fcab21a67 chore(deps): update pre-commit hook renovatebot/pre-commit-hooks (42.0.2 → 42.1.3) (#233)
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-11-09 06:48:18 +02:00
renovate[bot]
43a714513f chore(deps)!: update renovatebot/pre-commit-hooks (41.173.0 → 42.0.2) (#232)
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-11-07 15:14:24 +02:00
github-actions[bot]
044298af74 chore: update pre-commit hooks (#231)
Co-authored-by: ivuorinen <11024+ivuorinen@users.noreply.github.com>
2025-11-06 07:15:25 +02:00
github-actions[bot]
065eb2f9c0 chore: update pre-commit hooks (#230) 2025-11-03 09:30:56 +02:00
renovate[bot]
8f652a2a9b chore(deps): update pre-commit hook renovatebot/pre-commit-hooks (41.146.0 → 41.168.5) (#225)
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-11-02 07:25:14 +00:00
github-actions[bot]
7e9d2df990 chore: update pre-commit hooks (#212) 2025-10-13 14:29:07 +03:00
renovate[bot]
416523660a chore(deps): update pre-commit hook renovatebot/pre-commit-hooks (41.143.1 → 41.146.0) (#211)
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-10-12 08:39:47 +00:00
github-actions[bot]
1e15c0cad2 chore: update pre-commit hooks (#207) 2025-10-10 19:42:24 +03:00
github-actions[bot]
c4a55efd7c chore: update pre-commit hooks (#206) 2025-10-06 09:02:47 +03:00
renovate[bot]
cd72b003a0 chore(deps): update pre-commit hook renovatebot/pre-commit-hooks (41.131.9 → 41.132.5) (#202)
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-10-02 04:06:34 +00:00
github-actions[bot]
7715e1c8b0 chore: update pre-commit hooks (#201) 2025-09-29 18:50:02 +03:00
renovate[bot]
e91f31a049 chore(deps): update pre-commit hook johnnymorganz/stylua (v2.2.0 → v2.3.0) (#200) 2025-09-28 23:22:53 +03:00
github-actions[bot]
1be21eb247 chore: update pre-commit hooks (#198) 2025-09-25 08:04:34 +03:00
github-actions[bot]
aae39dd913 chore: update pre-commit hooks (#196) 2025-09-22 09:50:19 +03:00
github-actions[bot]
35ede87808 chore: update pre-commit hooks (#193) 2025-09-18 11:48:28 +03:00
github-actions[bot]
2e184aa6c1 chore: update pre-commit hooks (#192) 2025-09-15 11:05:05 +03:00
github-actions[bot]
ffd4121eef chore: update pre-commit hooks (#191) 2025-09-11 10:15:37 +03:00
github-actions[bot]
099a80c78b chore: update pre-commit hooks (#188) 2025-09-08 08:51:18 +03:00
renovate[bot]
081ac55dd7 chore(deps): update pre-commit hook renovatebot/pre-commit-hooks (41.96.0 → 41.97.7) (#187)
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-09-07 13:39:24 +00:00
github-actions[bot]
cc8578ed4c chore: update pre-commit hooks (#184)
Co-authored-by: ivuorinen <11024+ivuorinen@users.noreply.github.com>
2025-09-04 10:10:41 +03:00
5606cff9fd chore(lint): prettier, added ignored directories 2025-09-03 14:49:00 +03:00
github-actions[bot]
185562737c chore: update pre-commit hooks (#182)
Co-authored-by: ivuorinen <11024+ivuorinen@users.noreply.github.com>
2025-09-01 09:29:43 +03:00
github-actions[bot]
41315f7c53 chore: update pre-commit hooks (#181) 2025-08-28 08:17:01 +03:00
renovate[bot]
e67abce6ed fix(github-release): update renovatebot/pre-commit-hooks (41.82.9 → 41.82.10) (#179)
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-08-24 23:05:18 +00:00
renovate[bot]
ab07793804 fix(github-release): update renovatebot/pre-commit-hooks (41.82.8 → 41.82.9) (#178) 2025-08-24 16:49:12 +03:00
renovate[bot]
ba87c82d51 fix(github-release): update renovatebot/pre-commit-hooks (41.82.7 → 41.82.8) (#177) 2025-08-24 14:29:07 +03:00
renovate[bot]
cf5ce57a57 fix(github-release): update renovatebot/pre-commit-hooks (41.82.1 → 41.82.7) (#174) 2025-08-24 14:23:38 +03:00
github-actions[bot]
3399288a81 chore: update pre-commit hooks (#172)
Co-authored-by: ivuorinen <11024+ivuorinen@users.noreply.github.com>
2025-08-21 10:50:15 +03:00
github-actions[bot]
bfe46f0a90 chore: update pre-commit hooks (#170) 2025-08-18 19:36:04 +03:00
5f59851c7a chore(tooling): use yarn for linting scripts (#149)
* chore(tooling): use yarn for linting scripts

* chore: fixes and tweaks

* chore(ci): more permissions

* chore: clean up, lint fixes

* chore: clean up, lint fixes

* chore: clean up, lint fixes

* chore(lint): fix yamllint errors and warnings

* chore(lint): lint fixes

* chore(lint): lint fixes
2025-08-15 09:06:22 +03:00
github-actions[bot]
9ac792b924 chore: update pre-commit hooks (#168) 2025-08-14 09:29:36 +03:00
github-actions[bot]
782eeb78ec chore: update pre-commit hooks (#162)
Co-authored-by: ivuorinen <11024+ivuorinen@users.noreply.github.com>
2025-08-11 14:03:56 +03:00
github-actions[bot]
0b11f6456a chore: update pre-commit hooks (#160) 2025-08-07 10:07:08 +03:00
github-actions[bot]
4723d5c61c chore: update pre-commit hooks (#158) 2025-08-04 07:35:25 +03:00