mirror of
https://github.com/ivuorinen/f2b.git
synced 2026-03-07 12:58:04 +00:00
fix: repair Renovate config, convert Makefile to go run, update GitHub Actions (#120)
* fix: repair Renovate config and convert Makefile to go run (#117) - Remove non-existent `github>renovatebot/presets:golang` preset that broke Renovate PR creation - Replace deprecated `fileMatch` with `managerFilePatterns` in customManagers - Rewrite regex to match new Makefile pattern (renovate comment above version variable assignment) - Fix `matchFileNames` glob pattern (`*.mk` -> `**/*.mk`) - Convert all tool invocations from `go install` + global binary to `go run tool@version` for reproducible builds - Convert npm global tools to `npx --yes` invocations - Remove `dev-deps` and `check-deps` targets (tools auto-download) - Add mdformat pre-commit hook with GFM support and config - Add `fmt-md` Makefile target for manual markdown formatting - Update local golangci-lint pre-commit hook to use `go run` - Apply golangci-lint v2.10.1 auto-fixes (fmt.Fprintf optimization) - Add nolint:gosec annotations for legitimate exec.Command usage - Exclude .serena/ from mdformat and megalinter - Add markdown indent_size=unset in .editorconfig for CommonMark compat * chore(deps): update GitHub Actions to latest versions - anthropics/claude-code-action: v1.0.34 -> v1.0.64 - actions/setup-go: v6.2.0 -> v6.3.0 - actions/upload-artifact: v6.0.0 -> v7.0.0 - goreleaser/goreleaser-action: v6.4.0 -> v7.0.0 - docker/login-action: v3.6.0 -> v3.7.0 - ivuorinen/actions: v2026.01.21 -> v2026.02.24 * fix: address code review feedback - Fix issue template YAML frontmatter (replace underscore separators with proper --- delimiters); exclude templates from mdformat - Replace string(rune(n)) with strconv.Itoa(n) in test files to produce deterministic numeric directory names instead of Unicode characters - Remove stale `make dev-deps` reference in README, replace with `make dev-setup` - Extract ban/unban format strings into shared.MetricsFmtBanOperations and shared.MetricsFmtUnbanOperations constants - Replace hardcoded coverage percentages in README with evergreen phrasing * fix: address round 2 code review feedback for PR #120 - Fix corrupted path traversal example in docs/security.md - Fix Renovate .mk regex to match nested paths (.*\.mk$) - Update checkmake pre-commit hook to v0.3.2 to match Makefile - Add sync.WaitGroup to unsynchronized goroutines in security tests - Fix fmt-md target to use pre-commit run mdformat - Pin markdownlint-cli2 to v0.21.0 in lint-md target - Standardize //nolint:gosec to // #nosec annotations for gosec CLI * fix(ci): install PyYAML dependency for PR lint workflow The pr-lint workflow uses ivuorinen/actions/pr-lint which internally calls validate-inputs running a Python script that imports yaml. Python was set up but PyYAML was never installed, causing ModuleNotFoundError at runtime. * fix: address round 3 code review feedback for PR #120 - Wrap Windows-style path traversal example in backtick code span so backslashes render literally in docs/security.md - Add Renovate-managed MARKDOWNLINT_CLI2_VERSION variable in Makefile to match the pattern used by all other tool versions
This commit is contained in:
@@ -225,11 +225,11 @@ Both workflows now use unified pre-commit:
|
||||
### Before Committing
|
||||
|
||||
1. **Read configuration files first**: `.editorconfig`, `.golangci.yml`,
|
||||
`.markdownlint.json`, `.yamlfmt.yaml`, `.pre-commit-config.yaml`
|
||||
2. **Apply configuration rules** during development
|
||||
3. **Run pre-commit checks**: `pre-commit run --all-files`
|
||||
4. **Fix all issues** across the project
|
||||
5. **Run tests**: `go test ./...`
|
||||
`.markdownlint.json`, `.yamlfmt.yaml`, `.pre-commit-config.yaml`
|
||||
1. **Apply configuration rules** during development
|
||||
1. **Run pre-commit checks**: `pre-commit run --all-files`
|
||||
1. **Fix all issues** across the project
|
||||
1. **Run tests**: `go test ./...`
|
||||
|
||||
### Recommended IDE Setup
|
||||
|
||||
@@ -303,19 +303,19 @@ All YAML files include schema references for better IDE support:
|
||||
### Debugging Tips
|
||||
|
||||
1. **Run individual hooks** to isolate issues
|
||||
2. **Use `--verbose` flag** with pre-commit
|
||||
3. **Check configuration files** for rule customizations
|
||||
4. **Verify tool versions** match CI environment
|
||||
1. **Use `--verbose` flag** with pre-commit
|
||||
1. **Check configuration files** for rule customizations
|
||||
1. **Verify tool versions** match CI environment
|
||||
|
||||
## Adding New Linting Rules
|
||||
|
||||
### Process
|
||||
|
||||
1. Update configuration files (`.markdownlint.json`, `.yamlfmt.yaml`, etc.)
|
||||
2. Test changes locally: `pre-commit run --all-files`
|
||||
3. Update `.pre-commit-config.yaml` if adding new hooks
|
||||
4. Document changes in this file
|
||||
5. Consider backward compatibility
|
||||
1. Test changes locally: `pre-commit run --all-files`
|
||||
1. Update `.pre-commit-config.yaml` if adding new hooks
|
||||
1. Document changes in this file
|
||||
1. Consider backward compatibility
|
||||
|
||||
### Best Practices
|
||||
|
||||
|
||||
Reference in New Issue
Block a user