mirror of
https://github.com/ivuorinen/f2b.git
synced 2026-01-26 03:13:58 +00:00
* Go rewrite * chore(cr): apply suggestions Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Ismo Vuorinen <ismo@ivuorinen.net> * 📝 CodeRabbit Chat: Add NoOpClient to fail2ban and initialize when skip flag is true * 📝 CodeRabbit Chat: Fix malformed if-else structure and add no-op client for skip-only commands * 📝 CodeRabbit Chat: Fix malformed if-else structure and add no-op client for skip-only commands * fix(main): correct no-op branch syntax (#10) * chore(gitignore): ignore env and binary files (#11) * chore(config): remove indent_size for go files (#12) * feat(cli): inject version via ldflags (#13) * fix(security): validate filter parameter to prevent path traversal (#15) * chore(repo): anchor ignore for build artifacts (#16) * chore(ci): use golangci-lint action (#17) * feat(fail2ban): expose GetLogDir (#19) * test(cmd): improve IP mock validation (#20) * chore(ci): update golanglint * fix(ci): golanglint * fix(ci): correct args indentation in pr-lint workflow (#21) * fix(ci): avoid duplicate releases (#22) * refactor(fail2ban): remove test check from OSRunner (#23) * refactor(fail2ban): make log and filter dirs configurable (#24) * fix(ci): create single release per tag (#14) Signed-off-by: Ismo Vuorinen <ismo@ivuorinen.net> * chore(dev): add codex setup script (#27) * chore(lint): enable staticcheck (#26) * chore(ci): verify golangci config (#28) * refactor(cmd): centralize env config (#29) * chore(dev): add pre-commit config (#30) * fix(ci): disable cgo in cross compile (#31) * fix(ci): fail on formatting issues (#32) * feat(cmd): add context to logs watch (#33) * chore: fixes, roadmap, claude.md, linting * chore: fixes, linting * fix(ci): gh actions update, fixes and tweaks * chore: use reviewdog actionlint * chore: use wow-rp-addons/actions-editorconfig-check * chore: combine agent instructions, add comments, fixes * chore: linting, fixes, go revive * chore(deps): update pre-commit hooks * chore: bump go to 1.21, pin workflows * fix: install tools in lint.yml * fix: sudo timeout * fix: service command injection * fix: memory exhaustion with large logs * fix: enhanced path traversal and file security vulns * fix: race conditions * fix: context support * chore: simplify fail2ban/ code * feat: major refactoring with GoReleaser integration and code consolidation - Add GoReleaser configuration for automated multi-platform releases - Support for Linux, macOS, Windows, and BSD builds - Docker images, Homebrew tap, and Linux packages (.deb, .rpm, .apk) - GitHub Actions workflow for release automation - Consolidate duplicate code and improve architecture - Extract common command helpers to cmd/helpers.go (~230 lines) - Remove duplicate MockClient implementation from tests (~250 lines) - Create context wrapper helpers in fail2ban/context_helpers.go - Standardize error messages in fail2ban/errors.go - Enhance validation and security - Add proper IP address validation with fail2ban.ValidateIP - Fix path traversal and command injection vulnerabilities - Improve thread-safety in MockClient with consistent ordering - Optimize documentation - Reduce CLAUDE.md from 190 to 81 lines (57% reduction) - Reduce TODO.md from 633 to 93 lines (85% reduction) - Move README.md to root directory with installation instructions - Improve test reliability - Fix race conditions and test flakiness - Add sorting to ensure deterministic test output - Enhance MockClient with configurable behavior * feat: comprehensive code quality improvements and documentation reorganization This commit represents a major overhaul of code quality, documentation structure, and development tooling: **Documentation & Structure:** - Move CODE_OF_CONDUCT.md from .github to root directory - Reorganize documentation with dedicated docs/ directory - Create comprehensive architecture, security, and testing documentation - Update all references and cross-links for new documentation structure **Code Quality & Linting:** - Add 120-character line length limit across all files via EditorConfig - Enable comprehensive linting with golines, lll, usetesting, gosec, and revive - Fix all 86 revive linter issues (unused parameters, missing export comments) - Resolve security issues (file permissions 0644 → 0600, gosec warnings) - Replace deprecated os.Setenv with t.Setenv in all tests - Configure golangci-lint with auto-fix capabilities and formatter integration **Development Tooling:** - Enhance pre-commit configuration with additional hooks and formatters - Update GoReleaser configuration with improved YAML formatting - Improve GitHub workflows and issue templates for CLI-specific context - Add comprehensive Makefile with proper dependency checking **Testing & Security:** - Standardize mock patterns and context wrapper implementations - Enhance error handling with centralized error constants - Improve concurrent access testing for thread safety * perf: implement major performance optimizations with comprehensive test coverage This commit introduces three significant performance improvements along with complete linting compliance and robust test coverage: **Performance Optimizations:** 1. **Time Parsing Cache (8.6x improvement)** - Add TimeParsingCache with sync.Map for caching parsed times - Implement object pooling for string builders to reduce allocations - Create optimized BanRecordParser with pooled string slices 2. **Gzip Detection Consolidation (55x improvement)** - Consolidate ~100 lines of duplicate gzip detection logic - Fast-path extension checking before magic byte detection - Unified GzipDetector with comprehensive file handling utilities 3. **Parallel Processing (2.5-5.0x improvement)** - Generic WorkerPool implementation for concurrent operations - Smart fallback to sequential processing for single operations - Context-aware cancellation support for long-running tasks - Applied to ban/unban operations across multiple jails **New Files Added:** - fail2ban/time_parser.go: Cached time parsing with global instances - fail2ban/ban_record_parser.go: Optimized ban record parsing - fail2ban/gzip_detection.go: Unified gzip handling utilities - fail2ban/parallel_processing.go: Generic parallel processing framework - cmd/parallel_operations.go: Command-level parallel operation support **Code Quality & Linting:** - Resolve all golangci-lint issues (0 remaining) - Add proper #nosec annotations for legitimate file operations - Implement sentinel errors replacing nil/nil anti-pattern - Fix context parameter handling and error checking **Comprehensive Test Coverage:** - 500+ lines of new tests with benchmarks validating all improvements - Concurrent access testing for thread safety - Edge case handling and error condition testing - Performance benchmarks demonstrating measured improvements **Modified Files:** - fail2ban/fail2ban.go: Integration with new optimized parsers - fail2ban/logs.go: Use consolidated gzip detection (-91 lines) - cmd/ban.go & cmd/unban.go: Add conditional parallel processing * test: comprehensive test infrastructure overhaul with real test data Major improvements to test code quality and organization: • Added comprehensive test data infrastructure with 6 anonymized log files • Extracted common test helpers reducing ~200 lines to ~50 reusable functions • Enhanced ban record parser tests with real production log patterns • Improved gzip detection tests with actual compressed test data • Added integration tests for full log processing and concurrent operations • Updated .gitignore to allow testdata log files while excluding others • Updated TODO.md to reflect completed test infrastructure improvements * fix: comprehensive security hardening and critical bug fixes Security Enhancements: - Add command injection protection with allowlist validation for all external commands - Add security documentation to gzip functions warning about path traversal risks - Complete TODO.md security audit - all critical vulnerabilities addressed Bug Fixes: - Fix negative index access vulnerability in parallel operations (prevent panic) - Fix parsing inconsistency between BannedIn and BannedInWithContext functions - Fix nil error handling in concurrent log reading tests - Fix benchmark error simulation to measure actual performance vs error paths Implementation Details: - Add ValidateCommand() with allowlist for fail2ban-client, fail2ban-regex, service, systemctl, sudo - Integrate command validation into all OSRunner methods before execution - Replace manual string parsing with ParseBracketedList() for consistency - Add bounds checking (index >= 0) to prevent negative array access - Replace nil error with descriptive error message in concurrent error channels - Update banFunc in benchmark to return success instead of permanent errors Test Coverage: - Add comprehensive security validation tests with injection attempt patterns - Add parallel operations safety tests with index validation - Add parsing consistency tests between context/non-context functions - Add error handling demonstration tests for concurrent operations - Add gzip function security requirement documentation tests * perf: implement ultra-optimized log and ban record parsing with significant performance gains Major performance improvements to core fail2ban processing with comprehensive benchmarking: Performance Achievements: • Ban record parsing: 15% faster, 39% less memory, 45% fewer allocations • Log processing: 27% faster, 64% less memory, 32% fewer allocations • Cache performance: 624x faster cache hits with zero allocations • String pooling: 4.7x improvement with zero memory allocations Core Optimizations: • Object pooling (sync.Pool) for string slices, scanner buffers, and line buffers • Comprehensive caching (sync.Map) for gzip detection, file info, and path patterns • Fast path optimizations with extension-based gzip detection • Byte-level operations to reduce string allocations in filtering • Ultra-optimized parsers with smart field parsing and efficient time handling New Files: • fail2ban/ban_record_parser_optimized.go - High-performance ban record parser • fail2ban/log_performance_optimized.go - Ultra-optimized log processor with caching • fail2ban/ban_record_parser_benchmark_test.go - Ban record parsing benchmarks • fail2ban/log_performance_benchmark_test.go - Log performance benchmarks • fail2ban/ban_record_parser_compatibility_test.go - Compatibility verification tests Updated: • fail2ban/fail2ban.go - Integration with ultra-optimized parsers • TODO.md - Marked performance optimization tasks as completed * fix(ci): install dev dependencies for pre-commit * refactor: streamline pre-commit config and extract test helpers - Replace local hooks with upstream pre-commit repositories for better maintainability - Add new hooks: shellcheck, shfmt, checkov for enhanced code quality - Extract common test helpers into dedicated test_helpers.go to reduce duplication - Add warning logs for unreadable log files in fail2ban and logs packages - Remove hard-coded GID checks in sudo.go for better cross-platform portability - Update golangci-lint installation method in Makefile * fix(security): path traversal, log file validation * feat: complete pre-release modernization with comprehensive testing - Remove all deprecated legacy functions and dead code paths - Add security hardening with sanitized error messages - Implement comprehensive performance benchmarks and security audit tests - Mark all pre-release modernization tasks as completed (10/10) - Update project documentation to reflect full completion status * fix(ci): linting, and update gosec install source * feat: implement comprehensive test framework with 60-70% code reduction Major test infrastructure modernization: - Create fluent CommandTestBuilder framework for streamlined test creation - Add MockClientBuilder pattern for advanced mock configuration - Standardize table test field naming (expectedOut→wantOutput, expectError→wantError) - Consolidate test code: 3,796 insertions, 3,104 deletions (net +692 lines with enhanced functionality) Framework achievements: - 168+ tests passing with zero regressions - 5 cmd test files fully migrated to new framework - 63 field name standardizations applied - Advanced mock patterns with fluent interface File organization improvements: - Rename all test files with consistent prefixes (cmd_*, fail2ban_*, main_*) - Split monolithic test files into focused, maintainable modules - Eliminate cmd_test.go (622 lines) and main_test.go (825 lines) - Create specialized test files for better organization Documentation enhancements: - Update docs/testing.md with complete framework documentation - Optimize TODO.md from 231→72 lines (69% token reduction) - Add comprehensive migration guides and best practices Test framework components: - command_test_framework.go: Core fluent interface implementation - MockClientBuilder: Advanced mock configuration with builder pattern - table_test_standards.go: Standardized field naming conventions - Enhanced test helpers with error checking consolidation * chore: fixes, .go-version, linting * fix(ci) editorconfig in .pre-commit-config.yaml * fix: too broad gitignore * chore: update fail2ban/fail2ban_path_security_test.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Ismo Vuorinen <ismo@ivuorinen.net> * chore: code review fixes * chore: code review fixes * fix: more code review fixes * fix: more code review fixes * feat: cleanup, fixes, testing * chore: minor config file updates - Add quotes to F2B_TIMEOUT value in .env.example for clarity - Remove testdata log exception from .gitignore (simplified) * feat: implement comprehensive monitoring with structured logging and metrics - Add structured logging with context propagation throughout codebase - Implement ContextualLogger with request tracking and operation timing - Add context values for operation, IP, jail, command, and request ID - Integrate with existing logrus logging infrastructure - Add request/response timing metrics collection - Create comprehensive Metrics system with atomic counters - Track command executions, ban/unban operations, and client operations - Implement latency distribution buckets for performance analysis - Add validation cache hit/miss tracking - Enhance ban/unban commands with structured logging - Add LogOperation wrapper for automatic timing and context - Log individual jail operations with success/failure status - Integrate metrics recording with ban/unban operations - Add new 'metrics' command to expose collected metrics - Support both plain text and JSON output formats - Display system metrics (uptime, memory, goroutines) - Show operation counts, failures, and average latencies - Include latency distribution histograms - Update test infrastructure - Add tests for metrics command - Fix test helper to support persistent flags - Ensure all tests pass with new logging This completes the high-priority performance monitoring and structured logging requirements from TODO.md, providing comprehensive operational visibility into the f2b application. * docs: update TODO.md to reflect completed monitoring work - Mark structured logging and timing metrics as completed - Update test coverage stats (cmd/ improved from 66.4% to 76.8%) - Add completed infrastructure section for today's work - Update current status date and add monitoring to health indicators * feat: complete TODO.md technical debt cleanup Complete all remaining TODO.md tasks with comprehensive implementation: ## 🎯 Validation Caching Implementation - Thread-safe validation cache with sync.RWMutex protection - MetricsRecorder interface to avoid circular dependencies - Cached validation for IP, jail, filter, and command validation - Integration with existing metrics system for cache hit/miss tracking - 100% test coverage for caching functionality ## 🔧 Constants Extraction - Fail2Ban status codes: Fail2BanStatusSuccess, Fail2BanStatusAlreadyProcessed - Command constants: Fail2BanClientCommand, Fail2BanRegexCommand, Fail2BanServerCommand - File permissions: DefaultFilePermissions (0600), DefaultDirectoryPermissions (0750) - Timeout limits: MaxCommandTimeout, MaxFileTimeout, MaxParallelTimeout - Updated all references throughout codebase to use named constants ## 📊 Test Coverage Improvement - Increased fail2ban package coverage from 62.0% to 70.3% (target: 70%+) - Added 6 new comprehensive test files with 200+ additional test cases - Coverage improvements across all major components: - Context helpers, validation cache, mock clients, OS runner methods - Error constructors, timing operations, cache statistics - Thread safety and concurrency testing ## 🛠️ Code Quality & Fixes - Fixed all linting issues (golangci-lint, revive, errcheck) - Resolved unused parameter warnings and error handling - Fixed timing-dependent test failures in worker pool cancellation - Enhanced thread safety in validation caching ## 📈 Final Metrics - Overall test coverage: 72.4% (up from ~65%) - fail2ban package: 70.3% (exceeds 70% target) - cmd package: 76.9% - Zero TODO/FIXME/HACK comments in production code - 100% linting compliance * fix: resolve test framework issues and update documentation - Remove unnecessary defer/recover block in comprehensive_framework_test.go - Fix compilation error in command_test_framework.go variable redeclaration - Update TODO.md to reflect all 12 completed code quality fixes - Clean up dead code and improve test maintainability - Fix linting issues: error handling, code complexity, security warnings - Break down complex test function to reduce cyclomatic complexity * fix: replace dangerous test commands with safe placeholders Replaces actual dangerous commands in test cases with safe placeholder patterns to prevent accidental execution while maintaining comprehensive security testing. - Replace 'rm -rf /', 'cat /etc/passwd' with 'DANGEROUS_RM_COMMAND', 'DANGEROUS_SYSTEM_CALL' - Update GetDangerousCommandPatterns() to recognize both old and new patterns - Enhance filter validation with command injection protection (semicolons, pipes, backticks, dollar signs) - Add package documentation comments for all packages (main, cmd, fail2ban) - Fix GoReleaser static linking configuration for cross-platform builds - Remove Docker platform restriction to enable multi-arch support - Apply code formatting and linting fixes All security validation tests continue to pass with the safe placeholders. * fix: resolve TestMixedConcurrentOperations race condition and command key mismatches The concurrency test was failing due to several issues: 1. **Command Key Mismatch**: Test setup used "sudo test arg" key but MockRunner looked for "test arg" because "test" command doesn't require sudo 2. **Invalid Commands**: Using "test" and "echo" commands that aren't in the fail2ban command allowlist, causing validation failures 3. **Race Conditions**: Multiple goroutines setting different MockRunners simultaneously, overwriting responses **Solution:** - Replace invalid test commands ("test", "echo") with valid fail2ban commands ("fail2ban-client status", "fail2ban-client -V") - Pre-configure shared MockRunner with all required response keys for both sudo and non-sudo execution paths - Improve test structure to reduce race conditions between setup and execution All tests now pass reliably, resolving the CI failure. * fix: address code quality issues and improve test coverage - Replace unsafe type assertion with comma-ok idiom in logging - Fix TestTestFilter to use created filter instead of nonexistent - Add warning logs for invalid log level configurations - Update TestVersionCommand to use consistent test framework pattern - Remove unused LoggerContextKey constant - Add version command support to test framework - Fix trailing whitespace in test files * feat: add timeout handling and multi-architecture Docker support * test: enhance path traversal security test coverage * chore: comprehensive documentation update and linting fixes Updated all documentation to reflect current capabilities including context-aware operations, multi-architecture Docker support, advanced security features, and performance monitoring. Removed unused functions and fixed all linting issues. * fix(lint): .goreleaser.yaml * feat: add markdown link checker and fix all linting issues - Add markdown-link-check to pre-commit hooks with comprehensive configuration - Fix GitHub workflow structure (sync-labels.yml) with proper job setup - Add JSON schemas to all configuration files for better IDE support - Update tool installation in Makefile for markdown-link-check dependency - Fix all revive linting issues (Boolean literals, defer in loop, if-else simplification, method naming) - Resolve broken relative link in CONTRIBUTING.md - Configure rate limiting and ignore patterns for GitHub URLs - Enhance CLAUDE.md with link checking documentation * fix(ci): sync-labels permissions * docs: comprehensive documentation update reflecting current project status - Updated TODO.md to show production-ready status with 21 commands - Enhanced README.md with enterprise-grade features and capabilities - Added performance monitoring and timeout configuration to FAQ - Updated CLAUDE.md with accurate project architecture overview - Fixed all line length issues to meet EditorConfig requirements - Added .mega-linter.yml configuration for enhanced linting * fix: address CodeRabbitAI review feedback - Split .goreleaser.yaml builds for static/dynamic linking by architecture - Update docs to accurately reflect 7 path traversal patterns (not 17) - Fix containsPathTraversal to allow valid absolute paths - Replace runnerCombinedRunWithSudoContext with RunnerCombinedOutputWithSudoContext - Fix ldflags to use uppercase Version variable name - Remove duplicate test coverage metrics in TODO.md - Fix .markdown-link-check.json schema violations - Add v8r JSON validator to pre-commit hooks * chore(ci): update workflows, switch v8r to check-jsonschema * fix: restrict static linking to amd64 only in .goreleaser.yaml - Move arm64 from static to dynamic build configuration - Static linking now only applies to linux/amd64 - Prevents build failures due to missing static libc on ARM64 - All architectures remain supported with appropriate linking * fix(ci): caching * fix(ci): python caching with pip, node with npm * fix(ci): no caching for node then * fix(ci): no requirements.txt, no cache * refactor: address code review feedback - Pin Alpine base image to v3.20 for reproducible builds - Remove redundant --platform flags in GoReleaser Docker configs - Fix unused parameters in concurrency test goroutines - Simplify string search helper using strings.Contains() - Remove redundant error checking logic in security tests --------- Signed-off-by: Ismo Vuorinen <ismo@ivuorinen.net> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
459 lines
12 KiB
Go
459 lines
12 KiB
Go
package fail2ban
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"runtime"
|
|
"strings"
|
|
"sync"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
func TestIntegrationFullLogProcessing(t *testing.T) {
|
|
// Use full anonymized log for integration testing
|
|
testLogFile := filepath.Join("testdata", "fail2ban_full.log")
|
|
|
|
// Set up test environment with test data
|
|
cleanup := setupTestLogEnvironment(t, testLogFile)
|
|
defer cleanup()
|
|
|
|
t.Run("process_full_log", testProcessFullLog)
|
|
t.Run("extract_ban_events", testExtractBanEvents)
|
|
t.Run("track_persistent_attacker", testTrackPersistentAttacker)
|
|
}
|
|
|
|
// testProcessFullLog tests processing of the entire log file
|
|
func testProcessFullLog(t *testing.T) {
|
|
start := time.Now()
|
|
lines, err := GetLogLines("", "")
|
|
duration := time.Since(start)
|
|
|
|
if err != nil {
|
|
t.Fatalf("Failed to process full log: %v", err)
|
|
}
|
|
|
|
// Should process 481 lines
|
|
if len(lines) < 480 {
|
|
t.Errorf("Expected ~481 lines, got %d", len(lines))
|
|
}
|
|
|
|
// Performance check - should be fast
|
|
if duration > 100*time.Millisecond {
|
|
t.Logf("Warning: Processing took %v, might need optimization", duration)
|
|
}
|
|
|
|
t.Logf("Processed %d lines in %v", len(lines), duration)
|
|
}
|
|
|
|
// testExtractBanEvents tests extraction of ban/unban events
|
|
func testExtractBanEvents(t *testing.T) {
|
|
lines, err := GetLogLines("sshd", "")
|
|
if err != nil {
|
|
t.Fatalf("Failed to get log lines: %v", err)
|
|
}
|
|
|
|
banCount, unbanCount, foundCount := countEventTypes(lines)
|
|
|
|
t.Logf("Statistics: %d found events, %d bans, %d unbans", foundCount, banCount, unbanCount)
|
|
|
|
// Verify we found real events
|
|
if banCount == 0 {
|
|
t.Error("No ban events found in full log")
|
|
}
|
|
if unbanCount == 0 {
|
|
t.Error("No unban events found in full log")
|
|
}
|
|
if foundCount == 0 {
|
|
t.Error("No found events in full log")
|
|
}
|
|
}
|
|
|
|
// testTrackPersistentAttacker tests tracking a specific attacker across the log
|
|
func testTrackPersistentAttacker(t *testing.T) {
|
|
// Track 192.168.1.100 (most frequent attacker)
|
|
lines, err := GetLogLines("", "192.168.1.100")
|
|
if err != nil {
|
|
t.Fatalf("Failed to filter by IP: %v", err)
|
|
}
|
|
|
|
// Should have multiple entries
|
|
if len(lines) < 10 {
|
|
t.Errorf("Expected multiple entries for persistent attacker, got %d", len(lines))
|
|
}
|
|
|
|
// Verify chronological order
|
|
if err := verifyChronologicalOrder(lines); err != nil {
|
|
t.Error(err)
|
|
}
|
|
}
|
|
|
|
// countEventTypes counts ban, unban, and found events in log lines
|
|
func countEventTypes(lines []string) (banCount, unbanCount, foundCount int) {
|
|
for _, line := range lines {
|
|
if strings.Contains(line, "Ban ") {
|
|
banCount++
|
|
} else if strings.Contains(line, "Unban ") {
|
|
unbanCount++
|
|
} else if strings.Contains(line, "Found ") {
|
|
foundCount++
|
|
}
|
|
}
|
|
return
|
|
}
|
|
|
|
// verifyChronologicalOrder verifies that log lines are in chronological order
|
|
func verifyChronologicalOrder(lines []string) error {
|
|
var lastTime time.Time
|
|
for _, line := range lines {
|
|
// Parse timestamp from line
|
|
parts := strings.Fields(line)
|
|
if len(parts) >= 2 {
|
|
dateStr := parts[0]
|
|
timeStr := strings.TrimSuffix(parts[1], ",")
|
|
timeStr = strings.Replace(timeStr, ",", ".", 1)
|
|
fullTime := dateStr + " " + timeStr
|
|
|
|
parsedTime, err := time.Parse("2006-01-02 15:04:05.000", fullTime)
|
|
if err == nil {
|
|
if !lastTime.IsZero() && parsedTime.Before(lastTime) {
|
|
return fmt.Errorf("log entries not in chronological order")
|
|
}
|
|
lastTime = parsedTime
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func TestIntegrationConcurrentLogReading(t *testing.T) {
|
|
// Test concurrent access to log files
|
|
testLogFile := filepath.Join("testdata", "fail2ban_sample.log")
|
|
|
|
// Set up test environment with test data
|
|
cleanup := setupTestLogEnvironment(t, testLogFile)
|
|
defer cleanup()
|
|
|
|
// Run multiple concurrent readers
|
|
var wg sync.WaitGroup
|
|
errors := make(chan error, 10)
|
|
|
|
for i := 0; i < 10; i++ {
|
|
wg.Add(1)
|
|
go func(id int) {
|
|
defer wg.Done()
|
|
|
|
// Each goroutine reads with different filters
|
|
var jail, ip string
|
|
switch id % 3 {
|
|
case 0:
|
|
jail = "sshd"
|
|
case 1:
|
|
ip = "192.168.1.100"
|
|
case 2:
|
|
jail = "sshd"
|
|
ip = "10.0.0.50"
|
|
}
|
|
|
|
lines, err := GetLogLines(jail, ip)
|
|
if err != nil {
|
|
errors <- err
|
|
return
|
|
}
|
|
|
|
if len(lines) == 0 && jail == "sshd" {
|
|
errors <- fmt.Errorf("expected log lines for sshd jail but got empty result")
|
|
}
|
|
}(i)
|
|
}
|
|
|
|
wg.Wait()
|
|
close(errors)
|
|
|
|
// Check for errors
|
|
for err := range errors {
|
|
if err != nil {
|
|
t.Errorf("Concurrent read error: %v", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestIntegrationBanRecordParsing(t *testing.T) {
|
|
// Test parsing ban records with real patterns
|
|
parser := NewBanRecordParser()
|
|
|
|
// Use dynamic dates relative to current time
|
|
now := time.Now()
|
|
future10min := now.Add(10 * time.Minute)
|
|
past1hour := now.Add(-1 * time.Hour)
|
|
past50min := now.Add(-50 * time.Minute)
|
|
|
|
// Date format used by fail2ban
|
|
dateFmt := "2006-01-02 15:04:05"
|
|
|
|
// Simulate output from fail2ban-client
|
|
realPatterns := []string{
|
|
// Current bans with different time formats
|
|
fmt.Sprintf("192.168.1.100 %s + %s remaining", now.Format(dateFmt), future10min.Format(dateFmt)),
|
|
fmt.Sprintf(
|
|
"10.0.0.50 %s + %s remaining",
|
|
now.Add(6*time.Minute).Format(dateFmt),
|
|
now.Add(16*time.Minute).Format(dateFmt),
|
|
),
|
|
fmt.Sprintf(
|
|
"172.16.0.100 %s + %s remaining",
|
|
now.Add(22*time.Minute).Format(dateFmt),
|
|
now.Add(32*time.Minute).Format(dateFmt),
|
|
),
|
|
// Already expired
|
|
fmt.Sprintf("192.168.2.100 %s + %s remaining", past1hour.Format(dateFmt), past50min.Format(dateFmt)),
|
|
}
|
|
|
|
output := strings.Join(realPatterns, "\n")
|
|
records, err := parser.ParseBanRecords(output, "sshd")
|
|
if err != nil {
|
|
t.Fatalf("Failed to parse ban records: %v", err)
|
|
}
|
|
|
|
// Should parse all records
|
|
if len(records) != 4 {
|
|
t.Errorf("Expected 4 records, got %d", len(records))
|
|
}
|
|
|
|
// Verify record details
|
|
for i, record := range records {
|
|
if record.Jail != "sshd" {
|
|
t.Errorf("Record %d: wrong jail %s", i, record.Jail)
|
|
}
|
|
|
|
if record.IP == "" {
|
|
t.Errorf("Record %d: empty IP", i)
|
|
}
|
|
|
|
if record.BannedAt.IsZero() {
|
|
t.Errorf("Record %d: zero ban time", i)
|
|
}
|
|
|
|
// Check remaining time format
|
|
if record.Remaining == "" {
|
|
t.Errorf("Record %d: empty remaining time", i)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestIntegrationCompressedLogReading(t *testing.T) {
|
|
// Test reading compressed log files
|
|
compressedLog := filepath.Join("testdata", "fail2ban_compressed.log.gz")
|
|
|
|
if _, err := os.Stat(compressedLog); os.IsNotExist(err) {
|
|
t.Skip("Compressed test data file not found:", compressedLog)
|
|
}
|
|
|
|
detector := NewGzipDetector()
|
|
|
|
// Test 1: Detect gzip file
|
|
isGzip, err := detector.IsGzipFile(compressedLog)
|
|
if err != nil {
|
|
t.Fatalf("Failed to detect gzip: %v", err)
|
|
}
|
|
if !isGzip {
|
|
t.Error("Failed to detect compressed file")
|
|
}
|
|
|
|
// Test 2: Read compressed content
|
|
scanner, cleanup, err := detector.CreateGzipAwareScanner(compressedLog)
|
|
if err != nil {
|
|
t.Fatalf("Failed to create scanner: %v", err)
|
|
}
|
|
defer cleanup()
|
|
|
|
lineCount := 0
|
|
for scanner.Scan() {
|
|
line := scanner.Text()
|
|
if line != "" {
|
|
lineCount++
|
|
}
|
|
}
|
|
|
|
if err := scanner.Err(); err != nil {
|
|
t.Fatalf("Scanner error: %v", err)
|
|
}
|
|
|
|
// Should read all lines from compressed file
|
|
if lineCount < 50 {
|
|
t.Errorf("Expected at least 50 lines from compressed file, got %d", lineCount)
|
|
}
|
|
}
|
|
|
|
func TestIntegrationParallelLogProcessing(t *testing.T) {
|
|
// Test parallel processing of multiple jails
|
|
testLogFile := filepath.Join("testdata", "fail2ban_multi_jail.log")
|
|
|
|
// Set up test environment using secure helper
|
|
cleanup := setupTestLogEnvironment(t, testLogFile)
|
|
defer cleanup()
|
|
|
|
// Process multiple jails in parallel
|
|
jails := []string{"sshd", "nginx", "postfix", "dovecot"}
|
|
ctx := context.Background()
|
|
|
|
// Use parallel processing to read logs for each jail
|
|
pool := NewWorkerPool[string, []string](4)
|
|
|
|
start := time.Now()
|
|
results, err := pool.Process(ctx, jails, func(_ context.Context, jail string) ([]string, error) {
|
|
return GetLogLines(jail, "")
|
|
})
|
|
duration := time.Since(start)
|
|
|
|
if err != nil {
|
|
t.Fatalf("Parallel processing failed: %v", err)
|
|
}
|
|
|
|
// Verify results
|
|
totalLines := 0
|
|
for i, result := range results {
|
|
if result.Error != nil {
|
|
t.Errorf("Error processing jail %s: %v", jails[i], result.Error)
|
|
continue
|
|
}
|
|
totalLines += len(result.Value)
|
|
}
|
|
|
|
t.Logf("Processed %d jails in %v, total lines: %d", len(jails), duration, totalLines)
|
|
|
|
// Should be faster than sequential
|
|
if duration > 50*time.Millisecond {
|
|
t.Logf("Warning: Parallel processing took %v", duration)
|
|
}
|
|
}
|
|
|
|
func TestIntegrationMemoryUsage(t *testing.T) {
|
|
// Test memory usage with large log processing
|
|
if testing.Short() {
|
|
t.Skip("Skipping memory test in short mode")
|
|
}
|
|
|
|
testLogFile := filepath.Join("testdata", "fail2ban_full.log")
|
|
|
|
// Set up test environment using secure helper
|
|
cleanup := setupTestLogEnvironment(t, testLogFile)
|
|
defer cleanup()
|
|
|
|
// Record initial memory stats
|
|
runtime.GC() // Force GC to get baseline
|
|
var initialStats runtime.MemStats
|
|
runtime.ReadMemStats(&initialStats)
|
|
|
|
// Process log multiple times to check for leaks
|
|
for i := 0; i < 10; i++ {
|
|
lines, err := GetLogLines("", "")
|
|
if err != nil {
|
|
t.Fatalf("Iteration %d failed: %v", i, err)
|
|
}
|
|
|
|
// Verify consistent results
|
|
if len(lines) < 480 {
|
|
t.Errorf("Iteration %d: unexpected line count %d", i, len(lines))
|
|
}
|
|
|
|
// Clear to help GC
|
|
runtime.GC()
|
|
}
|
|
|
|
// Record final memory stats and check for leaks
|
|
runtime.GC() // Force final GC
|
|
var finalStats runtime.MemStats
|
|
runtime.ReadMemStats(&finalStats)
|
|
|
|
// Calculate memory growth (handle potential negative values from GC)
|
|
var memoryGrowth uint64
|
|
if finalStats.Alloc >= initialStats.Alloc {
|
|
memoryGrowth = finalStats.Alloc - initialStats.Alloc
|
|
} else {
|
|
// Memory decreased due to GC - this is good, no leak detected
|
|
memoryGrowth = 0
|
|
}
|
|
const memoryThreshold = 10 * 1024 * 1024 // 10MB threshold
|
|
|
|
if memoryGrowth > memoryThreshold {
|
|
t.Errorf("Memory leak detected: memory grew by %d bytes (threshold: %d bytes)",
|
|
memoryGrowth, memoryThreshold)
|
|
}
|
|
|
|
t.Logf("Memory usage test passed - memory growth: %d bytes (threshold: %d bytes)",
|
|
memoryGrowth, memoryThreshold)
|
|
}
|
|
|
|
func BenchmarkLogParsing(b *testing.B) {
|
|
testLogFile := filepath.Join("testdata", "fail2ban_full.log")
|
|
|
|
// Ensure test file exists and get absolute path
|
|
absTestLogFile, err := filepath.Abs(testLogFile)
|
|
if err != nil {
|
|
b.Fatalf("Failed to get absolute path: %v", err)
|
|
}
|
|
if _, err := os.Stat(absTestLogFile); os.IsNotExist(err) {
|
|
b.Skip("Full test data file not found:", absTestLogFile)
|
|
}
|
|
|
|
// Ensure the file is within testdata directory for security
|
|
if !strings.Contains(absTestLogFile, "testdata") {
|
|
b.Fatalf("Test file must be in testdata directory: %s", absTestLogFile)
|
|
}
|
|
|
|
// Copy the test file to make it look like the main log
|
|
// (symlinks are not allowed by the security validation)
|
|
tempDir := b.TempDir()
|
|
mainLog := filepath.Join(tempDir, "fail2ban.log")
|
|
|
|
// Copy the file (don't use symlinks due to security restrictions)
|
|
// #nosec G304 - This is benchmark code reading controlled test data files
|
|
data, err := os.ReadFile(absTestLogFile)
|
|
if err != nil {
|
|
b.Fatalf("Failed to read test file: %v", err)
|
|
}
|
|
if err := os.WriteFile(mainLog, data, 0600); err != nil {
|
|
b.Fatalf("Failed to create test log: %v", err)
|
|
}
|
|
|
|
origLogDir := GetLogDir()
|
|
SetLogDir(tempDir)
|
|
defer SetLogDir(origLogDir)
|
|
|
|
b.ResetTimer()
|
|
for i := 0; i < b.N; i++ {
|
|
_, err := GetLogLines("sshd", "")
|
|
if err != nil {
|
|
b.Fatalf("Benchmark failed: %v", err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func BenchmarkBanRecordParsing(b *testing.B) {
|
|
parser := NewBanRecordParser()
|
|
|
|
// Use dynamic dates for benchmark
|
|
now := time.Now()
|
|
future := now.Add(10 * time.Minute)
|
|
dateFmt := "2006-01-02 15:04:05"
|
|
|
|
// Realistic output with 20 ban records
|
|
var records []string
|
|
for i := 0; i < 20; i++ {
|
|
records = append(records,
|
|
fmt.Sprintf("192.168.1.%d %s + %s remaining", i+100, now.Format(dateFmt), future.Format(dateFmt)))
|
|
}
|
|
output := strings.Join(records, "\n")
|
|
|
|
b.ResetTimer()
|
|
for i := 0; i < b.N; i++ {
|
|
_, err := parser.ParseBanRecords(output, "sshd")
|
|
if err != nil {
|
|
b.Fatalf("Benchmark failed: %v", err)
|
|
}
|
|
}
|
|
}
|