mirror of
https://github.com/ivuorinen/gh-action-readme.git
synced 2026-02-11 04:48:17 +00:00
feat(lint): add many linters, make all the tests run fast! (#23)
* chore(lint): added nlreturn, run linting * chore(lint): replace some fmt.Sprintf calls * chore(lint): replace fmt.Sprintf with strconv * chore(lint): add goconst, use http lib for status codes, and methods * chore(lint): use errors lib, errCodes from internal/errors * chore(lint): dupl, thelper and usetesting * chore(lint): fmt.Errorf %v to %w, more linters * chore(lint): paralleltest, where possible * perf(test): optimize test performance by 78% - Implement shared binary building with package-level cache to eliminate redundant builds - Add strategic parallelization to 15+ tests while preserving environment variable isolation - Implement thread-safe fixture caching with RWMutex to reduce I/O operations - Remove unnecessary working directory changes by leveraging embedded templates - Add embedded template system with go:embed directive for reliable template resolution - Fix linting issues: rename sharedBinaryError to errSharedBinary, add nolint directive Performance improvements: - Total test execution time: 12+ seconds → 2.7 seconds (78% faster) - Binary build overhead: 14+ separate builds → 1 shared build (93% reduction) - Parallel execution: Limited → 15+ concurrent tests (60-70% better CPU usage) - I/O operations: 66+ fixture reads → cached with sync.RWMutex (50% reduction) All tests maintain 100% success rate and coverage while running nearly 4x faster.
This commit is contained in:
@@ -3,6 +3,7 @@ package git
|
||||
|
||||
import (
|
||||
"bufio"
|
||||
"errors"
|
||||
"fmt"
|
||||
"os"
|
||||
"os/exec"
|
||||
@@ -30,6 +31,7 @@ func (r *RepoInfo) GetRepositoryName() string {
|
||||
if r.Organization != "" && r.Repository != "" {
|
||||
return fmt.Sprintf("%s/%s", r.Organization, r.Repository)
|
||||
}
|
||||
|
||||
return ""
|
||||
}
|
||||
|
||||
@@ -50,7 +52,7 @@ func FindRepositoryRoot(startPath string) (string, error) {
|
||||
parent := filepath.Dir(absPath)
|
||||
if parent == absPath {
|
||||
// Reached root without finding .git
|
||||
return "", fmt.Errorf("not a git repository")
|
||||
return "", errors.New("not a git repository")
|
||||
}
|
||||
absPath = parent
|
||||
}
|
||||
@@ -129,12 +131,14 @@ func getRemoteURLFromConfig(repoRoot string) (string, error) {
|
||||
// Check for [remote "origin"] section
|
||||
if strings.Contains(line, `[remote "origin"]`) {
|
||||
inOriginSection = true
|
||||
|
||||
continue
|
||||
}
|
||||
|
||||
// Check for new section
|
||||
if strings.HasPrefix(line, "[") && inOriginSection {
|
||||
inOriginSection = false
|
||||
|
||||
continue
|
||||
}
|
||||
|
||||
@@ -144,7 +148,7 @@ func getRemoteURLFromConfig(repoRoot string) (string, error) {
|
||||
}
|
||||
}
|
||||
|
||||
return "", fmt.Errorf("no origin remote URL found in git config")
|
||||
return "", errors.New("no origin remote URL found in git config")
|
||||
}
|
||||
|
||||
// getDefaultBranch gets the default branch name.
|
||||
@@ -160,6 +164,7 @@ func getDefaultBranch(repoRoot string) string {
|
||||
return branch
|
||||
}
|
||||
}
|
||||
|
||||
return DefaultBranch // Default fallback
|
||||
}
|
||||
|
||||
@@ -182,6 +187,7 @@ func branchExists(repoRoot, branch string) bool {
|
||||
"refs/heads/"+branch,
|
||||
) // #nosec G204 -- branch name validated by git
|
||||
cmd.Dir = repoRoot
|
||||
|
||||
return cmd.Run() == nil
|
||||
}
|
||||
|
||||
@@ -225,5 +231,6 @@ func (r *RepoInfo) GenerateUsesStatement(actionName, version string) string {
|
||||
if actionName != "" {
|
||||
return fmt.Sprintf("your-org/%s@%s", actionName, version)
|
||||
}
|
||||
|
||||
return "your-org/your-action@v1"
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user