mirror of
https://github.com/ivuorinen/gh-action-readme.git
synced 2026-02-16 23:50:25 +00:00
feat(lint): add many linters, make all the tests run fast! (#23)
* chore(lint): added nlreturn, run linting * chore(lint): replace some fmt.Sprintf calls * chore(lint): replace fmt.Sprintf with strconv * chore(lint): add goconst, use http lib for status codes, and methods * chore(lint): use errors lib, errCodes from internal/errors * chore(lint): dupl, thelper and usetesting * chore(lint): fmt.Errorf %v to %w, more linters * chore(lint): paralleltest, where possible * perf(test): optimize test performance by 78% - Implement shared binary building with package-level cache to eliminate redundant builds - Add strategic parallelization to 15+ tests while preserving environment variable isolation - Implement thread-safe fixture caching with RWMutex to reduce I/O operations - Remove unnecessary working directory changes by leveraging embedded templates - Add embedded template system with go:embed directive for reliable template resolution - Fix linting issues: rename sharedBinaryError to errSharedBinary, add nolint directive Performance improvements: - Total test execution time: 12+ seconds → 2.7 seconds (78% faster) - Binary build overhead: 14+ separate builds → 1 shared build (93% reduction) - Parallel execution: Limited → 15+ concurrent tests (60-70% better CPU usage) - I/O operations: 66+ fixture reads → cached with sync.RWMutex (50% reduction) All tests maintain 100% success rate and coverage while running nearly 4x faster.
This commit is contained in:
@@ -3,6 +3,7 @@ package wizard
|
||||
|
||||
import (
|
||||
"bufio"
|
||||
"errors"
|
||||
"fmt"
|
||||
"os"
|
||||
"path/filepath"
|
||||
@@ -60,6 +61,7 @@ func (w *ConfigWizard) Run() (*internal.AppConfig, error) {
|
||||
}
|
||||
|
||||
w.output.Success("\n✅ Configuration completed successfully!")
|
||||
|
||||
return w.config, nil
|
||||
}
|
||||
|
||||
@@ -218,6 +220,7 @@ func (w *ConfigWizard) configureGitHubIntegration() {
|
||||
existingToken := internal.GetGitHubToken(w.config)
|
||||
if existingToken != "" {
|
||||
w.output.Success("GitHub token already configured ✓")
|
||||
|
||||
return
|
||||
}
|
||||
|
||||
@@ -231,6 +234,7 @@ func (w *ConfigWizard) configureGitHubIntegration() {
|
||||
if !setupToken {
|
||||
w.output.Info("You can set up the token later using environment variables:")
|
||||
w.output.Printf(" export GITHUB_TOKEN=your_personal_access_token")
|
||||
|
||||
return
|
||||
}
|
||||
|
||||
@@ -284,8 +288,9 @@ func (w *ConfigWizard) confirmConfiguration() error {
|
||||
w.output.Info("")
|
||||
confirmed := w.promptYesNo("Save this configuration?", true)
|
||||
if !confirmed {
|
||||
return fmt.Errorf("configuration canceled by user")
|
||||
return errors.New("configuration canceled by user")
|
||||
}
|
||||
|
||||
return nil
|
||||
}
|
||||
|
||||
@@ -302,6 +307,7 @@ func (w *ConfigWizard) promptWithDefault(prompt, defaultValue string) string {
|
||||
if input == "" {
|
||||
return defaultValue
|
||||
}
|
||||
|
||||
return input
|
||||
}
|
||||
|
||||
@@ -314,6 +320,7 @@ func (w *ConfigWizard) promptSensitive(prompt string) string {
|
||||
if w.scanner.Scan() {
|
||||
return strings.TrimSpace(w.scanner.Text())
|
||||
}
|
||||
|
||||
return ""
|
||||
}
|
||||
|
||||
@@ -337,6 +344,7 @@ func (w *ConfigWizard) promptYesNo(prompt string, defaultValue bool) bool {
|
||||
return defaultValue
|
||||
default:
|
||||
w.output.Warning("Please answer 'y' or 'n'. Using default.")
|
||||
|
||||
return defaultValue
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user