chore: even more linting, test fixes (#24)

* chore(lint): funcorder

* chore(lint): yamlfmt, ignored broken test yaml files

* chore(tests): tests do not output garbage, add coverage

* chore(lint): fix editorconfig violations

* chore(lint): move from eclint to editorconfig-checker

* chore(lint): add pre-commit, run and fix

* chore(ci): we use renovate to manage updates

internal/configuration_loader.go

@@ -108,6 +108,77 @@ func (cl *ConfigurationLoader) LoadConfiguration(configFile, repoRoot, actionDir
 	return config, nil
 }
 
+// LoadGlobalConfig loads only the global configuration.
+func (cl *ConfigurationLoader) LoadGlobalConfig(configFile string) (*AppConfig, error) {
+	return cl.loadGlobalConfig(configFile)
+}
+
+// ValidateConfiguration validates a configuration for consistency and required values.
+func (cl *ConfigurationLoader) ValidateConfiguration(config *AppConfig) error {
+	if config == nil {
+		return errors.New("configuration cannot be nil")
+	}
+
+	// Validate output format
+	validFormats := []string{"md", "html", "json", "asciidoc"}
+	if !containsString(validFormats, config.OutputFormat) {
+		return fmt.Errorf("invalid output format '%s', must be one of: %s",
+			config.OutputFormat, strings.Join(validFormats, ", "))
+	}
+
+	// Validate theme (if set)
+	if config.Theme != "" {
+		if err := cl.validateTheme(config.Theme); err != nil {
+			return fmt.Errorf("invalid theme: %w", err)
+		}
+	}
+
+	// Validate output directory
+	if config.OutputDir == "" {
+		return errors.New("output directory cannot be empty")
+	}
+
+	// Validate mutually exclusive flags
+	if config.Verbose && config.Quiet {
+		return errors.New("verbose and quiet flags are mutually exclusive")
+	}
+
+	return nil
+}
+
+// containsString checks if a slice contains a string.
+func containsString(slice []string, str string) bool {
+	for _, s := range slice {
+		if s == str {
+			return true
+		}
+	}
+
+	return false
+}
+
+// GetConfigurationSources returns the currently enabled configuration sources.
+func (cl *ConfigurationLoader) GetConfigurationSources() []ConfigurationSource {
+	var sources []ConfigurationSource
+	for source, enabled := range cl.sources {
+		if enabled {
+			sources = append(sources, source)
+		}
+	}
+
+	return sources
+}
+
+// EnableSource enables a specific configuration source.
+func (cl *ConfigurationLoader) EnableSource(source ConfigurationSource) {
+	cl.sources[source] = true
+}
+
+// DisableSource disables a specific configuration source.
+func (cl *ConfigurationLoader) DisableSource(source ConfigurationSource) {
+	cl.sources[source] = false
+}
+
 // loadDefaultsStep loads default configuration values.
 func (cl *ConfigurationLoader) loadDefaultsStep(config *AppConfig) {
 	if cl.sources[SourceDefaults] {
@@ -177,44 +248,6 @@ func (cl *ConfigurationLoader) loadEnvironmentStep(config *AppConfig) {
 	}
 }
 
-// LoadGlobalConfig loads only the global configuration.
-func (cl *ConfigurationLoader) LoadGlobalConfig(configFile string) (*AppConfig, error) {
-	return cl.loadGlobalConfig(configFile)
-}
-
-// ValidateConfiguration validates a configuration for consistency and required values.
-func (cl *ConfigurationLoader) ValidateConfiguration(config *AppConfig) error {
-	if config == nil {
-		return errors.New("configuration cannot be nil")
-	}
-
-	// Validate output format
-	validFormats := []string{"md", "html", "json", "asciidoc"}
-	if !containsString(validFormats, config.OutputFormat) {
-		return fmt.Errorf("invalid output format '%s', must be one of: %s",
-			config.OutputFormat, strings.Join(validFormats, ", "))
-	}
-
-	// Validate theme (if set)
-	if config.Theme != "" {
-		if err := cl.validateTheme(config.Theme); err != nil {
-			return fmt.Errorf("invalid theme: %w", err)
-		}
-	}
-
-	// Validate output directory
-	if config.OutputDir == "" {
-		return errors.New("output directory cannot be empty")
-	}
-
-	// Validate mutually exclusive flags
-	if config.Verbose && config.Quiet {
-		return errors.New("verbose and quiet flags are mutually exclusive")
-	}
-
-	return nil
-}
-
 // loadGlobalConfig initializes and loads the global configuration using Viper.
 func (cl *ConfigurationLoader) loadGlobalConfig(configFile string) (*AppConfig, error) {
 	v := viper.New()
@@ -396,39 +429,6 @@ func (cl *ConfigurationLoader) validateTheme(theme string) error {
 		theme, strings.Join(supportedThemes, ", "))
 }
 
-// containsString checks if a slice contains a string.
-func containsString(slice []string, str string) bool {
-	for _, s := range slice {
-		if s == str {
-			return true
-		}
-	}
-
-	return false
-}
-
-// GetConfigurationSources returns the currently enabled configuration sources.
-func (cl *ConfigurationLoader) GetConfigurationSources() []ConfigurationSource {
-	var sources []ConfigurationSource
-	for source, enabled := range cl.sources {
-		if enabled {
-			sources = append(sources, source)
-		}
-	}
-
-	return sources
-}
-
-// EnableSource enables a specific configuration source.
-func (cl *ConfigurationLoader) EnableSource(source ConfigurationSource) {
-	cl.sources[source] = true
-}
-
-// DisableSource disables a specific configuration source.
-func (cl *ConfigurationLoader) DisableSource(source ConfigurationSource) {
-	cl.sources[source] = false
-}
-
 // String returns a string representation of a ConfigurationSource.
 func (s ConfigurationSource) String() string {
 	switch s {