refactor: major codebase improvements and test framework overhaul

This commit represents a comprehensive refactoring of the codebase focused on
improving code quality, testability, and maintainability.

Key improvements:
- Implement dependency injection and interface-based architecture
- Add comprehensive test framework with fixtures and test suites
- Fix all linting issues (errcheck, gosec, staticcheck, goconst, etc.)
- Achieve full EditorConfig compliance across all files
- Replace hardcoded test data with proper fixture files
- Add configuration loader with hierarchical config support
- Improve error handling with contextual information
- Add progress indicators for better user feedback
- Enhance Makefile with help system and improved editorconfig commands
- Consolidate constants and remove deprecated code
- Strengthen validation logic for GitHub Actions
- Add focused consumer interfaces for better separation of concerns

Testing improvements:
- Add comprehensive integration tests
- Implement test executor pattern for better test organization
- Create extensive YAML fixture library for testing
- Fix all failing tests and improve test coverage
- Add validation test fixtures to avoid embedded YAML in Go files

Build and tooling:
- Update Makefile to show help by default
- Fix editorconfig commands to use eclint properly
- Add comprehensive help documentation to all make targets
- Improve file selection patterns to avoid glob errors

This refactoring maintains backward compatibility while significantly
improving the internal architecture and developer experience.
This commit is contained in:
2025-08-05 23:20:58 +03:00
parent f9823eef3e
commit f94967713a
93 changed files with 8845 additions and 1224 deletions

View File

@@ -313,6 +313,43 @@ func TestCache_Clear(t *testing.T) {
}
}
func TestCache_Delete(t *testing.T) {
tmpDir, cleanup := testutil.TempDir(t)
defer cleanup()
cache := createTestCache(t, tmpDir)
defer func() { _ = cache.Close() }()
// Add some data
_ = cache.Set("key1", "value1")
_ = cache.Set("key2", "value2")
_ = cache.Set("key3", "value3")
// Verify data exists
_, exists := cache.Get("key1")
if !exists {
t.Fatal("expected key1 to exist before delete")
}
// Delete specific key
cache.Delete("key1")
// Verify deleted key is gone but others remain
_, exists1 := cache.Get("key1")
_, exists2 := cache.Get("key2")
_, exists3 := cache.Get("key3")
if exists1 {
t.Error("expected key1 to be deleted")
}
if !exists2 || !exists3 {
t.Error("expected key2 and key3 to still exist")
}
// Test deleting non-existent key (should not panic)
cache.Delete("nonexistent")
}
func TestCache_Stats(t *testing.T) {
tmpDir, cleanup := testutil.TempDir(t)
defer cleanup()
@@ -320,6 +357,9 @@ func TestCache_Stats(t *testing.T) {
cache := createTestCache(t, tmpDir)
defer func() { _ = cache.Close() }()
// Ensure cache starts clean
_ = cache.Clear()
// Add some data
_ = cache.Set("key1", "value1")
_ = cache.Set("key2", "larger-value-with-more-content")