refactor: major codebase improvements and test framework overhaul

This commit represents a comprehensive refactoring of the codebase focused on
improving code quality, testability, and maintainability.

Key improvements:
- Implement dependency injection and interface-based architecture
- Add comprehensive test framework with fixtures and test suites
- Fix all linting issues (errcheck, gosec, staticcheck, goconst, etc.)
- Achieve full EditorConfig compliance across all files
- Replace hardcoded test data with proper fixture files
- Add configuration loader with hierarchical config support
- Improve error handling with contextual information
- Add progress indicators for better user feedback
- Enhance Makefile with help system and improved editorconfig commands
- Consolidate constants and remove deprecated code
- Strengthen validation logic for GitHub Actions
- Add focused consumer interfaces for better separation of concerns

Testing improvements:
- Add comprehensive integration tests
- Implement test executor pattern for better test organization
- Create extensive YAML fixture library for testing
- Fix all failing tests and improve test coverage
- Add validation test fixtures to avoid embedded YAML in Go files

Build and tooling:
- Update Makefile to show help by default
- Fix editorconfig commands to use eclint properly
- Add comprehensive help documentation to all make targets
- Improve file selection patterns to avoid glob errors

This refactoring maintains backward compatibility while significantly
improving the internal architecture and developer experience.
This commit is contained in:
2025-08-05 23:20:58 +03:00
parent f9823eef3e
commit f94967713a
93 changed files with 8845 additions and 1224 deletions

View File

@@ -80,9 +80,7 @@ func DetectRepository(repoRoot string) (*RepoInfo, error) {
}
// Try to get default branch
if defaultBranch, err := getDefaultBranch(repoRoot); err == nil {
info.DefaultBranch = defaultBranch
}
info.DefaultBranch = getDefaultBranch(repoRoot)
return info, nil
}
@@ -114,7 +112,7 @@ func getRemoteURLFromGit(repoRoot string) (string, error) {
// getRemoteURLFromConfig parses .git/config to extract remote URL.
func getRemoteURLFromConfig(repoRoot string) (string, error) {
configPath := filepath.Join(repoRoot, ".git", "config")
file, err := os.Open(configPath)
file, err := os.Open(configPath) // #nosec G304 -- git config path constructed from repo root
if err != nil {
return "", fmt.Errorf("failed to open git config: %w", err)
}
@@ -150,7 +148,7 @@ func getRemoteURLFromConfig(repoRoot string) (string, error) {
}
// getDefaultBranch gets the default branch name.
func getDefaultBranch(repoRoot string) (string, error) {
func getDefaultBranch(repoRoot string) string {
cmd := exec.Command("git", "symbolic-ref", "refs/remotes/origin/HEAD")
cmd.Dir = repoRoot
@@ -159,24 +157,30 @@ func getDefaultBranch(repoRoot string) (string, error) {
// Fallback to common default branches
for _, branch := range []string{DefaultBranch, "master"} {
if branchExists(repoRoot, branch) {
return branch, nil
return branch
}
}
return DefaultBranch, nil // Default fallback
return DefaultBranch // Default fallback
}
// Extract branch name from refs/remotes/origin/HEAD -> refs/remotes/origin/main
parts := strings.Split(strings.TrimSpace(string(output)), "/")
if len(parts) > 0 {
return parts[len(parts)-1], nil
return parts[len(parts)-1]
}
return DefaultBranch, nil
return DefaultBranch
}
// branchExists checks if a branch exists in the repository.
func branchExists(repoRoot, branch string) bool {
cmd := exec.Command("git", "show-ref", "--verify", "--quiet", "refs/heads/"+branch)
cmd := exec.Command(
"git",
"show-ref",
"--verify",
"--quiet",
"refs/heads/"+branch,
) // #nosec G204 -- branch name validated by git
cmd.Dir = repoRoot
return cmd.Run() == nil
}