mirror of
https://github.com/ivuorinen/gh-action-readme.git
synced 2026-01-26 11:14:04 +00:00
* chore(lint): added nlreturn, run linting * chore(lint): replace some fmt.Sprintf calls * chore(lint): replace fmt.Sprintf with strconv * chore(lint): add goconst, use http lib for status codes, and methods * chore(lint): use errors lib, errCodes from internal/errors * chore(lint): dupl, thelper and usetesting * chore(lint): fmt.Errorf %v to %w, more linters * chore(lint): paralleltest, where possible * perf(test): optimize test performance by 78% - Implement shared binary building with package-level cache to eliminate redundant builds - Add strategic parallelization to 15+ tests while preserving environment variable isolation - Implement thread-safe fixture caching with RWMutex to reduce I/O operations - Remove unnecessary working directory changes by leveraging embedded templates - Add embedded template system with go:embed directive for reliable template resolution - Fix linting issues: rename sharedBinaryError to errSharedBinary, add nolint directive Performance improvements: - Total test execution time: 12+ seconds → 2.7 seconds (78% faster) - Binary build overhead: 14+ separate builds → 1 shared build (93% reduction) - Parallel execution: Limited → 15+ concurrent tests (60-70% better CPU usage) - I/O operations: 66+ fixture reads → cached with sync.RWMutex (50% reduction) All tests maintain 100% success rate and coverage while running nearly 4x faster.
142 lines
3.6 KiB
Go
142 lines
3.6 KiB
Go
package helpers
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/ivuorinen/gh-action-readme/internal"
|
|
"github.com/ivuorinen/gh-action-readme/testutil"
|
|
)
|
|
|
|
func TestCreateAnalyzer(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
tests := []struct {
|
|
name string
|
|
setupConfig func() *internal.AppConfig
|
|
expectAnalyzer bool
|
|
expectWarning bool
|
|
}{
|
|
{
|
|
name: "successful analyzer creation with valid config",
|
|
setupConfig: func() *internal.AppConfig {
|
|
return &internal.AppConfig{
|
|
Theme: "default",
|
|
OutputFormat: "md",
|
|
OutputDir: ".",
|
|
Verbose: false,
|
|
Quiet: false,
|
|
GitHubToken: "fake_token", // Provide token for analyzer creation
|
|
}
|
|
},
|
|
expectAnalyzer: true,
|
|
expectWarning: false,
|
|
},
|
|
{
|
|
name: "analyzer creation without GitHub token",
|
|
setupConfig: func() *internal.AppConfig {
|
|
return &internal.AppConfig{
|
|
Theme: "default",
|
|
OutputFormat: "md",
|
|
OutputDir: ".",
|
|
Verbose: false,
|
|
Quiet: false,
|
|
GitHubToken: "", // No token provided
|
|
}
|
|
},
|
|
expectAnalyzer: true, // Changed: analyzer might still be created but with limited functionality
|
|
expectWarning: false, // Changed: may not warn if token is optional
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
config := tt.setupConfig()
|
|
generator := internal.NewGenerator(config)
|
|
|
|
// Create output instance for testing
|
|
output := &internal.ColoredOutput{
|
|
NoColor: true,
|
|
Quiet: false,
|
|
}
|
|
|
|
analyzer := CreateAnalyzer(generator, output)
|
|
|
|
if tt.expectAnalyzer && analyzer == nil {
|
|
t.Error("expected analyzer to be created, got nil")
|
|
}
|
|
|
|
if !tt.expectAnalyzer && analyzer != nil {
|
|
t.Error("expected analyzer to be nil, got non-nil")
|
|
}
|
|
|
|
// Note: Testing warning output would require more sophisticated mocking
|
|
// of the ColoredOutput, which is beyond the scope of this basic test
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestCreateAnalyzerOrExit(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// Only test success case since failure case calls os.Exit
|
|
t.Run("successful analyzer creation", func(t *testing.T) {
|
|
config := &internal.AppConfig{
|
|
Theme: "default",
|
|
OutputFormat: "md",
|
|
OutputDir: ".",
|
|
Verbose: false,
|
|
Quiet: false,
|
|
GitHubToken: "fake_token",
|
|
}
|
|
|
|
generator := internal.NewGenerator(config)
|
|
output := &internal.ColoredOutput{
|
|
NoColor: true,
|
|
Quiet: false,
|
|
}
|
|
|
|
analyzer := CreateAnalyzerOrExit(generator, output)
|
|
|
|
if analyzer == nil {
|
|
t.Error("expected analyzer to be created, got nil")
|
|
}
|
|
})
|
|
|
|
// Note: We cannot test the failure case because it calls os.Exit(1)
|
|
// In a real-world scenario, we might refactor to return errors instead
|
|
}
|
|
|
|
func TestCreateAnalyzer_Integration(t *testing.T) {
|
|
t.Parallel()
|
|
|
|
// Test integration with actual generator functionality
|
|
tmpDir, cleanup := testutil.TempDir(t)
|
|
defer cleanup()
|
|
|
|
config := &internal.AppConfig{
|
|
Theme: "default",
|
|
OutputFormat: "md",
|
|
OutputDir: tmpDir,
|
|
Verbose: false,
|
|
Quiet: true, // Keep quiet to avoid output noise
|
|
GitHubToken: "fake_token",
|
|
}
|
|
|
|
generator := internal.NewGenerator(config)
|
|
output := internal.NewColoredOutput(true) // quiet mode
|
|
|
|
analyzer := CreateAnalyzer(generator, output)
|
|
|
|
// Verify analyzer has expected properties
|
|
if analyzer != nil {
|
|
// Basic verification that analyzer was created successfully
|
|
// More detailed testing would require examining internal state
|
|
t.Log("Analyzer created successfully")
|
|
} else {
|
|
// This might be expected if GitHub token validation fails
|
|
t.Log("Analyzer creation failed - this may be expected without valid GitHub token")
|
|
}
|
|
}
|