mirror of
https://github.com/ivuorinen/gh-action-readme.git
synced 2026-01-26 11:14:04 +00:00
Ismo Vuorinen
f94967713a
This commit represents a comprehensive refactoring of the codebase focused on improving code quality, testability, and maintainability. Key improvements: - Implement dependency injection and interface-based architecture - Add comprehensive test framework with fixtures and test suites - Fix all linting issues (errcheck, gosec, staticcheck, goconst, etc.) - Achieve full EditorConfig compliance across all files - Replace hardcoded test data with proper fixture files - Add configuration loader with hierarchical config support - Improve error handling with contextual information - Add progress indicators for better user feedback - Enhance Makefile with help system and improved editorconfig commands - Consolidate constants and remove deprecated code - Strengthen validation logic for GitHub Actions - Add focused consumer interfaces for better separation of concerns Testing improvements: - Add comprehensive integration tests - Implement test executor pattern for better test organization - Create extensive YAML fixture library for testing - Fix all failing tests and improve test coverage - Add validation test fixtures to avoid embedded YAML in Go files Build and tooling: - Update Makefile to show help by default - Fix editorconfig commands to use eclint properly - Add comprehensive help documentation to all make targets - Improve file selection patterns to avoid glob errors This refactoring maintains backward compatibility while significantly improving the internal architecture and developer experience.
36 lines
664 B
Go
36 lines
664 B
Go
package internal
|
|
|
|
import (
|
|
"os"
|
|
)
|
|
|
|
// HTMLWriter writes HTML output with optional header/footer.
|
|
type HTMLWriter struct {
|
|
Header string
|
|
Footer string
|
|
}
|
|
|
|
func (w *HTMLWriter) Write(output string, path string) error {
|
|
f, err := os.Create(path) // #nosec G304 -- path from function parameter
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer func() {
|
|
_ = f.Close() // Ignore close error in defer
|
|
}()
|
|
if w.Header != "" {
|
|
if _, err := f.WriteString(w.Header); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
if _, err := f.WriteString(output); err != nil {
|
|
return err
|
|
}
|
|
if w.Footer != "" {
|
|
if _, err := f.WriteString(w.Footer); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
return nil
|
|
}
|