mirror of
https://github.com/ivuorinen/gh-action-readme.git
synced 2026-01-26 03:04:10 +00:00
Ismo Vuorinen
ce23f93b74
* feat: detect permissions from actions * refactor(test): fix 25 SonarCloud issues by extracting test constants Resolved all SonarCloud code quality issues for PR #137: - Fixed 12 string duplication issues (S1192) - Fixed 13 naming convention issues (S100) Changes: - Centralized test constants in appconstants/test_constants.go * Added 9 parser test constants for YAML templates * Added 3 template test constants for paths and versions - Updated parser_test.go to use shared constants - Updated template_test.go to use shared constants - Renamed 13 test functions to camelCase (removed underscores) * chore: reduce code duplication * fix: implement cr fixes * chore: deduplication
103 lines
3.3 KiB
Go
103 lines
3.3 KiB
Go
package appconstants
|
|
|
|
// This file contains constants used exclusively for testing.
|
|
// These are separated from production constants to:
|
|
// - Reduce API surface pollution in the main constants file
|
|
// - Make it clear which constants are test-only
|
|
// - Improve code organization and maintainability
|
|
//
|
|
// Note: These constants must remain exported so they can be used by
|
|
// test files in other packages (e.g., internal/*_test.go, main_test.go).
|
|
|
|
// Test assertion message format templates.
|
|
const (
|
|
// TestMsgExitCode is the format for exit code mismatch assertions.
|
|
TestMsgExitCode = "expected exit code %d, got %d"
|
|
|
|
// TestMsgStdout is the format for standard output logging.
|
|
TestMsgStdout = "stdout: %s"
|
|
|
|
// TestMsgStderr is the format for standard error logging.
|
|
TestMsgStderr = "stderr: %s"
|
|
)
|
|
|
|
// Test fixture path constants.
|
|
const (
|
|
// JavaScript action fixtures.
|
|
TestFixtureJavaScriptSimple = "actions/javascript/simple.yml"
|
|
|
|
// Composite action fixtures.
|
|
TestFixtureCompositeBasic = "actions/composite/basic.yml"
|
|
TestFixtureCompositeWithDeps = "actions/composite/with-dependencies.yml"
|
|
|
|
// Docker action fixtures.
|
|
TestFixtureDockerBasic = "actions/docker/basic.yml"
|
|
|
|
// Invalid action fixtures.
|
|
TestFixtureInvalidMissingDescription = "actions/invalid/missing-description.yml"
|
|
TestFixtureInvalidInvalidUsing = "actions/invalid/invalid-using.yml"
|
|
|
|
// Minimal/other fixtures.
|
|
TestFixtureMinimalAction = "minimal-action.yml"
|
|
TestFixtureProfessionalConfig = "professional-config.yml"
|
|
TestFixtureTestCompositeAction = "test-composite-action.yml"
|
|
TestFixtureMyNewAction = "my-new-action.yml"
|
|
)
|
|
|
|
// Test file path constants.
|
|
const (
|
|
TestPathConfigYML = "config.yml"
|
|
TestPathCustomConfigYML = "custom-config.yml"
|
|
TestPathNonexistentYML = "nonexistent.yml"
|
|
)
|
|
|
|
// Test directory path constants.
|
|
const (
|
|
TestDirSubdir = "subdir"
|
|
TestDirActions = "actions"
|
|
TestDirActionsDeploy = "actions/deploy"
|
|
TestDirActionsTest = "actions/test"
|
|
TestDirActionsComposite = "actions/composite"
|
|
TestDirActionsDocker = "actions/docker"
|
|
TestDirNested = "nested"
|
|
TestDirNestedDeep = "nested/deep"
|
|
|
|
// Config directories.
|
|
TestDirConfigGhActionReadme = ".config/gh-action-readme"
|
|
TestDirDotConfig = ".config"
|
|
TestDirCacheGhActionReadme = ".cache/gh-action-readme"
|
|
)
|
|
|
|
// (Test file permission constants removed - use production constants from appconstants/constants.go)
|
|
|
|
// Test YAML content for parser tests.
|
|
const (
|
|
TestYAMLRoot = "name: root"
|
|
TestYAMLNodeModules = "name: node_modules"
|
|
TestYAMLVendor = "name: vendor"
|
|
TestYAMLGit = "name: git"
|
|
TestYAMLSrc = "name: src"
|
|
TestYAMLNested = "name: nested"
|
|
TestYAMLSub = "name: sub"
|
|
)
|
|
|
|
// Test YAML template strings for parser tests.
|
|
const (
|
|
TestActionFilePattern = "action-*.yml"
|
|
TestPermissionsHeader = "# permissions:\n"
|
|
TestActionNameLine = "name: Test Action\n"
|
|
TestDescriptionLine = "description: Test\n"
|
|
TestRunsLine = "runs:\n"
|
|
TestCompositeUsing = " using: composite\n"
|
|
TestStepsEmpty = " steps: []\n"
|
|
TestErrorFormat = "ParseActionYML() error = %v"
|
|
TestContentsRead = "# contents: read\n"
|
|
)
|
|
|
|
// Test path constants for template tests.
|
|
const (
|
|
TestRepoActionPath = "/repo/action.yml"
|
|
TestRepoBuildActionPath = "/repo/build/action.yml"
|
|
TestVersionV123 = "@v1.2.3"
|
|
)
|