feat: update go to 1.25, add permissions and envs (#49)

* chore(ci): update go to 1.25, add permissions and envs * fix(ci): update pr-lint.yml * chore: update go, fix linting * fix: tests and linting * fix(lint): lint fixes, renovate should now pass * fix: updates, security upgrades * chore: workflow updates, lint * fix: more lint, checkmake, and other fixes * fix: more lint, convert scripts to POSIX compliant * fix: simplify codeql workflow * tests: increase test coverage, fix found issues * fix(lint): editorconfig checking, add to linters * fix(lint): shellcheck, add to linters * fix(lint): apply cr comment suggestions * fix(ci): remove step-security/harden-runner * fix(lint): remove duplication, apply cr fixes * fix(ci): tests in CI/CD pipeline * chore(lint): deduplication of strings * fix(lint): apply cr comment suggestions * fix(ci): actionlint * fix(lint): apply cr comment suggestions * chore: lint, add deps management
2026-03-17 00:01:50 +00:00 · 2025-10-10 12:14:42 +03:00
parent 958f5952a0
commit 3f65b813bd
100 changed files with 6997 additions and 1225 deletions
--- a/gibidiutils/writers_test.go
+++ b/gibidiutils/writers_test.go
@@ -0,0 +1,111 @@
+// Package gibidiutils provides common utility functions for gibidify.
+package gibidiutils
+
+import (
+	"math"
+	"testing"
+)
+
+func TestSafeUint64ToInt64WithDefault(t *testing.T) {
+	tests := []struct {
+		name         string
+		value        uint64
+		defaultValue int64
+		want         int64
+	}{
+		{
+			name:         "normal value within range",
+			value:        1000,
+			defaultValue: 0,
+			want:         1000,
+		},
+		{
+			name:         "zero value",
+			value:        0,
+			defaultValue: 0,
+			want:         0,
+		},
+		{
+			name:         "max int64 exactly",
+			value:        math.MaxInt64,
+			defaultValue: 0,
+			want:         math.MaxInt64,
+		},
+		{
+			name:         "overflow with zero default clamps to max",
+			value:        math.MaxInt64 + 1,
+			defaultValue: 0,
+			want:         math.MaxInt64,
+		},
+		{
+			name:         "large overflow with zero default clamps to max",
+			value:        math.MaxUint64,
+			defaultValue: 0,
+			want:         math.MaxInt64,
+		},
+		{
+			name:         "overflow with custom default returns custom",
+			value:        math.MaxInt64 + 1,
+			defaultValue: -1,
+			want:         -1,
+		},
+		{
+			name:         "overflow with custom positive default",
+			value:        math.MaxUint64,
+			defaultValue: 12345,
+			want:         12345,
+		},
+		{
+			name:         "large value within range",
+			value:        uint64(math.MaxInt64 - 1000),
+			defaultValue: 0,
+			want:         math.MaxInt64 - 1000,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got := SafeUint64ToInt64WithDefault(tt.value, tt.defaultValue)
+			if got != tt.want {
+				t.Errorf("SafeUint64ToInt64WithDefault(%d, %d) = %d, want %d",
+					tt.value, tt.defaultValue, got, tt.want)
+			}
+		})
+	}
+}
+
+func TestSafeUint64ToInt64WithDefaultGuardrailsBehavior(t *testing.T) {
+	// Test that overflow with default=0 returns MaxInt64, not 0
+	// This is critical for back-pressure and resource monitors
+	result := SafeUint64ToInt64WithDefault(math.MaxUint64, 0)
+	if result == 0 {
+		t.Error("Overflow with default=0 returned 0, which would disable guardrails")
+	}
+	if result != math.MaxInt64 {
+		t.Errorf("Overflow with default=0 should clamp to MaxInt64, got %d", result)
+	}
+}
+
+// BenchmarkSafeUint64ToInt64WithDefault benchmarks the conversion function
+func BenchmarkSafeUint64ToInt64WithDefault(b *testing.B) {
+	b.Run("normal_value", func(b *testing.B) {
+		b.ResetTimer()
+		for i := 0; i < b.N; i++ {
+			_ = SafeUint64ToInt64WithDefault(1000, 0)
+		}
+	})
+
+	b.Run("overflow_zero_default", func(b *testing.B) {
+		b.ResetTimer()
+		for i := 0; i < b.N; i++ {
+			_ = SafeUint64ToInt64WithDefault(math.MaxUint64, 0)
+		}
+	})
+
+	b.Run("overflow_custom_default", func(b *testing.B) {
+		b.ResetTimer()
+		for i := 0; i < b.N; i++ {
+			_ = SafeUint64ToInt64WithDefault(math.MaxUint64, -1)
+		}
+	})
+}