mirror of
https://github.com/ivuorinen/gibidify.git
synced 2026-01-26 03:24:05 +00:00
* build: update Go 1.25, CI workflows, and build tooling - Upgrade to Go 1.25 - Add benchmark targets to Makefile - Implement parallel gosec execution - Lock tool versions for reproducibility - Add shellcheck directives to scripts - Update CI workflows with improved caching * refactor: migrate from golangci-lint to revive - Replace golangci-lint with revive for linting - Configure comprehensive revive rules - Fix all EditorConfig violations - Add yamllint and yamlfmt support - Remove deprecated .golangci.yml * refactor: rename utils to shared and deduplicate code - Rename utils package to shared - Add shared constants package - Deduplicate constants across packages - Address CodeRabbit review feedback * fix: resolve SonarQube issues and add safety guards - Fix all 73 SonarQube OPEN issues - Add nil guards for resourceMonitor, backpressure, metricsCollector - Implement io.Closer for headerFileReader - Propagate errors from processing helpers - Add metrics and templates packages - Improve error handling across codebase * test: improve test infrastructure and coverage - Add benchmarks for cli, fileproc, metrics - Improve test coverage for cli, fileproc, config - Refactor tests with helper functions - Add shared test constants - Fix test function naming conventions - Reduce cognitive complexity in benchmark tests * docs: update documentation and configuration examples - Update CLAUDE.md with current project state - Refresh README with new features - Add usage and configuration examples - Add SonarQube project configuration - Consolidate config.example.yaml * fix: resolve shellcheck warnings in scripts - Use ./*.go instead of *.go to prevent dash-prefixed filenames from being interpreted as options (SC2035) - Remove unreachable return statement after exit (SC2317) - Remove obsolete gibidiutils/ directory reference * chore(deps): upgrade go dependencies * chore(lint): megalinter fixes * fix: improve test coverage and fix file descriptor leaks - Add defer r.Close() to fix pipe file descriptor leaks in benchmark tests - Refactor TestProcessorConfigureFileTypes with helper functions and assertions - Refactor TestProcessorLogFinalStats with output capture and keyword verification - Use shared constants instead of literal strings (TestFilePNG, FormatMarkdown, etc.) - Reduce cognitive complexity by extracting helper functions * fix: align test comments with function names Remove underscores from test comments to match actual function names: - benchmark/benchmark_test.go (2 fixes) - fileproc/filetypes_config_test.go (4 fixes) - fileproc/filetypes_registry_test.go (6 fixes) - fileproc/processor_test.go (6 fixes) - fileproc/resource_monitor_types_test.go (4 fixes) - fileproc/writer_test.go (3 fixes) * fix: various test improvements and bug fixes - Remove duplicate maxCacheSize check in filetypes_registry_test.go - Shorten long comment in processor_test.go to stay under 120 chars - Remove flaky time.Sleep in collector_test.go, use >= 0 assertion - Close pipe reader in benchmark_test.go to fix file descriptor leak - Use ContinueOnError in flags_test.go to match ResetFlags behavior - Add nil check for p.ui in processor_workers.go before UpdateProgress - Fix resource_monitor_validation_test.go by setting hardMemoryLimitBytes directly * chore(yaml): add missing document start markers Add --- document start to YAML files to satisfy yamllint: - .github/workflows/codeql.yml - .github/workflows/build-test-publish.yml - .github/workflows/security.yml - .github/actions/setup/action.yml * fix: guard nil resourceMonitor and fix test deadlock - Guard resourceMonitor before CreateFileProcessingContext call - Add ui.UpdateProgress on emergency stop and path error returns - Fix potential deadlock in TestProcessFile using wg.Go with defer close
109 lines
3.2 KiB
Go
109 lines
3.2 KiB
Go
// Package cli provides command-line interface functionality for gibidify.
|
|
package cli
|
|
|
|
import (
|
|
"strings"
|
|
|
|
"github.com/ivuorinen/gibidify/config"
|
|
"github.com/ivuorinen/gibidify/shared"
|
|
)
|
|
|
|
// logFinalStats logs back-pressure, resource usage, and processing statistics.
|
|
func (p *Processor) logFinalStats() {
|
|
p.logBackpressureStats()
|
|
p.logResourceStats()
|
|
p.finalizeAndReportMetrics()
|
|
p.logVerboseStats()
|
|
if p.resourceMonitor != nil {
|
|
p.resourceMonitor.Close()
|
|
}
|
|
}
|
|
|
|
// logBackpressureStats logs back-pressure statistics.
|
|
func (p *Processor) logBackpressureStats() {
|
|
// Check backpressure is non-nil before dereferencing
|
|
if p.backpressure == nil {
|
|
return
|
|
}
|
|
|
|
logger := shared.GetLogger()
|
|
backpressureStats := p.backpressure.Stats()
|
|
if backpressureStats.Enabled {
|
|
logger.Infof(
|
|
"Back-pressure stats: processed=%d files, memory=%dMB/%dMB",
|
|
backpressureStats.FilesProcessed,
|
|
backpressureStats.CurrentMemoryUsage/int64(shared.BytesPerMB),
|
|
backpressureStats.MaxMemoryUsage/int64(shared.BytesPerMB),
|
|
)
|
|
}
|
|
}
|
|
|
|
// logResourceStats logs resource monitoring statistics.
|
|
func (p *Processor) logResourceStats() {
|
|
// Check resource monitoring is enabled and monitor is non-nil before dereferencing
|
|
if !config.ResourceLimitsEnabled() {
|
|
return
|
|
}
|
|
|
|
if p.resourceMonitor == nil {
|
|
return
|
|
}
|
|
|
|
logger := shared.GetLogger()
|
|
resourceStats := p.resourceMonitor.Metrics()
|
|
|
|
logger.Infof(
|
|
"Resource stats: processed=%d files, totalSize=%dMB, avgFileSize=%.2fKB, rate=%.2f files/sec",
|
|
resourceStats.FilesProcessed, resourceStats.TotalSizeProcessed/int64(shared.BytesPerMB),
|
|
resourceStats.AverageFileSize/float64(shared.BytesPerKB), resourceStats.ProcessingRate,
|
|
)
|
|
|
|
if len(resourceStats.ViolationsDetected) > 0 {
|
|
logger.Warnf("Resource violations detected: %v", resourceStats.ViolationsDetected)
|
|
}
|
|
|
|
if resourceStats.DegradationActive {
|
|
logger.Warnf("Processing completed with degradation mode active")
|
|
}
|
|
|
|
if resourceStats.EmergencyStopActive {
|
|
logger.Errorf("Processing completed with emergency stop active")
|
|
}
|
|
}
|
|
|
|
// finalizeAndReportMetrics finalizes metrics collection and displays the final report.
|
|
func (p *Processor) finalizeAndReportMetrics() {
|
|
if p.metricsCollector != nil {
|
|
p.metricsCollector.Finish()
|
|
}
|
|
|
|
if p.metricsReporter != nil {
|
|
finalReport := p.metricsReporter.ReportFinal()
|
|
if finalReport != "" && p.ui != nil {
|
|
// Use UI manager to respect NoUI flag - remove trailing newline if present
|
|
p.ui.PrintInfo("%s", strings.TrimSuffix(finalReport, "\n"))
|
|
}
|
|
}
|
|
}
|
|
|
|
// logVerboseStats logs detailed structured statistics when verbose mode is enabled.
|
|
func (p *Processor) logVerboseStats() {
|
|
if !p.flags.Verbose || p.metricsCollector == nil {
|
|
return
|
|
}
|
|
|
|
logger := shared.GetLogger()
|
|
report := p.metricsCollector.GenerateReport()
|
|
fields := map[string]any{
|
|
"total_files": report.Summary.TotalFiles,
|
|
"processed_files": report.Summary.ProcessedFiles,
|
|
"skipped_files": report.Summary.SkippedFiles,
|
|
"error_files": report.Summary.ErrorFiles,
|
|
"processing_time": report.Summary.ProcessingTime,
|
|
"files_per_second": report.Summary.FilesPerSecond,
|
|
"bytes_per_second": report.Summary.BytesPerSecond,
|
|
"memory_usage_mb": report.Summary.CurrentMemoryMB,
|
|
}
|
|
logger.WithFields(fields).Info("Processing completed with comprehensive metrics")
|
|
}
|