mirror of
https://github.com/ivuorinen/gibidify.git
synced 2026-01-26 03:24:05 +00:00
* build: update Go 1.25, CI workflows, and build tooling - Upgrade to Go 1.25 - Add benchmark targets to Makefile - Implement parallel gosec execution - Lock tool versions for reproducibility - Add shellcheck directives to scripts - Update CI workflows with improved caching * refactor: migrate from golangci-lint to revive - Replace golangci-lint with revive for linting - Configure comprehensive revive rules - Fix all EditorConfig violations - Add yamllint and yamlfmt support - Remove deprecated .golangci.yml * refactor: rename utils to shared and deduplicate code - Rename utils package to shared - Add shared constants package - Deduplicate constants across packages - Address CodeRabbit review feedback * fix: resolve SonarQube issues and add safety guards - Fix all 73 SonarQube OPEN issues - Add nil guards for resourceMonitor, backpressure, metricsCollector - Implement io.Closer for headerFileReader - Propagate errors from processing helpers - Add metrics and templates packages - Improve error handling across codebase * test: improve test infrastructure and coverage - Add benchmarks for cli, fileproc, metrics - Improve test coverage for cli, fileproc, config - Refactor tests with helper functions - Add shared test constants - Fix test function naming conventions - Reduce cognitive complexity in benchmark tests * docs: update documentation and configuration examples - Update CLAUDE.md with current project state - Refresh README with new features - Add usage and configuration examples - Add SonarQube project configuration - Consolidate config.example.yaml * fix: resolve shellcheck warnings in scripts - Use ./*.go instead of *.go to prevent dash-prefixed filenames from being interpreted as options (SC2035) - Remove unreachable return statement after exit (SC2317) - Remove obsolete gibidiutils/ directory reference * chore(deps): upgrade go dependencies * chore(lint): megalinter fixes * fix: improve test coverage and fix file descriptor leaks - Add defer r.Close() to fix pipe file descriptor leaks in benchmark tests - Refactor TestProcessorConfigureFileTypes with helper functions and assertions - Refactor TestProcessorLogFinalStats with output capture and keyword verification - Use shared constants instead of literal strings (TestFilePNG, FormatMarkdown, etc.) - Reduce cognitive complexity by extracting helper functions * fix: align test comments with function names Remove underscores from test comments to match actual function names: - benchmark/benchmark_test.go (2 fixes) - fileproc/filetypes_config_test.go (4 fixes) - fileproc/filetypes_registry_test.go (6 fixes) - fileproc/processor_test.go (6 fixes) - fileproc/resource_monitor_types_test.go (4 fixes) - fileproc/writer_test.go (3 fixes) * fix: various test improvements and bug fixes - Remove duplicate maxCacheSize check in filetypes_registry_test.go - Shorten long comment in processor_test.go to stay under 120 chars - Remove flaky time.Sleep in collector_test.go, use >= 0 assertion - Close pipe reader in benchmark_test.go to fix file descriptor leak - Use ContinueOnError in flags_test.go to match ResetFlags behavior - Add nil check for p.ui in processor_workers.go before UpdateProgress - Fix resource_monitor_validation_test.go by setting hardMemoryLimitBytes directly * chore(yaml): add missing document start markers Add --- document start to YAML files to satisfy yamllint: - .github/workflows/codeql.yml - .github/workflows/build-test-publish.yml - .github/workflows/security.yml - .github/actions/setup/action.yml * fix: guard nil resourceMonitor and fix test deadlock - Guard resourceMonitor before CreateFileProcessingContext call - Add ui.UpdateProgress on emergency stop and path error returns - Fix potential deadlock in TestProcessFile using wg.Go with defer close
202 lines
5.8 KiB
Go
202 lines
5.8 KiB
Go
// Package shared provides common utility functions.
|
|
package shared
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"io"
|
|
"strings"
|
|
)
|
|
|
|
// SafeCloseReader safely closes a reader if it implements io.Closer.
|
|
// This eliminates the duplicated closeReader methods across all writers.
|
|
func SafeCloseReader(reader io.Reader, path string) {
|
|
if closer, ok := reader.(io.Closer); ok {
|
|
if err := closer.Close(); err != nil {
|
|
LogError(
|
|
"Failed to close file reader",
|
|
WrapError(err, ErrorTypeIO, CodeIOClose, "failed to close file reader").WithFilePath(path),
|
|
)
|
|
}
|
|
}
|
|
}
|
|
|
|
// WriteWithErrorWrap performs file writing with consistent error handling.
|
|
// This centralizes the common pattern of writing strings with error wrapping.
|
|
func WriteWithErrorWrap(writer io.Writer, content, errorMsg, filePath string) error {
|
|
if _, err := writer.Write([]byte(content)); err != nil {
|
|
wrappedErr := WrapError(err, ErrorTypeIO, CodeIOWrite, errorMsg)
|
|
if filePath != "" {
|
|
wrappedErr = wrappedErr.WithFilePath(filePath)
|
|
}
|
|
|
|
return wrappedErr
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// StreamContent provides a common streaming implementation with chunk processing.
|
|
// This eliminates the similar streaming patterns across JSON and Markdown writers.
|
|
func StreamContent(
|
|
reader io.Reader,
|
|
writer io.Writer,
|
|
chunkSize int,
|
|
filePath string,
|
|
processChunk func([]byte) []byte,
|
|
) error {
|
|
buf := make([]byte, chunkSize)
|
|
for {
|
|
n, err := reader.Read(buf)
|
|
if n > 0 {
|
|
if err := writeProcessedChunk(writer, buf[:n], filePath, processChunk); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
if err == io.EOF {
|
|
break
|
|
}
|
|
if err != nil {
|
|
return wrapReadError(err, filePath)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// writeProcessedChunk processes and writes a chunk of data.
|
|
func writeProcessedChunk(writer io.Writer, chunk []byte, filePath string, processChunk func([]byte) []byte) error {
|
|
processed := chunk
|
|
if processChunk != nil {
|
|
processed = processChunk(processed)
|
|
}
|
|
if _, writeErr := writer.Write(processed); writeErr != nil {
|
|
return wrapWriteError(writeErr, filePath)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// wrapWriteError wraps a write error with context.
|
|
func wrapWriteError(err error, filePath string) error {
|
|
wrappedErr := WrapError(err, ErrorTypeIO, CodeIOWrite, "failed to write content chunk")
|
|
if filePath != "" {
|
|
//nolint:errcheck // WithFilePath error doesn't affect wrapped error integrity
|
|
wrappedErr = wrappedErr.WithFilePath(filePath)
|
|
}
|
|
|
|
return wrappedErr
|
|
}
|
|
|
|
// wrapReadError wraps a read error with context.
|
|
func wrapReadError(err error, filePath string) error {
|
|
wrappedErr := WrapError(err, ErrorTypeIO, CodeIORead, "failed to read content chunk")
|
|
if filePath != "" {
|
|
wrappedErr = wrappedErr.WithFilePath(filePath)
|
|
}
|
|
|
|
return wrappedErr
|
|
}
|
|
|
|
// EscapeForJSON escapes content for JSON output using the standard library.
|
|
// This replaces the custom escapeJSONString function with a more robust implementation.
|
|
func EscapeForJSON(content string) string {
|
|
// Use the standard library's JSON marshaling for proper escaping
|
|
jsonBytes, err := json.Marshal(content)
|
|
if err != nil {
|
|
// If marshaling fails (which is very unlikely for a string), return the original
|
|
return content
|
|
}
|
|
// Remove the surrounding quotes that json.Marshal adds
|
|
jsonStr := string(jsonBytes)
|
|
if len(jsonStr) >= 2 && jsonStr[0] == '"' && jsonStr[len(jsonStr)-1] == '"' {
|
|
return jsonStr[1 : len(jsonStr)-1]
|
|
}
|
|
|
|
return jsonStr
|
|
}
|
|
|
|
// EscapeForYAML quotes/escapes content for YAML output if needed.
|
|
// This centralizes the YAML string quoting logic.
|
|
func EscapeForYAML(content string) string {
|
|
// Quote if contains special characters, spaces, or starts with special chars
|
|
needsQuotes := strings.ContainsAny(content, " \t\n\r:{}[]|>-'\"\\") ||
|
|
strings.HasPrefix(content, "-") ||
|
|
strings.HasPrefix(content, "?") ||
|
|
strings.HasPrefix(content, ":") ||
|
|
content == "" ||
|
|
content == LiteralTrue || content == LiteralFalse ||
|
|
content == LiteralNull || content == "~"
|
|
|
|
if needsQuotes {
|
|
// Use double quotes and escape internal quotes
|
|
escaped := strings.ReplaceAll(content, "\\", "\\\\")
|
|
escaped = strings.ReplaceAll(escaped, "\"", "\\\"")
|
|
|
|
return "\"" + escaped + "\""
|
|
}
|
|
|
|
return content
|
|
}
|
|
|
|
// CheckContextCancellation is a helper function that checks if context is canceled and returns appropriate error.
|
|
func CheckContextCancellation(ctx context.Context, operation string) error {
|
|
select {
|
|
case <-ctx.Done():
|
|
return fmt.Errorf("%s canceled: %w", operation, ctx.Err())
|
|
default:
|
|
return nil
|
|
}
|
|
}
|
|
|
|
// WithContextCheck wraps an operation with context cancellation checking.
|
|
func WithContextCheck(ctx context.Context, operation string, fn func() error) error {
|
|
if err := CheckContextCancellation(ctx, operation); err != nil {
|
|
return err
|
|
}
|
|
|
|
return fn()
|
|
}
|
|
|
|
// StreamLines provides line-based streaming for YAML content.
|
|
// This provides an alternative streaming approach for YAML writers.
|
|
func StreamLines(reader io.Reader, writer io.Writer, filePath string, lineProcessor func(string) string) error {
|
|
// Read all content first (for small files this is fine)
|
|
content, err := io.ReadAll(reader)
|
|
if err != nil {
|
|
wrappedErr := WrapError(err, ErrorTypeIO, CodeIORead, "failed to read content for line processing")
|
|
if filePath != "" {
|
|
wrappedErr = wrappedErr.WithFilePath(filePath)
|
|
}
|
|
|
|
return wrappedErr
|
|
}
|
|
|
|
// Split into lines and process each
|
|
lines := strings.Split(string(content), "\n")
|
|
for i, line := range lines {
|
|
processedLine := line
|
|
if lineProcessor != nil {
|
|
processedLine = lineProcessor(line)
|
|
}
|
|
|
|
// Write line with proper line ending (except for last empty line)
|
|
lineToWrite := processedLine
|
|
if i < len(lines)-1 || line != "" {
|
|
lineToWrite += "\n"
|
|
}
|
|
|
|
if _, writeErr := writer.Write([]byte(lineToWrite)); writeErr != nil {
|
|
wrappedErr := WrapError(writeErr, ErrorTypeIO, CodeIOWrite, "failed to write processed line")
|
|
if filePath != "" {
|
|
wrappedErr = wrappedErr.WithFilePath(filePath)
|
|
}
|
|
|
|
return wrappedErr
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|