mirror of
https://github.com/ivuorinen/gibidify.git
synced 2026-01-26 03:24:05 +00:00
* build: update Go 1.25, CI workflows, and build tooling - Upgrade to Go 1.25 - Add benchmark targets to Makefile - Implement parallel gosec execution - Lock tool versions for reproducibility - Add shellcheck directives to scripts - Update CI workflows with improved caching * refactor: migrate from golangci-lint to revive - Replace golangci-lint with revive for linting - Configure comprehensive revive rules - Fix all EditorConfig violations - Add yamllint and yamlfmt support - Remove deprecated .golangci.yml * refactor: rename utils to shared and deduplicate code - Rename utils package to shared - Add shared constants package - Deduplicate constants across packages - Address CodeRabbit review feedback * fix: resolve SonarQube issues and add safety guards - Fix all 73 SonarQube OPEN issues - Add nil guards for resourceMonitor, backpressure, metricsCollector - Implement io.Closer for headerFileReader - Propagate errors from processing helpers - Add metrics and templates packages - Improve error handling across codebase * test: improve test infrastructure and coverage - Add benchmarks for cli, fileproc, metrics - Improve test coverage for cli, fileproc, config - Refactor tests with helper functions - Add shared test constants - Fix test function naming conventions - Reduce cognitive complexity in benchmark tests * docs: update documentation and configuration examples - Update CLAUDE.md with current project state - Refresh README with new features - Add usage and configuration examples - Add SonarQube project configuration - Consolidate config.example.yaml * fix: resolve shellcheck warnings in scripts - Use ./*.go instead of *.go to prevent dash-prefixed filenames from being interpreted as options (SC2035) - Remove unreachable return statement after exit (SC2317) - Remove obsolete gibidiutils/ directory reference * chore(deps): upgrade go dependencies * chore(lint): megalinter fixes * fix: improve test coverage and fix file descriptor leaks - Add defer r.Close() to fix pipe file descriptor leaks in benchmark tests - Refactor TestProcessorConfigureFileTypes with helper functions and assertions - Refactor TestProcessorLogFinalStats with output capture and keyword verification - Use shared constants instead of literal strings (TestFilePNG, FormatMarkdown, etc.) - Reduce cognitive complexity by extracting helper functions * fix: align test comments with function names Remove underscores from test comments to match actual function names: - benchmark/benchmark_test.go (2 fixes) - fileproc/filetypes_config_test.go (4 fixes) - fileproc/filetypes_registry_test.go (6 fixes) - fileproc/processor_test.go (6 fixes) - fileproc/resource_monitor_types_test.go (4 fixes) - fileproc/writer_test.go (3 fixes) * fix: various test improvements and bug fixes - Remove duplicate maxCacheSize check in filetypes_registry_test.go - Shorten long comment in processor_test.go to stay under 120 chars - Remove flaky time.Sleep in collector_test.go, use >= 0 assertion - Close pipe reader in benchmark_test.go to fix file descriptor leak - Use ContinueOnError in flags_test.go to match ResetFlags behavior - Add nil check for p.ui in processor_workers.go before UpdateProgress - Fix resource_monitor_validation_test.go by setting hardMemoryLimitBytes directly * chore(yaml): add missing document start markers Add --- document start to YAML files to satisfy yamllint: - .github/workflows/codeql.yml - .github/workflows/build-test-publish.yml - .github/workflows/security.yml - .github/actions/setup/action.yml * fix: guard nil resourceMonitor and fix test deadlock - Guard resourceMonitor before CreateFileProcessingContext call - Add ui.UpdateProgress on emergency stop and path error returns - Fix potential deadlock in TestProcessFile using wg.Go with defer close
126 lines
3.3 KiB
Go
126 lines
3.3 KiB
Go
package testutil
|
|
|
|
import (
|
|
"errors"
|
|
"os"
|
|
"testing"
|
|
)
|
|
|
|
func TestVerifyContentContains(t *testing.T) {
|
|
// Test successful verification
|
|
t.Run(
|
|
"all substrings present", func(t *testing.T) {
|
|
content := "This is a test file with multiple lines"
|
|
VerifyContentContains(t, content, []string{"test file", "multiple lines"})
|
|
// If we get here, the test passed
|
|
},
|
|
)
|
|
|
|
// Test empty expected substrings
|
|
t.Run(
|
|
"empty expected substrings", func(t *testing.T) {
|
|
content := "Any content"
|
|
VerifyContentContains(t, content, []string{})
|
|
// Should pass with no expected strings
|
|
},
|
|
)
|
|
|
|
// For failure cases, we'll test indirectly by verifying behavior
|
|
t.Run(
|
|
"verify error reporting", func(t *testing.T) {
|
|
// We can't easily test the failure case directly since it calls t.Errorf
|
|
// But we can at least verify the function doesn't panic
|
|
defer func() {
|
|
if r := recover(); r != nil {
|
|
t.Errorf("VerifyContentContains panicked: %v", r)
|
|
}
|
|
}()
|
|
|
|
// This would normally fail, but we're just checking it doesn't panic
|
|
content := "test"
|
|
expected := []string{"not found"}
|
|
// Create a subtest that we expect to fail
|
|
t.Run(
|
|
"expected_failure", func(t *testing.T) {
|
|
t.Skip("Skipping actual failure test")
|
|
VerifyContentContains(t, content, expected)
|
|
},
|
|
)
|
|
},
|
|
)
|
|
}
|
|
|
|
func TestMustSucceed(t *testing.T) {
|
|
// Test with nil error (should succeed)
|
|
t.Run(
|
|
"nil error", func(t *testing.T) {
|
|
MustSucceed(t, nil, "successful operation")
|
|
// If we get here, the test passed
|
|
},
|
|
)
|
|
|
|
// Test error behavior without causing test failure
|
|
t.Run(
|
|
"verify error handling", func(t *testing.T) {
|
|
// We can't test the failure case directly since it calls t.Fatalf
|
|
// But we can verify the function exists and is callable
|
|
defer func() {
|
|
if r := recover(); r != nil {
|
|
t.Errorf("MustSucceed panicked: %v", r)
|
|
}
|
|
}()
|
|
|
|
// Create a subtest that we expect to fail
|
|
t.Run(
|
|
"expected_failure", func(t *testing.T) {
|
|
t.Skip("Skipping actual failure test")
|
|
MustSucceed(t, errors.New("test error"), "failed operation")
|
|
},
|
|
)
|
|
},
|
|
)
|
|
}
|
|
|
|
func TestCloseFile(t *testing.T) {
|
|
// Test closing a normal file
|
|
t.Run(
|
|
"close normal file", func(t *testing.T) {
|
|
file, err := os.CreateTemp(t.TempDir(), "test")
|
|
if err != nil {
|
|
t.Fatalf("Failed to create test file: %v", err)
|
|
}
|
|
|
|
CloseFile(t, file)
|
|
|
|
// Verify file is closed by trying to write to it
|
|
_, writeErr := file.Write([]byte("test"))
|
|
if writeErr == nil {
|
|
t.Error("Expected write to fail on closed file")
|
|
}
|
|
},
|
|
)
|
|
|
|
// Test that CloseFile doesn't panic on already closed files
|
|
// Note: We can't easily test the error case without causing test failure
|
|
// since CloseFile calls t.Errorf, which is the expected behavior
|
|
t.Run(
|
|
"verify CloseFile function exists and is callable", func(t *testing.T) {
|
|
// This test just verifies the function signature and basic functionality
|
|
// The error case is tested in integration tests where failures are expected
|
|
file, err := os.CreateTemp(t.TempDir(), "test")
|
|
if err != nil {
|
|
t.Fatalf("Failed to create test file: %v", err)
|
|
}
|
|
|
|
// Test normal case - file should close successfully
|
|
CloseFile(t, file)
|
|
|
|
// Verify file is closed
|
|
_, writeErr := file.Write([]byte("test"))
|
|
if writeErr == nil {
|
|
t.Error("Expected write to fail on closed file")
|
|
}
|
|
},
|
|
)
|
|
}
|