Files
gibidify/testutil/utility_test.go
Ismo Vuorinen 95b7ef6dd3 chore: modernize workflows, security scanning, and linting configuration (#50)
* build: update Go 1.25, CI workflows, and build tooling

- Upgrade to Go 1.25
- Add benchmark targets to Makefile
- Implement parallel gosec execution
- Lock tool versions for reproducibility
- Add shellcheck directives to scripts
- Update CI workflows with improved caching

* refactor: migrate from golangci-lint to revive

- Replace golangci-lint with revive for linting
- Configure comprehensive revive rules
- Fix all EditorConfig violations
- Add yamllint and yamlfmt support
- Remove deprecated .golangci.yml

* refactor: rename utils to shared and deduplicate code

- Rename utils package to shared
- Add shared constants package
- Deduplicate constants across packages
- Address CodeRabbit review feedback

* fix: resolve SonarQube issues and add safety guards

- Fix all 73 SonarQube OPEN issues
- Add nil guards for resourceMonitor, backpressure, metricsCollector
- Implement io.Closer for headerFileReader
- Propagate errors from processing helpers
- Add metrics and templates packages
- Improve error handling across codebase

* test: improve test infrastructure and coverage

- Add benchmarks for cli, fileproc, metrics
- Improve test coverage for cli, fileproc, config
- Refactor tests with helper functions
- Add shared test constants
- Fix test function naming conventions
- Reduce cognitive complexity in benchmark tests

* docs: update documentation and configuration examples

- Update CLAUDE.md with current project state
- Refresh README with new features
- Add usage and configuration examples
- Add SonarQube project configuration
- Consolidate config.example.yaml

* fix: resolve shellcheck warnings in scripts

- Use ./*.go instead of *.go to prevent dash-prefixed filenames
  from being interpreted as options (SC2035)
- Remove unreachable return statement after exit (SC2317)
- Remove obsolete gibidiutils/ directory reference

* chore(deps): upgrade go dependencies

* chore(lint): megalinter fixes

* fix: improve test coverage and fix file descriptor leaks

- Add defer r.Close() to fix pipe file descriptor leaks in benchmark tests
- Refactor TestProcessorConfigureFileTypes with helper functions and assertions
- Refactor TestProcessorLogFinalStats with output capture and keyword verification
- Use shared constants instead of literal strings (TestFilePNG, FormatMarkdown, etc.)
- Reduce cognitive complexity by extracting helper functions

* fix: align test comments with function names

Remove underscores from test comments to match actual function names:
- benchmark/benchmark_test.go (2 fixes)
- fileproc/filetypes_config_test.go (4 fixes)
- fileproc/filetypes_registry_test.go (6 fixes)
- fileproc/processor_test.go (6 fixes)
- fileproc/resource_monitor_types_test.go (4 fixes)
- fileproc/writer_test.go (3 fixes)

* fix: various test improvements and bug fixes

- Remove duplicate maxCacheSize check in filetypes_registry_test.go
- Shorten long comment in processor_test.go to stay under 120 chars
- Remove flaky time.Sleep in collector_test.go, use >= 0 assertion
- Close pipe reader in benchmark_test.go to fix file descriptor leak
- Use ContinueOnError in flags_test.go to match ResetFlags behavior
- Add nil check for p.ui in processor_workers.go before UpdateProgress
- Fix resource_monitor_validation_test.go by setting hardMemoryLimitBytes directly

* chore(yaml): add missing document start markers

Add --- document start to YAML files to satisfy yamllint:
- .github/workflows/codeql.yml
- .github/workflows/build-test-publish.yml
- .github/workflows/security.yml
- .github/actions/setup/action.yml

* fix: guard nil resourceMonitor and fix test deadlock

- Guard resourceMonitor before CreateFileProcessingContext call
- Add ui.UpdateProgress on emergency stop and path error returns
- Fix potential deadlock in TestProcessFile using wg.Go with defer close
2025-12-10 19:07:11 +02:00

120 lines
2.3 KiB
Go

package testutil
import (
"path/filepath"
"testing"
)
// TestGetBaseName tests the GetBaseName utility function.
func TestBaseName(t *testing.T) {
tests := []struct {
name string
path string
expected string
}{
{
name: "simple filename",
path: "test.txt",
expected: "test.txt",
},
{
name: "absolute path",
path: "/path/to/file.go",
expected: "file.go",
},
{
name: "relative path",
path: "src/main.go",
expected: "main.go",
},
{
name: "nested path",
path: "/deep/nested/path/to/file.json",
expected: "file.json",
},
{
name: "path with trailing slash",
path: "/path/to/dir/",
expected: "dir",
},
{
name: "empty path",
path: "",
expected: ".",
},
{
name: "root path",
path: "/",
expected: "/",
},
{
name: "current directory",
path: ".",
expected: ".",
},
{
name: "parent directory",
path: "..",
expected: "..",
},
{
name: "hidden file",
path: "/path/to/.hidden",
expected: ".hidden",
},
{
name: "file with multiple dots",
path: "/path/file.test.go",
expected: "file.test.go",
},
{
name: "windows-style path",
path: "C:\\Windows\\System32\\file.dll",
expected: filepath.Base("C:\\Windows\\System32\\file.dll"), // Platform-specific result
},
{
name: "mixed path separators",
path: "/path\\to/file.txt",
expected: "file.txt",
},
}
for _, tt := range tests {
t.Run(
tt.name, func(t *testing.T) {
result := BaseName(tt.path)
if result != tt.expected {
t.Errorf("BaseName(%q) = %q, want %q", tt.path, result, tt.expected)
}
// Also verify against Go's filepath.Base for consistency
expected := filepath.Base(tt.path)
if result != expected {
t.Errorf(
"BaseName(%q) = %q, filepath.Base = %q, should be consistent",
tt.path, result, expected,
)
}
},
)
}
}
// BenchmarkGetBaseName benchmarks the GetBaseName function.
func BenchmarkBaseName(b *testing.B) {
testPaths := []string{
"simple.txt",
"/path/to/file.go",
"/very/deep/nested/path/to/some/file.json",
"../relative/path.txt",
"",
"/",
}
b.ResetTimer()
for i := 0; i < b.N; i++ {
path := testPaths[i%len(testPaths)]
_ = BaseName(path)
}
}