Files
gibidify/shared/conversions_test.go
Ismo Vuorinen 95b7ef6dd3 chore: modernize workflows, security scanning, and linting configuration (#50)
* build: update Go 1.25, CI workflows, and build tooling

- Upgrade to Go 1.25
- Add benchmark targets to Makefile
- Implement parallel gosec execution
- Lock tool versions for reproducibility
- Add shellcheck directives to scripts
- Update CI workflows with improved caching

* refactor: migrate from golangci-lint to revive

- Replace golangci-lint with revive for linting
- Configure comprehensive revive rules
- Fix all EditorConfig violations
- Add yamllint and yamlfmt support
- Remove deprecated .golangci.yml

* refactor: rename utils to shared and deduplicate code

- Rename utils package to shared
- Add shared constants package
- Deduplicate constants across packages
- Address CodeRabbit review feedback

* fix: resolve SonarQube issues and add safety guards

- Fix all 73 SonarQube OPEN issues
- Add nil guards for resourceMonitor, backpressure, metricsCollector
- Implement io.Closer for headerFileReader
- Propagate errors from processing helpers
- Add metrics and templates packages
- Improve error handling across codebase

* test: improve test infrastructure and coverage

- Add benchmarks for cli, fileproc, metrics
- Improve test coverage for cli, fileproc, config
- Refactor tests with helper functions
- Add shared test constants
- Fix test function naming conventions
- Reduce cognitive complexity in benchmark tests

* docs: update documentation and configuration examples

- Update CLAUDE.md with current project state
- Refresh README with new features
- Add usage and configuration examples
- Add SonarQube project configuration
- Consolidate config.example.yaml

* fix: resolve shellcheck warnings in scripts

- Use ./*.go instead of *.go to prevent dash-prefixed filenames
  from being interpreted as options (SC2035)
- Remove unreachable return statement after exit (SC2317)
- Remove obsolete gibidiutils/ directory reference

* chore(deps): upgrade go dependencies

* chore(lint): megalinter fixes

* fix: improve test coverage and fix file descriptor leaks

- Add defer r.Close() to fix pipe file descriptor leaks in benchmark tests
- Refactor TestProcessorConfigureFileTypes with helper functions and assertions
- Refactor TestProcessorLogFinalStats with output capture and keyword verification
- Use shared constants instead of literal strings (TestFilePNG, FormatMarkdown, etc.)
- Reduce cognitive complexity by extracting helper functions

* fix: align test comments with function names

Remove underscores from test comments to match actual function names:
- benchmark/benchmark_test.go (2 fixes)
- fileproc/filetypes_config_test.go (4 fixes)
- fileproc/filetypes_registry_test.go (6 fixes)
- fileproc/processor_test.go (6 fixes)
- fileproc/resource_monitor_types_test.go (4 fixes)
- fileproc/writer_test.go (3 fixes)

* fix: various test improvements and bug fixes

- Remove duplicate maxCacheSize check in filetypes_registry_test.go
- Shorten long comment in processor_test.go to stay under 120 chars
- Remove flaky time.Sleep in collector_test.go, use >= 0 assertion
- Close pipe reader in benchmark_test.go to fix file descriptor leak
- Use ContinueOnError in flags_test.go to match ResetFlags behavior
- Add nil check for p.ui in processor_workers.go before UpdateProgress
- Fix resource_monitor_validation_test.go by setting hardMemoryLimitBytes directly

* chore(yaml): add missing document start markers

Add --- document start to YAML files to satisfy yamllint:
- .github/workflows/codeql.yml
- .github/workflows/build-test-publish.yml
- .github/workflows/security.yml
- .github/actions/setup/action.yml

* fix: guard nil resourceMonitor and fix test deadlock

- Guard resourceMonitor before CreateFileProcessingContext call
- Add ui.UpdateProgress on emergency stop and path error returns
- Fix potential deadlock in TestProcessFile using wg.Go with defer close
2025-12-10 19:07:11 +02:00

322 lines
6.1 KiB
Go

package shared
import (
"math"
"testing"
)
func TestSafeUint64ToInt64(t *testing.T) {
tests := []struct {
name string
input uint64
expected int64
wantOk bool
}{
{
name: TestSafeConversion,
input: 1000,
expected: 1000,
wantOk: true,
},
{
name: "max safe value",
input: math.MaxInt64,
expected: math.MaxInt64,
wantOk: true,
},
{
name: "overflow by one",
input: math.MaxInt64 + 1,
expected: 0,
wantOk: false,
},
{
name: "max uint64 overflow",
input: math.MaxUint64,
expected: 0,
wantOk: false,
},
{
name: "zero value",
input: 0,
expected: 0,
wantOk: true,
},
}
for _, tt := range tests {
t.Run(
tt.name, func(t *testing.T) {
got, ok := SafeUint64ToInt64(tt.input)
if ok != tt.wantOk {
t.Errorf("SafeUint64ToInt64() ok = %v, want %v", ok, tt.wantOk)
}
if got != tt.expected {
t.Errorf("SafeUint64ToInt64() = %v, want %v", got, tt.expected)
}
},
)
}
}
func TestSafeIntToInt32(t *testing.T) {
tests := []struct {
name string
input int
expected int32
wantOk bool
}{
{
name: TestSafeConversion,
input: 1000,
expected: 1000,
wantOk: true,
},
{
name: "max safe value",
input: math.MaxInt32,
expected: math.MaxInt32,
wantOk: true,
},
{
name: "min safe value",
input: math.MinInt32,
expected: math.MinInt32,
wantOk: true,
},
{
name: "overflow by one",
input: math.MaxInt32 + 1,
expected: 0,
wantOk: false,
},
{
name: "underflow by one",
input: math.MinInt32 - 1,
expected: 0,
wantOk: false,
},
{
name: "zero value",
input: 0,
expected: 0,
wantOk: true,
},
}
for _, tt := range tests {
t.Run(
tt.name, func(t *testing.T) {
got, ok := SafeIntToInt32(tt.input)
if ok != tt.wantOk {
t.Errorf("SafeIntToInt32() ok = %v, want %v", ok, tt.wantOk)
}
if got != tt.expected {
t.Errorf("SafeIntToInt32() = %v, want %v", got, tt.expected)
}
},
)
}
}
func TestSafeUint64ToInt64WithDefault(t *testing.T) {
tests := []struct {
name string
input uint64
defaultValue int64
expected int64
}{
{
name: TestSafeConversion,
input: 1000,
defaultValue: -1,
expected: 1000,
},
{
name: "overflow uses default",
input: math.MaxUint64,
defaultValue: -1,
expected: -1,
},
}
for _, tt := range tests {
t.Run(
tt.name, func(t *testing.T) {
got := SafeUint64ToInt64WithDefault(tt.input, tt.defaultValue)
if got != tt.expected {
t.Errorf("SafeUint64ToInt64WithDefault() = %v, want %v", got, tt.expected)
}
},
)
}
}
func TestSafeIntToInt32WithDefault(t *testing.T) {
tests := []struct {
name string
input int
defaultValue int32
expected int32
}{
{
name: TestSafeConversion,
input: 1000,
defaultValue: -1,
expected: 1000,
},
{
name: "overflow uses default",
input: math.MaxInt32 + 1,
defaultValue: -1,
expected: -1,
},
}
for _, tt := range tests {
t.Run(
tt.name, func(t *testing.T) {
got := SafeIntToInt32WithDefault(tt.input, tt.defaultValue)
if got != tt.expected {
t.Errorf("SafeIntToInt32WithDefault() = %v, want %v", got, tt.expected)
}
},
)
}
}
func TestBytesToMB(t *testing.T) {
tests := []struct {
name string
input uint64
expected int64
}{
{
name: "zero bytes",
input: 0,
expected: 0,
},
{
name: "1MB",
input: 1024 * 1024,
expected: 1,
},
{
name: "1GB",
input: 1024 * 1024 * 1024,
expected: 1024,
},
{
name: "large value (no overflow)",
input: math.MaxUint64,
expected: 17592186044415, // MaxUint64 / 1024 / 1024, which is still within int64 range
},
}
for _, tt := range tests {
t.Run(
tt.name, func(t *testing.T) {
got := BytesToMB(tt.input)
if got != tt.expected {
t.Errorf("BytesToMB() = %v, want %v", got, tt.expected)
}
},
)
}
}
func TestBytesToMBFloat64(t *testing.T) {
tests := []struct {
name string
input uint64
expected float64
delta float64
}{
{
name: "zero bytes",
input: 0,
expected: 0,
delta: 0.0001,
},
{
name: "1MB",
input: 1024 * 1024,
expected: 1.0,
delta: 0.0001,
},
{
name: "1GB",
input: 1024 * 1024 * 1024,
expected: 1024.0,
delta: 0.0001,
},
{
name: "large value near overflow",
input: math.MaxUint64 - 1,
expected: float64((math.MaxUint64-1)/1024) / 1024.0,
delta: 1.0, // Allow larger delta for very large numbers
},
}
for _, tt := range tests {
t.Run(
tt.name, func(t *testing.T) {
got := BytesToMBFloat64(tt.input)
if math.Abs(got-tt.expected) > tt.delta {
t.Errorf("BytesToMBFloat64() = %v, want %v (±%v)", got, tt.expected, tt.delta)
}
},
)
}
}
func TestSafeMemoryDiffMB(t *testing.T) {
tests := []struct {
name string
after uint64
before uint64
expected float64
delta float64
}{
{
name: "normal increase",
after: 2 * 1024 * 1024, // 2MB
before: 1 * 1024 * 1024, // 1MB
expected: 1.0,
delta: 0.0001,
},
{
name: "no change",
after: 1 * 1024 * 1024,
before: 1 * 1024 * 1024,
expected: 0.0,
delta: 0.0001,
},
{
name: "underflow case",
after: 1 * 1024 * 1024, // 1MB
before: 2 * 1024 * 1024, // 2MB
expected: 0.0, // Should return 0 instead of negative
delta: 0.0001,
},
{
name: "large difference",
after: 2 * 1024 * 1024 * 1024, // 2GB
before: 1 * 1024 * 1024 * 1024, // 1GB
expected: 1024.0, // 1GB = 1024MB
delta: 0.0001,
},
}
for _, tt := range tests {
t.Run(
tt.name, func(t *testing.T) {
got := SafeMemoryDiffMB(tt.after, tt.before)
if math.Abs(got-tt.expected) > tt.delta {
t.Errorf("SafeMemoryDiffMB() = %v, want %v (±%v)", got, tt.expected, tt.delta)
}
},
)
}
}