Files
gibidify/shared/conversions.go
Ismo Vuorinen 95b7ef6dd3 chore: modernize workflows, security scanning, and linting configuration (#50)
* build: update Go 1.25, CI workflows, and build tooling

- Upgrade to Go 1.25
- Add benchmark targets to Makefile
- Implement parallel gosec execution
- Lock tool versions for reproducibility
- Add shellcheck directives to scripts
- Update CI workflows with improved caching

* refactor: migrate from golangci-lint to revive

- Replace golangci-lint with revive for linting
- Configure comprehensive revive rules
- Fix all EditorConfig violations
- Add yamllint and yamlfmt support
- Remove deprecated .golangci.yml

* refactor: rename utils to shared and deduplicate code

- Rename utils package to shared
- Add shared constants package
- Deduplicate constants across packages
- Address CodeRabbit review feedback

* fix: resolve SonarQube issues and add safety guards

- Fix all 73 SonarQube OPEN issues
- Add nil guards for resourceMonitor, backpressure, metricsCollector
- Implement io.Closer for headerFileReader
- Propagate errors from processing helpers
- Add metrics and templates packages
- Improve error handling across codebase

* test: improve test infrastructure and coverage

- Add benchmarks for cli, fileproc, metrics
- Improve test coverage for cli, fileproc, config
- Refactor tests with helper functions
- Add shared test constants
- Fix test function naming conventions
- Reduce cognitive complexity in benchmark tests

* docs: update documentation and configuration examples

- Update CLAUDE.md with current project state
- Refresh README with new features
- Add usage and configuration examples
- Add SonarQube project configuration
- Consolidate config.example.yaml

* fix: resolve shellcheck warnings in scripts

- Use ./*.go instead of *.go to prevent dash-prefixed filenames
  from being interpreted as options (SC2035)
- Remove unreachable return statement after exit (SC2317)
- Remove obsolete gibidiutils/ directory reference

* chore(deps): upgrade go dependencies

* chore(lint): megalinter fixes

* fix: improve test coverage and fix file descriptor leaks

- Add defer r.Close() to fix pipe file descriptor leaks in benchmark tests
- Refactor TestProcessorConfigureFileTypes with helper functions and assertions
- Refactor TestProcessorLogFinalStats with output capture and keyword verification
- Use shared constants instead of literal strings (TestFilePNG, FormatMarkdown, etc.)
- Reduce cognitive complexity by extracting helper functions

* fix: align test comments with function names

Remove underscores from test comments to match actual function names:
- benchmark/benchmark_test.go (2 fixes)
- fileproc/filetypes_config_test.go (4 fixes)
- fileproc/filetypes_registry_test.go (6 fixes)
- fileproc/processor_test.go (6 fixes)
- fileproc/resource_monitor_types_test.go (4 fixes)
- fileproc/writer_test.go (3 fixes)

* fix: various test improvements and bug fixes

- Remove duplicate maxCacheSize check in filetypes_registry_test.go
- Shorten long comment in processor_test.go to stay under 120 chars
- Remove flaky time.Sleep in collector_test.go, use >= 0 assertion
- Close pipe reader in benchmark_test.go to fix file descriptor leak
- Use ContinueOnError in flags_test.go to match ResetFlags behavior
- Add nil check for p.ui in processor_workers.go before UpdateProgress
- Fix resource_monitor_validation_test.go by setting hardMemoryLimitBytes directly

* chore(yaml): add missing document start markers

Add --- document start to YAML files to satisfy yamllint:
- .github/workflows/codeql.yml
- .github/workflows/build-test-publish.yml
- .github/workflows/security.yml
- .github/actions/setup/action.yml

* fix: guard nil resourceMonitor and fix test deadlock

- Guard resourceMonitor before CreateFileProcessingContext call
- Add ui.UpdateProgress on emergency stop and path error returns
- Fix potential deadlock in TestProcessFile using wg.Go with defer close
2025-12-10 19:07:11 +02:00

75 lines
2.2 KiB
Go

// Package shared provides common utility functions for gibidify.
package shared
import (
"math"
)
// SafeUint64ToInt64 safely converts uint64 to int64, checking for overflow.
// Returns the converted value and true if conversion is safe, or 0 and false if overflow would occur.
func SafeUint64ToInt64(value uint64) (int64, bool) {
if value > math.MaxInt64 {
return 0, false
}
return int64(value), true
}
// SafeIntToInt32 safely converts int to int32, checking for overflow.
// Returns the converted value and true if conversion is safe, or 0 and false if overflow would occur.
func SafeIntToInt32(value int) (int32, bool) {
if value > math.MaxInt32 || value < math.MinInt32 {
return 0, false
}
return int32(value), true
}
// SafeUint64ToInt64WithDefault safely converts uint64 to int64 with a default value on overflow.
func SafeUint64ToInt64WithDefault(value uint64, defaultValue int64) int64 {
if converted, ok := SafeUint64ToInt64(value); ok {
return converted
}
return defaultValue
}
// SafeIntToInt32WithDefault safely converts int to int32 with a default value on overflow.
func SafeIntToInt32WithDefault(value int, defaultValue int32) int32 {
if converted, ok := SafeIntToInt32(value); ok {
return converted
}
return defaultValue
}
// BytesToMB safely converts bytes (uint64) to megabytes (int64), handling overflow.
func BytesToMB(bytes uint64) int64 {
mb := bytes / uint64(BytesPerMB)
return SafeUint64ToInt64WithDefault(mb, math.MaxInt64)
}
// BytesToMBFloat64 safely converts bytes (uint64) to megabytes (float64), handling overflow.
func BytesToMBFloat64(bytes uint64) float64 {
const bytesPerMB = float64(BytesPerMB)
if bytes > math.MaxUint64/2 {
// Prevent overflow in arithmetic by dividing step by step
return float64(bytes/uint64(BytesPerKB)) / float64(BytesPerKB)
}
return float64(bytes) / bytesPerMB
}
// SafeMemoryDiffMB safely calculates the difference between two uint64 memory values
// and converts to MB as float64, handling potential underflow.
func SafeMemoryDiffMB(after, before uint64) float64 {
if after >= before {
diff := after - before
return BytesToMBFloat64(diff)
}
// Handle underflow case - return 0 instead of negative
return 0.0
}