ivuorinen/hiha-arvio
1
0
Fork 0
mirror of https://github.com/ivuorinen/hiha-arvio.git synced 2026-02-20 16:52:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Update GitHub workflows to handle platform-specific builds correctly

Browse Source 
Fix workflow issues preventing builds from running:

**Test Workflow (test.yml)**
- Change from solution restore to test project only
- Only restore/build HihaArvio.Tests.csproj (net8.0 target)
- Prevents iOS/macOS workload errors on Ubuntu runner
- Tests run on Ubuntu (fast, cheap, no platform dependencies)

**Build Workflow (build.yml)**
- Replace `dotnet workload install maui` with `dotnet workload restore`
- Use project-specific restore instead of solution restore
- Restore only HihaArvio.csproj for each platform job
- Add `--no-restore` flag to build commands
- More reliable workload installation

**Publish Workflow (publish.yml)**
- Replace `dotnet workload install maui` with `dotnet workload restore`
- Use project-specific restore instead of solution restore
- Add `--no-restore` flag to publish commands
- Consistent with build workflow pattern

**Why These Changes**:
1. Solution restore on Linux tries to restore iOS/macOS targets
2. This requires workloads that don't exist on Ubuntu
3. Error: "NETSDK1147: workloads must be installed: wasm-tools-net8"
4. Solution: Only restore what each platform needs
5. Test project (net8.0) works on any platform
6. MAUI projects (iOS/macOS) only on macOS runners

**Benefits**:
- Tests run successfully on Ubuntu
- Faster workload installation (restore vs install)
- More explicit about dependencies
- Avoids unnecessary multi-platform restore
- Cleaner build logs

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Ismo Vuorinen
2025-11-18 14:05:49 +02:00
parent f851716a1f
commit 571b783054
3 changed files with 20 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
.github/workflows/build.yml vendored
View File

@@ -21,14 +21,14 @@ jobs:
with:
dotnet-version: '8.0.x'
- name: Install MAUI workload
run: dotnet workload install maui --source https://api.nuget.org/v3/index.json
- name: Restore workloads
run: dotnet workload restore src/HihaArvio/HihaArvio.csproj
- name: Restore dependencies
run: dotnet restore HihaArvio.sln
run: dotnet restore src/HihaArvio/HihaArvio.csproj
- name: Build iOS
run: dotnet build src/HihaArvio/HihaArvio.csproj -f net8.0-ios -c Release /p:ArchiveOnBuild=false /p:EnableCodeSigning=false
run: dotnet build src/HihaArvio/HihaArvio.csproj -f net8.0-ios -c Release --no-restore /p:ArchiveOnBuild=false /p:EnableCodeSigning=false
- name: Upload iOS build artifacts
uses: actions/upload-artifact@v4
@@ -52,14 +52,14 @@ jobs:
with:
dotnet-version: '8.0.x'
- name: Install MAUI workload
run: dotnet workload install maui --source https://api.nuget.org/v3/index.json
- name: Restore workloads
run: dotnet workload restore src/HihaArvio/HihaArvio.csproj
- name: Restore dependencies
run: dotnet restore HihaArvio.sln
run: dotnet restore src/HihaArvio/HihaArvio.csproj
- name: Build macOS Catalyst
run: dotnet build src/HihaArvio/HihaArvio.csproj -f net8.0-maccatalyst -c Release /p:ArchiveOnBuild=false /p:EnableCodeSigning=false
run: dotnet build src/HihaArvio/HihaArvio.csproj -f net8.0-maccatalyst -c Release --no-restore /p:ArchiveOnBuild=false /p:EnableCodeSigning=false
- name: Upload macOS build artifacts
uses: actions/upload-artifact@v4