Commit Graph

5 Commits

Author SHA1 Message Date
b3d45526e0 fix: Use correct MSBuild property syntax for target framework in restore
Change from -f flag to /p:TargetFramework MSBuild property in
dotnet restore commands.

**Problem**:
- dotnet restore doesn't support -f or --framework flag
- Using -f causes error: "MSB1008: Only one project can be specified"
- MSBuild interprets "net8.0-maccatalyst" as a second project path

**Solution**:
Use MSBuild property syntax instead:
- Before: dotnet restore src/HihaArvio/HihaArvio.csproj -f net8.0-ios
- After: dotnet restore src/HihaArvio/HihaArvio.csproj /p:TargetFramework=net8.0-ios

**Why This Works**:
The /p:TargetFramework property tells restore to generate assets
specifically for that target framework and its runtime identifiers.

**Changes**:
- build.yml: Use /p:TargetFramework for iOS and macOS restores
- publish.yml: Use /p:TargetFramework for iOS and macOS restores

**Verified Locally**:
 dotnet restore /p:TargetFramework=net8.0-maccatalyst - Success

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-18 14:36:06 +02:00
6ab9fcadfb fix: Specify target framework during restore in build workflows
Add -f parameter to dotnet restore commands to ensure assets are
generated for the specific target framework being built.

**Problem**:
- dotnet restore without -f flag restores all target frameworks
- But assets file (project.assets.json) might not include runtime identifiers
- Build fails with: "Assets file doesn't have a target for 'net8.0-maccatalyst/maccatalyst-x64'"
- Error NETSDK1047 when using --no-restore flag

**Solution**:
Explicitly restore for each target framework before building:
- iOS job: dotnet restore -f net8.0-ios
- macOS job: dotnet restore -f net8.0-maccatalyst

This ensures the assets file includes the correct runtime identifiers
(iossimulator-arm64, maccatalyst-x64, etc.) needed for the build.

**Changes**:
- build.yml: Add -f to restore for iOS and macOS jobs
- publish.yml: Add -f to restore for iOS and macOS jobs
- Updated step names for clarity

**Why This Works**:
The -f flag tells restore to generate assets for that specific TFM
and its associated RuntimeIdentifiers, which the build step requires.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-18 14:22:37 +02:00
b903941a4c fix: Force net8.0 target framework in test workflow
Add -p:TargetFramework=net8.0 to all dotnet commands in test workflow
to prevent transitive restoration of iOS/macOS target frameworks.

**Problem**:
- Test project references main HihaArvio project
- Main project has multi-target frameworks (net8.0, net8.0-ios, net8.0-maccatalyst)
- Restoring test project transitively restores all target frameworks
- iOS/macOS frameworks require macOS-specific workloads
- These workloads don't exist on Ubuntu runners

**Solution**:
Add `-p:TargetFramework=net8.0` to:
- dotnet restore (only restore for net8.0)
- dotnet build (only build for net8.0)
- dotnet test (only test for net8.0)

**Verification**:
Tested locally - all 189 tests pass with this approach.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-18 14:08:13 +02:00
571b783054 fix: Update GitHub workflows to handle platform-specific builds correctly
Fix workflow issues preventing builds from running:

**Test Workflow (test.yml)**
- Change from solution restore to test project only
- Only restore/build HihaArvio.Tests.csproj (net8.0 target)
- Prevents iOS/macOS workload errors on Ubuntu runner
- Tests run on Ubuntu (fast, cheap, no platform dependencies)

**Build Workflow (build.yml)**
- Replace `dotnet workload install maui` with `dotnet workload restore`
- Use project-specific restore instead of solution restore
- Restore only HihaArvio.csproj for each platform job
- Add `--no-restore` flag to build commands
- More reliable workload installation

**Publish Workflow (publish.yml)**
- Replace `dotnet workload install maui` with `dotnet workload restore`
- Use project-specific restore instead of solution restore
- Add `--no-restore` flag to publish commands
- Consistent with build workflow pattern

**Why These Changes**:
1. Solution restore on Linux tries to restore iOS/macOS targets
2. This requires workloads that don't exist on Ubuntu
3. Error: "NETSDK1147: workloads must be installed: wasm-tools-net8"
4. Solution: Only restore what each platform needs
5. Test project (net8.0) works on any platform
6. MAUI projects (iOS/macOS) only on macOS runners

**Benefits**:
- Tests run successfully on Ubuntu
- Faster workload installation (restore vs install)
- More explicit about dependencies
- Avoids unnecessary multi-platform restore
- Cleaner build logs

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-18 14:05:49 +02:00
78b0b325a5 ci: Add GitHub workflows for test, build, and publish
Add comprehensive CI/CD workflows:

**Test Workflow (test.yml)**
- Runs on push/PR to main/develop
- Executes all 189 xUnit tests on Ubuntu runner
- Publishes test results and artifacts
- Fast and cost-effective validation

**Build Workflow (build.yml)**
- Builds for iOS and macOS Catalyst
- Runs on macOS-14 runners (Apple Silicon)
- Parallel builds for all platforms
- Uploads build artifacts (7-day retention)
- Overall build status reporting

**Publish Workflow (publish.yml)**
- Triggered by version tags (v*.*.*)
- Creates GitHub releases with changelogs
- Builds signed releases for distribution
- Uploads iOS and macOS .zip artifacts
- Supports pre-release detection (alpha/beta/rc)
- Manual workflow dispatch option

Features:
- .NET 8.0 with MAUI workload
- Parallel job execution for performance
- Artifact management and retention
- Test result reporting
- Release automation with version tracking
- Comprehensive documentation in workflows/README.md

Platforms supported:
- iOS 15.0+ (iossimulator-arm64)
- macOS 12.0+ Catalyst (maccatalyst-arm64)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-11-18 13:51:07 +02:00