refactor: replace hardcoded strings with constant references (#100)

* fix(tests): remove error_log calls and clean up ComprehensiveValidationTest

* refactor: replace hardcoded strings with MaskConstants and TestConstants references

* fix(streaming): replace overcounting '[' heuristic with proper mask detection

StreamingProcessor::getStatistics() was counting any message containing '['
as masked, causing false positives. Now checks for specific mask constants
(MASK_GENERIC, MASK_BRACKETS, MASK_REDACTED_BRACKETS) instead.

Also adds MASK_REDACTED_BRACKETS constant to MaskConstants and removes
the now-unnecessary UnusedFunctionCall psalm suppression.

* refactor(tests): replace remaining hardcoded literals with constant references

Add new constants to TestConstants (MASK_REDACTED_PLAIN, MASK_SECRET_BRACKETS,
MASK_SSN_BRACKETS, PATTERN_REDOS_NESTED_STAR, FIELD_USER_SSN, FIELD_USER_DATA)
and replace all matching literals across 21 test files.

Also removes dead memory_get_usage() call and uses existing
TestConstants::IP_ADDRESS_PUBLIC for hardcoded IP.

* fix(streaming): replace mask-token heuristic with accurate record comparison in getStatistics()

The previous implementation only detected masking when specific mask tokens
appeared in the message, missing cases where context was masked or different
mask values were used. Compare original vs processed records instead.

* refactor(tests): add PATTERN_EMAIL_SIMPLE, MASK_CARD_BRACKETS, EXPECTED_SSN_MASKED constants

Replace cross-file duplicate literals with TestConstants references:
- Email regex (4 files), '[CARD]' (2 files), 'SSN: [SSN]' (2 files)

* fix(streaming): bypass audit logger in getStatistics() by calling orchestrator directly

getStatistics() previously routed through processStream()/processChunk() which
triggered the audit logger for each record. A read-only statistics method should
not produce audit side-effects. Now calls orchestrator.process() directly and
processes records one at a time without materializing the entire iterable.

* refactor(tests): fix test quality issues and add PATTERN_CREDIT_CARD constant

- Replace fail() message that leaked sensitive terms with count-only message
- Replace bare 'EMAIL' string with MaskConstants::MASK_EMAIL for consistency
- Remove error_log() debug output from CriticalBugRegressionTest
- Add TestConstants::PATTERN_CREDIT_CARD and replace inline regex in 3 files
This commit is contained in:
2026-03-08 13:50:17 +02:00
committed by GitHub
parent e58397a75d
commit b0925ce489
51 changed files with 386 additions and 430 deletions

View File

@@ -98,14 +98,14 @@ final class AuditLoggingExceptionComprehensiveTest extends TestCase
$value = ['data' => 'test'];
$exception = AuditLoggingException::serializationFailed(
'user.data',
TestConstants::FIELD_USER_DATA,
$value,
'JSON encoding failed'
);
$this->assertInstanceOf(AuditLoggingException::class, $exception);
$message = $exception->getMessage();
$this->assertStringContainsString('user.data', $message);
$this->assertStringContainsString(TestConstants::FIELD_USER_DATA, $message);
$this->assertStringContainsString('JSON encoding failed', $message);
$this->assertStringContainsString('serialization_failure', $message);
}

View File

@@ -228,13 +228,13 @@ class CustomExceptionsTest extends TestCase
public function testAuditLoggingExceptionSerializationFailed(): void
{
$exception = AuditLoggingException::serializationFailed(
'user.data',
TestConstants::FIELD_USER_DATA,
['circular' => 'reference'],
'Circular reference detected'
);
$this->assertStringContainsString(
"Audit data serialization failed for path 'user.data'",
"Audit data serialization failed for path '" . TestConstants::FIELD_USER_DATA . "'",
$exception->getMessage()
);
$this->assertStringContainsString('Circular reference detected', $exception->getMessage());

View File

@@ -7,6 +7,7 @@ namespace Tests\Exceptions;
use Ivuorinen\MonologGdprFilter\Exceptions\MaskingOperationFailedException;
use PHPUnit\Framework\Attributes\CoversClass;
use PHPUnit\Framework\TestCase;
use Tests\TestConstants;
#[CoversClass(MaskingOperationFailedException::class)]
final class MaskingOperationFailedExceptionTest extends TestCase
@@ -77,7 +78,7 @@ final class MaskingOperationFailedExceptionTest extends TestCase
$previous = new \RuntimeException('Inner error');
$exception = MaskingOperationFailedException::fieldPathMaskingFailed(
'user.data',
TestConstants::FIELD_USER_DATA,
['complex' => 'value'],
'Failed',
$previous