Files
monolog-gdpr-filter/rector.php
Ismo Vuorinen 00c6f76c97 feat: performance, integrations, advanced features (#2)
* feat: performance, integrations, advanced features

* chore: fix linting problems

* chore: suppressions and linting

* chore(lint): pre-commit linting, fixes

* feat: comprehensive input validation, security hardening, and regression testing

- Add extensive input validation throughout codebase with proper error handling
- Implement comprehensive security hardening with ReDoS protection and bounds checking
- Add 3 new regression test suites covering critical bugs, security, and validation scenarios
- Enhance rate limiting with memory management and configurable cleanup intervals
- Update configuration security settings and improve Laravel integration
- Fix TODO.md timestamps to reflect actual development timeline
- Strengthen static analysis configuration and improve code quality standards

* feat: configure static analysis tools and enhance development workflow

- Complete configuration of Psalm, PHPStan, and Rector for harmonious static analysis.
- Fix invalid configurations and tool conflicts that prevented proper code quality analysis.
- Add comprehensive safe analysis script with interactive workflow, backup/restore
  capabilities, and dry-run modes. Update documentation with linting policy
  requiring issue resolution over suppression.
- Clean completed items from TODO to focus on actionable improvements.
- All static analysis tools now work together seamlessly to provide
  code quality insights without breaking existing functionality.

* fix(test): update Invalid regex pattern expectation

* chore: phpstan, psalm fixes

* chore: phpstan, psalm fixes, more tests

* chore: tooling tweaks, cleanup

* chore: tweaks to get the tests pass

* fix(lint): rector config tweaks and successful run

* feat: refactoring, more tests, fixes, cleanup

* chore: deduplication, use constants

* chore: psalm fixes

* chore: ignore phpstan deliberate errors in tests

* chore: improve codebase, deduplicate code

* fix: lint

* chore: deduplication, codebase simplification, sonarqube fixes

* fix: resolve SonarQube reliability rating issues

Fix useless object instantiation warnings in test files by assigning
instantiated objects to variables. This resolves the SonarQube reliability
rating issue (was C, now targeting A).

Changes:
- tests/Strategies/MaskingStrategiesTest.php: Fix 3 instances
- tests/Strategies/FieldPathMaskingStrategyTest.php: Fix 1 instance

The tests use expectException() to verify that constructors throw
exceptions for invalid input. SonarQube flagged standalone `new`
statements as useless. Fixed by assigning to variables with explicit
unset() and fail() calls.

All tests pass (623/623) and static analysis tools pass.

* fix: resolve more SonarQube detected issues

* fix: resolve psalm detected issues

* fix: resolve more SonarQube detected issues

* fix: resolve psalm detected issues

* fix: duplications

* fix: resolve SonarQube reliability rating issues

* fix: resolve psalm and phpstan detected issues
2025-10-31 13:59:01 +02:00

72 lines
2.7 KiB
PHP

<?php
declare(strict_types=1);
use Rector\Config\RectorConfig;
use Rector\Set\ValueObject\SetList;
use Rector\Php82\Rector\Class_\ReadOnlyClassRector;
use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromStrictConstructorRector;
use Rector\CodeQuality\Rector\FuncCall\SimplifyRegexPatternRector;
return RectorConfig::configure()
->withPaths([
__DIR__ . '/src',
__DIR__ . '/tests',
__DIR__ . '/examples',
__DIR__ . '/config',
])
->withPhpSets(
php82: true,
)
->withSets([
// Only use very conservative, safe rule sets
SetList::CODE_QUALITY, // Safe code quality improvements
SetList::TYPE_DECLARATION, // Type declarations (generally safe)
])
->withSkip([
// Skip risky transformations that can break existing functionality
// Skip readonly class conversion - can break existing usage
ReadOnlyClassRector::class,
// Skip automatic property typing - can break existing flexibility
TypedPropertyFromStrictConstructorRector::class,
// Skip regex pattern simplification - can break regex behavior ([0-9] vs \d with unicode)
SimplifyRegexPatternRector::class,
// Skip entire directories for certain transformations
'*/tests/*' => [
// Don't modify test methods or assertions - they have specific requirements
],
// Skip specific files that are sensitive
__DIR__ . '/src/GdprProcessor.php' => [
// Don't modify the main processor class structure
],
// Skip Laravel integration files - they have specific requirements
__DIR__ . '/src/Laravel/*' => [
// Don't modify Laravel-specific code
],
])
->withImportNames(
importNames: true,
importDocBlockNames: false, // Don't modify docblock imports - can break documentation
importShortClasses: false, // Don't import short class names - can cause conflicts
removeUnusedImports: true, // This is generally safe
)
// Conservative PHP version targeting
->withPhpVersion(80200)
// Don't use prepared sets - they're too aggressive
->withPreparedSets(
deadCode: false, // Disable dead code removal
codingStyle: false, // Disable coding style changes
earlyReturn: false, // Disable early return changes
phpunitCodeQuality: false, // Disable PHPUnit modifications
strictBooleans: false, // Disable strict boolean changes
privatization: false, // Disable privatization changes
naming: false, // Disable naming changes
typeDeclarations: false, // Disable type declaration changes
);