mirror of
https://github.com/ivuorinen/actions.git
synced 2026-01-26 03:23:59 +00:00
* feat: fixes, tweaks, new actions, linting * fix: improve docker publish loops and dotnet parsing (#193) * fix: harden action scripts and version checks (#191) * refactor: major repository restructuring and security enhancements Add comprehensive development infrastructure: - Add Makefile with automated documentation generation, formatting, and linting tasks - Add TODO.md tracking self-containment progress and repository improvements - Add .nvmrc for consistent Node.js version management - Create python-version-detect-v2 action for enhanced Python detection Enhance all GitHub Actions with standardized patterns: - Add consistent token handling across 27 actions using standardized input patterns - Implement bash error handling (set -euo pipefail) in all shell steps - Add comprehensive input validation for path traversal and command injection protection - Standardize checkout token authentication to prevent rate limiting - Remove relative action dependencies to ensure external usability Rewrite security workflow for PR-focused analysis: - Transform security-suite.yml to PR-only security analysis workflow - Remove scheduled runs, repository issue management, and Slack notifications - Implement smart comment generation showing only sections with content - Add GitHub Actions permission diff analysis and new action detection - Integrate OWASP, Semgrep, and TruffleHog for comprehensive PR security scanning Improve version detection and dependency management: - Simplify version detection actions to use inline logic instead of shared utilities - Fix Makefile version detection fallback to properly return 'main' when version not found - Update all external action references to use SHA-pinned versions - Remove deprecated run.sh in favor of Makefile automation Update documentation and project standards: - Enhance CLAUDE.md with self-containment requirements and linting standards - Update README.md with improved action descriptions and usage examples - Standardize code formatting with updated .editorconfig and .prettierrc.yml - Improve GitHub templates for issues and security reporting This refactoring ensures all 40 actions are fully self-contained and can be used independently when referenced as ivuorinen/actions/action-name@main, addressing the critical requirement for external usability while maintaining comprehensive security analysis and development automation. * feat: add automated action catalog generation system - Create generate_listing.cjs script for comprehensive action catalog - Add package.json with development tooling and npm scripts - Implement automated README.md catalog section with --update flag - Generate markdown reference-style links for all 40 actions - Add categorized tables with features, language support matrices - Replace static reference links with auto-generated dynamic links - Enable complete automation of action documentation maintenance * feat: enhance actions with improved documentation and functionality - Add comprehensive README files for 12 actions with usage examples - Implement new utility actions (go-version-detect, dotnet-version-detect) - Enhance node-setup with extensive configuration options - Improve error handling and validation across all actions - Update package.json scripts for better development workflow - Expand TODO.md with detailed roadmap and improvement plans - Standardize action structure with consistent inputs/outputs * feat: add comprehensive output handling across all actions - Add standardized outputs to 15 actions that previously had none - Implement consistent snake_case naming convention for all outputs - Add build status and test results outputs to build actions - Add files changed and status outputs to lint/fix actions - Add test execution metrics to php-tests action - Add stale/closed counts to stale action - Add release URLs and IDs to github-release action - Update documentation with output specifications - Mark comprehensive output handling task as complete in TODO.md * feat: implement shared cache strategy across all actions - Add caching to 10 actions that previously had none (Node.js, .NET, Python, Go) - Standardize 4 existing actions to use common-cache instead of direct actions/cache - Implement consistent cache-hit optimization to skip installations when cache available - Add language-specific cache configurations with appropriate key files - Create unified caching approach using ivuorinen/actions/common-cache@main - Fix YAML syntax error in php-composer action paths parameter - Update TODO.md to mark shared cache strategy as complete * feat: implement comprehensive retry logic for network operations - Create new common-retry action for standardized retry patterns with configurable strategies - Add retry logic to 9 actions missing network retry capabilities - Implement exponential backoff, custom timeouts, and flexible error handling - Add max-retries input parameter to all network-dependent actions (Node.js, .NET, Python, Go) - Standardize existing retry implementations to use common-retry utility - Update action catalog to include new common-retry action (41 total actions) - Update documentation with retry configuration examples and parameters - Mark retry logic implementation as complete in TODO.md roadmap * feat: enhance Node.js support with Corepack and Bun - Add Corepack support for automatic package manager version management - Add Bun package manager support across all Node.js actions - Improve Yarn Berry/PnP support with .yarnrc.yml detection - Add Node.js feature detection (ESM, TypeScript, frameworks) - Update package manager detection priority and lockfile support - Enhance caching with package-manager-specific keys - Update eslint, prettier, and biome actions for multi-package-manager support * fix: resolve critical runtime issues across multiple actions - Fix token validation by removing ineffective literal string comparisons - Add missing @microsoft/eslint-formatter-sarif dependency for SARIF output - Fix Bash variable syntax errors in username and changelog length checks - Update Dockerfile version regex to handle tags with suffixes (e.g., -alpine) - Simplify version selection logic with single grep command - Fix command execution in retry action with proper bash -c wrapper - Correct step output references using .outcome instead of .outputs.outcome - Add missing step IDs for version detection actions - Include go.mod in cache key files for accurate invalidation - Require minor version in all version regex patterns - Improve Bun installation security by verifying script before execution - Replace bc with sort -V for portable PHP version comparison - Remove non-existent pre-commit output references These fixes ensure proper runtime behavior, improved security, and better cross-platform compatibility across all affected actions. * fix: resolve critical runtime and security issues across actions - Fix biome-fix files_changed calculation using git diff instead of git status delta - Fix compress-images output description and add absolute path validation - Remove csharp-publish token default and fix token fallback in push commands - Add @microsoft/eslint-formatter-sarif to all package managers in eslint-check - Fix eslint-check command syntax by using variable assignment - Improve node-setup Bun installation security and remove invalid frozen-lockfile flag - Fix pre-commit token validation by removing ineffective literal comparison - Fix prettier-fix token comparison and expand regex for all GitHub token types - Add version-file-parser regex validation safety and fix csproj wildcard handling These fixes address security vulnerabilities, runtime errors, and functional issues to ensure reliable operation across all affected GitHub Actions. * feat: enhance Docker actions with advanced multi-architecture support Major enhancement to Docker build and publish actions with comprehensive multi-architecture capabilities and enterprise-grade features. Added features: - Advanced buildx configuration (version control, cache modes, build contexts) - Auto-detect platforms for dynamic architecture discovery - Performance optimizations with enhanced caching strategies - Security scanning with Trivy and image signing with Cosign - SBOM generation in multiple formats with validation - Verbose logging and dry-run modes for debugging - Platform-specific build args and fallback mechanisms Enhanced all Docker actions: - docker-build: Core buildx features and multi-arch support - docker-publish-gh: GitHub Packages with security features - docker-publish-hub: Docker Hub with scanning and signing - docker-publish: Orchestrator with unified configuration Updated documentation across all modified actions. * fix: resolve documentation generation placeholder issue Fixed Makefile and package.json to properly replace placeholder tokens in generated documentation, ensuring all README files show correct repository paths instead of ***PROJECT***@***VERSION***. * chore: simplify github token validation * chore(lint): optional yamlfmt, config and fixes * feat: use relative `uses` names * feat: comprehensive testing infrastructure and Python validation system - Migrate from tests/ to _tests/ directory structure with ShellSpec framework - Add comprehensive validation system with Python-based input validation - Implement dual testing approach (ShellSpec + pytest) for complete coverage - Add modern Python tooling (uv, ruff, pytest-cov) and dependencies - Create centralized validation rules with automatic generation system - Update project configuration and build system for new architecture - Enhance documentation to reflect current testing capabilities This establishes a robust foundation for action validation and testing with extensive coverage across all GitHub Actions in the repository. * chore: remove Dockerfile for now * chore: code review fixes * feat: comprehensive GitHub Actions restructuring and tooling improvements This commit represents a major restructuring of the GitHub Actions monorepo with improved tooling, testing infrastructure, and comprehensive PR #186 review implementation. ## Major Changes ### 🔧 Development Tooling & Configuration - **Shellcheck integration**: Exclude shellspec test files from linting - Updated .pre-commit-config.yaml to exclude _tests/*.sh from shellcheck/shfmt - Modified Makefile shellcheck pattern to skip shellspec files - Updated CLAUDE.md documentation with proper exclusion syntax - **Testing infrastructure**: Enhanced Python validation framework - Fixed nested if statements and boolean parameter issues in validation.py - Improved code quality with explicit keyword arguments - All pre-commit hooks now passing ### 🏗️ Project Structure & Documentation - **Added Serena AI integration** with comprehensive project memories: - Project overview, structure, and technical stack documentation - Code style conventions and completion requirements - Comprehensive PR #186 review analysis and implementation tracking - **Enhanced configuration**: Updated .gitignore, .yamlfmt.yml, pyproject.toml - **Improved testing**: Added integration workflows and enhanced test specs ### 🚀 GitHub Actions Improvements (30+ actions updated) - **Centralized validation**: Updated 41 validation rule files - **Enhanced actions**: Improvements across all action categories: - Setup actions (node-setup, version detectors) - Utility actions (version-file-parser, version-validator) - Linting actions (biome, eslint, terraform-lint-fix major refactor) - Build/publish actions (docker-build, npm-publish, csharp-*) - Repository management actions ### 📝 Documentation Updates - **README consistency**: Updated version references across action READMEs - **Enhanced documentation**: Improved action descriptions and usage examples - **CLAUDE.md**: Updated with current tooling and best practices ## Technical Improvements - **Security enhancements**: Input validation and sanitization improvements - **Performance optimizations**: Streamlined action logic and dependencies - **Cross-platform compatibility**: Better Windows/macOS/Linux support - **Error handling**: Improved error reporting and user feedback ## Files Changed - 100 files changed - 13 new Serena memory files documenting project state - 41 validation rules updated for consistency - 30+ GitHub Actions and READMEs improved - Core tooling configuration enhanced * feat: comprehensive GitHub Actions improvements and PR review fixes Major Infrastructure Improvements: - Add comprehensive testing framework with 17+ ShellSpec validation tests - Implement Docker-based testing tools with automated test runner - Add CodeRabbit configuration for automated code reviews - Restructure documentation and memory management system - Update validation rules for 25+ actions with enhanced input validation - Modernize CI/CD workflows and testing infrastructure Critical PR Review Fixes (All Issues Resolved): - Fix double caching in node-setup (eliminate redundant cache operations) - Optimize shell pipeline in version-file-parser (single awk vs complex pipeline) - Fix GitHub expression interpolation in prettier-check cache keys - Resolve terraform command order issue (validation after setup) - Add missing flake8-sarif dependency for Python SARIF output - Fix environment variable scope in pr-lint (export to GITHUB_ENV) Performance & Reliability: - Eliminate duplicate cache operations saving CI time - Improve shell script efficiency with optimized parsing - Fix command execution dependencies preventing runtime failures - Ensure proper dependency installation for all linting tools - Resolve workflow conditional logic issues Security & Quality: - All input validation rules updated with latest security patterns - Cross-platform compatibility improvements maintained - Comprehensive error handling and retry logic preserved - Modern development tooling and best practices adopted This commit addresses 100% of actionable feedback from PR review analysis, implements comprehensive testing infrastructure, and maintains high code quality standards across all 41 GitHub Actions. * feat: enhance expression handling and version parsing - Fix node-setup force-version expression logic for proper empty string handling - Improve version-file-parser with secure regex validation and enhanced Python detection - Add CodeRabbit configuration for CalVer versioning and README review guidance * feat(validate-inputs): implement modular validation system - Add modular validator architecture with specialized validators - Implement base validator classes for different input types - Add validators: boolean, docker, file, network, numeric, security, token, version - Add convention mapper for automatic input validation - Add comprehensive documentation for the validation system - Implement PCRE regex support and injection protection * feat(validate-inputs): add validation rules for all actions - Add YAML validation rules for 42 GitHub Actions - Auto-generated rules with convention mappings - Include metadata for validation coverage and quality indicators - Mark rules as auto-generated to prevent manual edits * test(validate-inputs): add comprehensive test suite for validators - Add unit tests for all validator modules - Add integration tests for the validation system - Add fixtures for version test data - Test coverage for boolean, docker, file, network, numeric, security, token, and version validators - Add tests for convention mapper and registry * feat(tools): add validation scripts and utilities - Add update-validators.py script for auto-generating rules - Add benchmark-validator.py for performance testing - Add debug-validator.py for troubleshooting - Add generate-tests.py for test generation - Add check-rules-not-manually-edited.sh for CI validation - Add fix-local-action-refs.py tool for fixing action references * feat(actions): add CustomValidator.py files for specialized validation - Add custom validators for actions requiring special validation logic - Implement validators for docker, go, node, npm, php, python, terraform actions - Add specialized validation for compress-images, common-cache, common-file-check - Implement version detection validators with language-specific logic - Add validation for build arguments, architectures, and version formats * test: update ShellSpec test framework for Python validation - Update all validation.spec.sh files to use Python validator - Add shared validation_core.py for common test utilities - Remove obsolete bash validation helpers - Update test output expectations for Python validator format - Add codeql-analysis test suite - Refactor framework utilities for Python integration - Remove deprecated test files * feat(actions): update action.yml files to use validate-inputs - Replace inline bash validation with validate-inputs action - Standardize validation across all 42 actions - Add new codeql-analysis action - Update action metadata and branding - Add validation step as first step in composite actions - Maintain backward compatibility with existing inputs/outputs * ci: update GitHub workflows for enhanced security and testing - Add new codeql-new.yml workflow - Update security scanning workflows - Enhance dependency review configuration - Update test-actions workflow for new validation system - Improve workflow permissions and security settings - Update action versions to latest SHA-pinned releases * build: update build configuration and dependencies - Update Makefile with new validation targets - Add Python dependencies in pyproject.toml - Update npm dependencies and scripts - Enhance Docker testing tools configuration - Add targets for validator updates and local ref fixes - Configure uv for Python package management * chore: update linting and documentation configuration - Update EditorConfig settings for consistent formatting - Enhance pre-commit hooks configuration - Update prettier and yamllint ignore patterns - Update gitleaks security scanning rules - Update CodeRabbit review configuration - Update CLAUDE.md with latest project standards and rules * docs: update Serena memory files and project metadata - Remove obsolete PR-186 memory files - Update project overview with current architecture - Update project structure documentation - Add quality standards and communication guidelines - Add modular validator architecture documentation - Add shellspec testing framework documentation - Update project.yml with latest configuration * feat: moved rules.yml to same folder as action, fixes * fix(validators): correct token patterns and fix validator bugs - Fix GitHub classic PAT pattern: ghp_ + 36 chars = 40 total - Fix GitHub fine-grained PAT pattern: github_pat_ + 71 chars = 82 total - Initialize result variable in convention_mapper to prevent UnboundLocalError - Fix empty URL validation in network validator to return error - Add GitHub expression check to docker architectures validator - Update docker-build CustomValidator parallel-builds max to 16 * test(validators): fix test fixtures and expectations - Fix token lengths in test data: github_pat 71 chars, ghp/gho 36 chars - Update integration tests with correct token lengths - Fix file validator test to expect absolute paths rejected for security - Rename TestGenerator import to avoid pytest collection warning - Update custom validator tests with correct input names - Change docker-build tests: platforms->architectures, tags->tag - Update docker-publish tests to match new registry enum validation * test(shellspec): fix token lengths in test helpers and specs - Fix default token lengths in spec_helper.sh to use correct 40-char format - Update csharp-publish default tokens in 4 locations - Update codeql-analysis default tokens in 2 locations - Fix codeql-analysis test tokens to correct lengths (40 and 82 chars) - Fix npm-publish fine-grained token test to use 82-char format * feat(actions): add permissions documentation and environment variable usage - Add permissions comments to all action.yml files documenting required GitHub permissions - Convert direct input usage to environment variables in shell steps for security - Add validation steps with proper error handling - Update input descriptions and add security notes where applicable - Ensure all actions follow consistent patterns for input validation * chore(workflows): update GitHub Actions workflow versions - Update workflow action versions to latest - Improve workflow consistency and maintainability * docs(security): add comprehensive security policy - Document security features and best practices - Add vulnerability reporting process - Include audit history and security testing information * docs(memory): add GitHub workflow reference documentation - Add GitHub Actions workflow commands reference - Add GitHub workflow expressions guide - Add secure workflow usage patterns and best practices * chore: token optimization, code style conventions * chore: cr fixes * fix: trivy reported Dockerfile problems * fix(security): more security fixes * chore: dockerfile and make targets for publishing * fix(ci): add creds to test-actions workflow * fix: security fix and checkout step to codeql-new * chore: test fixes * fix(security): codeql detected issues * chore: code review fixes, ReDos protection * style: apply MegaLinter fixes * fix(ci): missing packages read permission * fix(ci): add missing working directory setting * chore: linting, add validation-regex to use regex_pattern * chore: code review fixes * chore(deps): update actions * fix(security): codeql fixes * chore(cr): apply cr comments * chore: improve POSIX compatibility * chore(cr): apply cr comments * fix: codeql warning in Dockerfile, build failures * chore(cr): apply cr comments * fix: docker-testing-tools/Dockerfile * chore(cr): apply cr comments * fix(docker): update testing-tools image for GitHub Actions compatibility * chore(cr): apply cr comments * feat: add more tests, fix issues * chore: fix codeql issues, update actions * chore(cr): apply cr comments * fix: integration tests * chore: deduplication and fixes * style: apply MegaLinter fixes * chore(cr): apply cr comments * feat: dry-run mode for generate-tests * fix(ci): kcov installation * chore(cr): apply cr comments * chore(cr): apply cr comments * chore(cr): apply cr comments * chore(cr): apply cr comments, simplify action testing, use uv * fix: run-tests.sh action counting * chore(cr): apply cr comments * chore(cr): apply cr comments
280 lines
6.9 KiB
Markdown
280 lines
6.9 KiB
Markdown
# Security Policy
|
|
|
|
## Supported Versions
|
|
|
|
All actions in this repository are actively maintained. Security updates are applied to all actions as needed.
|
|
|
|
| Version | Supported |
|
|
|---------|--------------------|
|
|
| Latest | :white_check_mark: |
|
|
|
|
## Security Features
|
|
|
|
This repository implements multiple layers of security controls to protect against common vulnerabilities:
|
|
|
|
### 1. Script Injection Prevention
|
|
|
|
**Status**: ✅ Implemented across all 43 actions
|
|
|
|
All shell scripts use environment variables instead of direct `${{ inputs.* }}` interpolation to prevent command injection attacks.
|
|
|
|
**Before** (vulnerable):
|
|
|
|
```yaml
|
|
run: |
|
|
version="${{ inputs.version }}"
|
|
echo "Version: $version"
|
|
```
|
|
|
|
**After** (secure):
|
|
|
|
```yaml
|
|
env:
|
|
VERSION: ${{ inputs.version }}
|
|
run: |
|
|
version="$VERSION"
|
|
echo "Version: $version"
|
|
```
|
|
|
|
### 2. Secret Masking
|
|
|
|
**Status**: ✅ Implemented in 6 critical actions
|
|
|
|
Actions that handle sensitive data use GitHub Actions secret masking to prevent accidental exposure in logs:
|
|
|
|
- `npm-publish` - NPM authentication tokens
|
|
- `docker-publish-hub` - Docker Hub passwords
|
|
- `docker-publish-gh` - GitHub tokens
|
|
- `csharp-publish` - NuGet API keys
|
|
- `php-composer` - Composer authentication tokens
|
|
- `php-laravel-phpunit` - Database credentials
|
|
|
|
**Implementation**:
|
|
|
|
```yaml
|
|
run: |
|
|
echo "::add-mask::$SECRET_VALUE"
|
|
```
|
|
|
|
### 3. SHA Pinning
|
|
|
|
All third-party actions are pinned to specific commit SHAs to prevent supply chain attacks:
|
|
|
|
```yaml
|
|
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
|
|
```
|
|
|
|
### 4. Input Validation
|
|
|
|
**Status**: ✅ Centralized validation system
|
|
|
|
All actions use comprehensive input validation to prevent:
|
|
|
|
- Path traversal attacks
|
|
- Command injection patterns
|
|
- ReDoS (Regular Expression Denial of Service)
|
|
- Malformed version strings
|
|
- Invalid URLs and file paths
|
|
|
|
**Key validation patterns**:
|
|
|
|
- Version strings: Semantic versioning, CalVer, flexible formats
|
|
- File paths: Path traversal prevention, absolute path validation
|
|
- Tokens: Format validation, injection pattern detection
|
|
- Boolean values: Strict true/false validation
|
|
- URLs: Protocol validation, basic structure checks
|
|
|
|
### 5. Permissions Documentation
|
|
|
|
**Status**: ✅ All 43 actions documented
|
|
|
|
Every action includes explicit permissions comments documenting required GitHub token permissions:
|
|
|
|
```yaml
|
|
# permissions:
|
|
# - contents: write # Required for creating releases
|
|
# - packages: write # Required for publishing packages
|
|
```
|
|
|
|
### 6. Official Action Usage
|
|
|
|
Third-party security tools use official maintained actions:
|
|
|
|
- **Bun**: `oven-sh/setup-bun@v2.0.2` (SHA-pinned)
|
|
- **Trivy**: `aquasecurity/trivy-action@0.33.1` (SHA-pinned)
|
|
|
|
## Security Best Practices
|
|
|
|
When using these actions in your workflows:
|
|
|
|
### 1. Use Least Privilege
|
|
|
|
Only grant the minimum required permissions:
|
|
|
|
```yaml
|
|
permissions:
|
|
contents: write # Only if creating commits/releases
|
|
packages: write # Only if publishing packages
|
|
security-events: write # Only if uploading SARIF reports
|
|
```
|
|
|
|
### 2. Protect Secrets
|
|
|
|
- Never log sensitive values
|
|
- Use GitHub Secrets for all credentials
|
|
- Avoid exposing secrets in error messages
|
|
- Use secret masking for custom secrets
|
|
|
|
```yaml
|
|
- name: Use Secret
|
|
env:
|
|
API_KEY: ${{ secrets.API_KEY }}
|
|
run: |
|
|
echo "::add-mask::$API_KEY"
|
|
# Use API_KEY safely
|
|
```
|
|
|
|
### 3. Validate Inputs
|
|
|
|
When calling actions, validate inputs match expected patterns:
|
|
|
|
```yaml
|
|
- uses: ./version-validator
|
|
with:
|
|
version: ${{ github.event.inputs.version }}
|
|
validation-regex: '^[0-9]+\.[0-9]+\.[0-9]+$'
|
|
```
|
|
|
|
### 4. Pin Action Versions
|
|
|
|
Always use specific versions or commit SHAs:
|
|
|
|
```yaml
|
|
# Good: SHA-pinned
|
|
- uses: owner/action@abc123def456...
|
|
|
|
# Good: Specific version
|
|
- uses: owner/action@v1.2.3
|
|
|
|
# Bad: Mutable reference
|
|
- uses: owner/action@main
|
|
```
|
|
|
|
### 5. Review Action Code
|
|
|
|
Before using any action:
|
|
|
|
- Review the source code
|
|
- Check permissions requirements
|
|
- Verify input validation
|
|
- Examine shell script patterns
|
|
- Look for secret handling
|
|
|
|
## Reporting a Vulnerability
|
|
|
|
We take security vulnerabilities seriously. If you discover a security issue:
|
|
|
|
### Reporting Process
|
|
|
|
1. **DO NOT** open a public issue
|
|
2. **DO** report via GitHub Security Advisories (preferred):
|
|
- Go to the repository's Security tab
|
|
- Click "Report a vulnerability"
|
|
- Create a private security advisory
|
|
3. **Alternatively**, email security concerns to the repository owner if GitHub Security Advisories are unavailable
|
|
4. **DO** include:
|
|
- Description of the vulnerability
|
|
- Steps to reproduce
|
|
- Potential impact
|
|
- Suggested fix (if available)
|
|
|
|
### What to Report
|
|
|
|
Report any security concerns including:
|
|
|
|
- Command injection vulnerabilities
|
|
- Path traversal issues
|
|
- Secret exposure in logs
|
|
- ReDoS vulnerabilities
|
|
- Unsafe input handling
|
|
- Supply chain security issues
|
|
- Privilege escalation risks
|
|
|
|
### Response Timeline
|
|
|
|
- **24 hours**: Initial response acknowledging receipt
|
|
- **7 days**: Assessment and severity classification
|
|
- **30 days**: Fix developed and tested (for confirmed vulnerabilities)
|
|
- **Public disclosure**: Coordinated after fix is released
|
|
|
|
### Security Updates
|
|
|
|
When security issues are fixed:
|
|
|
|
1. A patch is released
|
|
2. Affected actions are updated
|
|
3. Security advisory is published
|
|
4. Users are notified via GitHub Security Advisories
|
|
|
|
## Audit History
|
|
|
|
### Phase 1: Script Injection Prevention (2024)
|
|
|
|
- Converted 43 actions to use environment variables
|
|
- Eliminated all direct `${{ inputs.* }}` usage in shell scripts
|
|
- Added comprehensive input validation
|
|
- Status: ✅ Complete
|
|
|
|
### Phase 2: Enhanced Security (2024)
|
|
|
|
- Replaced custom Bun installation with official action
|
|
- Replaced custom Trivy installation with official action
|
|
- Added secret masking to 6 critical actions
|
|
- Optimized file hashing in common-cache
|
|
- Status: ✅ Complete
|
|
|
|
### Phase 3: Documentation & Policy (2024)
|
|
|
|
- Added permissions comments to all 43 actions
|
|
- Created security policy (this document)
|
|
- Documented best practices
|
|
- Status: ✅ Complete
|
|
|
|
## Security Testing
|
|
|
|
All actions include:
|
|
|
|
- **Unit tests**: ShellSpec tests for action logic
|
|
- **Integration tests**: End-to-end workflow validation
|
|
- **Validation tests**: pytest tests for input validation
|
|
- **Security tests**: Command injection prevention tests
|
|
|
|
Run security tests:
|
|
|
|
```bash
|
|
make test
|
|
```
|
|
|
|
## Additional Resources
|
|
|
|
- [GitHub Actions Security Hardening](https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions)
|
|
- [OWASP Command Injection](https://owasp.org/www-community/attacks/Command_Injection)
|
|
- [CWE-78: OS Command Injection](https://cwe.mitre.org/data/definitions/78.html)
|
|
- [Supply Chain Security](https://slsa.dev/)
|
|
|
|
## License
|
|
|
|
This security policy is part of the repository and follows the same license.
|
|
|
|
## Contact
|
|
|
|
**For security vulnerabilities:**
|
|
|
|
- **Primary**: Create a private security advisory in the repository's Security tab
|
|
- **Fallback**: Email the repository owner if Security Advisories are unavailable
|
|
|
|
---
|
|
|
|
**Last Updated**: 2025-09-29
|
|
**Policy Version**: 1.0.0
|