mirror of
https://github.com/ivuorinen/dotfiles.git
synced 2026-02-15 00:53:27 +00:00
Ismo Vuorinen
6d72003446
* fix(ci): replace broad permissions with specific scopes in workflows
Replace read-all/write-all with minimum required permission scopes
across all GitHub Actions workflows to follow the principle of least
privilege (SonarCloud rule githubactions:S8234).
* fix(shell): use [[ instead of [ for conditional tests
Replace single brackets with double brackets in bash conditional
expressions across 14 files (28 changes). All scripts use bash
shebangs so [[ is safe everywhere (SonarCloud rule shelldre:S7688).
* fix(shell): add explicit return statements to functions
Add return 0 as the last statement in ~46 shell functions across
17 files that previously relied on implicit return codes
(SonarCloud rule shelldre:S7682).
* fix(shell): assign positional parameters to local variables
Replace direct $1/$2/$3 usage with named local variables in _log(),
msg(), msg_err(), msg_done(), msg_run(), msg_ok(), and array_diff()
(SonarCloud rule shelldre:S7679).
* fix(python): replace dict() constructor with literal
Use {} instead of dict() for empty dictionary initialization
(SonarCloud rule python:S7498).
* fix(shell): fix husky shebang and tolerate npm outdated exit code
* docs(shell): add function docstring comments
* fix(shell): fix heredoc indentation in x-sonarcloud
* feat(python): add ruff linter and formatter configuration
* fix(ci): align megalinter config with biome, ruff, and shfmt settings
* fix(ci): disable black and yaml-prettier in megalinter config
* chore(ci): update ruff-pre-commit to v0.15.0 and fix hook name
* fix(scripts): check for .git dir before skipping clone in install-fonts
* fix(shell): address code review issues in scripts and shared.sh
- Guard wezterm show-keys failure in create-wezterm-keymaps.sh
- Stop masking git failures with return 0 in install-cheat-purebashbible.sh
- Add missing shared.sh source in install-xcode-cli-tools.sh
- Replace exit 1 with return 1 in sourced shared.sh
* fix(scripts): address code review and security findings
- Guard wezterm show-keys failure in create-wezterm-keymaps.sh
- Stop masking git failures with return 0 in install-cheat-purebashbible.sh
- Add missing shared.sh source in install-xcode-cli-tools.sh
- Replace exit 1 with return 1 in sourced shared.sh
- Remove shell=True subprocess calls in x-git-largest-files.py
* style(shell): apply shfmt formatting and add args to pre-commit hook
* fix(python): suppress bandit false positives in x-git-largest-files
* fix(python): add nosemgrep suppression for check_output call
* feat(format): add prettier for YAML formatting
Install prettier, add .prettierrc.json config (200-char width, 2-space
indent, LF endings), .prettierignore, yarn scripts (lint:prettier,
fix:prettier, format:yaml), and pre-commit hook scoped to YAML files.
* style(yaml): apply prettier formatting
* fix(scripts): address remaining code review findings
- Python: use list comprehension to filter empty strings instead of
slicing off the last element
- create-wezterm-keymaps: write to temp file and mv for atomic updates
- install-xcode-cli-tools: fix shellcheck source directive path
* fix(python): sort imports alphabetically in x-git-largest-files
* fix(lint): disable PYTHON_ISORT in MegaLinter, ruff handles it
* chore(git): add __pycache__ to gitignore
* fix(python): rename ambiguous variable l to line (E741)
* style: remove trailing whitespace and blank lines
* style(fzf): apply shfmt formatting
* style(shell): apply shfmt formatting
* docs(plans): add design documents
* style(docs): add language specifier to fenced code block
* feat(lint): add markdown-table-formatter to dev tooling
Add markdown-table-formatter as a dev dependency with yarn scripts
(lint:md-table, fix:md-table) and a local pre-commit hook to
automatically format markdown tables on commit.
56 lines
1.8 KiB
Markdown
56 lines
1.8 KiB
Markdown
# dfm Cleanup Design
|
|
|
|
## Summary
|
|
|
|
Clean up `local/bin/dfm` to fix bugs, remove dead code, improve
|
|
cross-platform portability, and make error handling consistent.
|
|
|
|
## Changes
|
|
|
|
### 1. Bash Version Bootstrap
|
|
|
|
Add a check at the top of the script (after variable declarations)
|
|
that requires bash 4.0+. On macOS, if bash is too old, install
|
|
Homebrew (if missing) and bash, then print instructions and exit.
|
|
The check itself uses only bash 3.2-compatible syntax.
|
|
|
|
### 2. Remove Fish Dead Code
|
|
|
|
Remove `CURRENT_SHELL` detection, `source_file()` function, and all
|
|
fish branches. Replace `source_file` calls with direct `source`.
|
|
The script has a bash shebang — fish handling was unreachable.
|
|
|
|
### 3. Bug Fixes
|
|
|
|
- Remove `ntfy` from install menu (no install script exists)
|
|
- Fix `msg)` → `msgr)` case label in `section_tests`
|
|
- Guard all `shift` calls against empty argument lists
|
|
- Quote `$width` in `menu_builder` seq calls
|
|
- Fix `$"..."` locale string → `"..."` in `usage()`
|
|
- Fix `exit 0` on apt.txt error → `return 1`
|
|
|
|
### 4. Replace `declare -A` in `section_scripts`
|
|
|
|
Replace associative array with indexed `"name:desc"` array,
|
|
matching the pattern used everywhere else in the script.
|
|
Move `get_script_description()` to top-level (out of the function).
|
|
|
|
### 5. Early-Return Guards & exit → return
|
|
|
|
- `section_brew()`: Early return with `msgr warn` if brew unavailable.
|
|
Remove duplicate `! x-have brew` check.
|
|
- `section_apt()`: Same pattern for apt.
|
|
- `section_check()`: Replace `exit` with `return`.
|
|
- `section_apt() install`: Replace `exit` with `return`.
|
|
- `section_brew() untracked`: Replace `exit` with `return`.
|
|
|
|
## Files Changed
|
|
|
|
- `local/bin/dfm` (all changes)
|
|
|
|
## Verification
|
|
|
|
- `yarn test` (existing bats test)
|
|
- `shellcheck local/bin/dfm`
|
|
- `bash -n local/bin/dfm` (syntax check)
|